From: Adrian Hunter <adrian.hunter@intel.com>
To: Baolin Wang <baolin.wang@linaro.org>,
ulf.hansson@linaro.org, zhang.lyra@gmail.com,
orsonzhai@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com
Cc: vincent.guittot@linaro.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] mmc: sdhci-sprd: Add start_signal_voltage_switch ops
Date: Mon, 1 Jul 2019 16:31:18 +0300 [thread overview]
Message-ID: <09a99609-9126-1df5-5ec4-bffe65daeca6@intel.com> (raw)
In-Reply-To: <89fb15e88f33a3c1ce7b5eefa9414a20c984c579.1561094029.git.baolin.wang@linaro.org>
On 21/06/19 9:12 AM, Baolin Wang wrote:
> For Spreadtrum SD host controller, we can not use standard SD registers
> to change and detect the I/O voltage signals, since our voltage regulator
> for I/O is fixed in hardware, and no signals were connected to the SD
> controller. Thus add Spreadtrum specific voltage switch ops to change
> voltage instead of using standard SD host registers.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-sprd.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 024c3c5..8b23c88 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -403,6 +403,22 @@ static void sdhci_sprd_request(struct mmc_host *mmc, struct mmc_request *mrq)
> sdhci_request(mmc, mrq);
> }
>
> +static int sdhci_sprd_voltage_switch(struct mmc_host *mmc, struct mmc_ios *ios)
> +{
> + int ret;
> +
> + if (!IS_ERR(mmc->supply.vqmmc)) {
> + ret = mmc_regulator_set_vqmmc(mmc, ios);
> + if (ret) {
> + pr_err("%s: Switching signalling voltage failed\n",
> + mmc_hostname(mmc));
> + return ret;
> + }
> + }
> +
> + return 0;
> +}
> +
> static void sdhci_sprd_hs400_enhanced_strobe(struct mmc_host *mmc,
> struct mmc_ios *ios)
> {
> @@ -470,6 +486,14 @@ static int sdhci_sprd_probe(struct platform_device *pdev)
> host->mmc_host_ops.request = sdhci_sprd_request;
> host->mmc_host_ops.hs400_enhanced_strobe =
> sdhci_sprd_hs400_enhanced_strobe;
> + /*
> + * We can not use the standard ops to change and detect the voltage
> + * signal for Spreadtrum SD host controller, since our voltage regulator
> + * for I/O is fixed in hardware, that means we do not need control
> + * the standard SD host controller to change the I/O voltage.
> + */
> + host->mmc_host_ops.start_signal_voltage_switch =
> + sdhci_sprd_voltage_switch;
>
> host->mmc->caps = MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED |
> MMC_CAP_ERASE | MMC_CAP_CMD23;
>
next prev parent reply other threads:[~2019-07-01 13:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 6:12 [PATCH 0/3] Optimize voltage switch for the SD controller Baolin Wang
2019-06-21 6:12 ` [PATCH 1/3] mmc: sdhci-sprd: Add start_signal_voltage_switch ops Baolin Wang
2019-07-01 13:31 ` Adrian Hunter [this message]
2019-06-21 6:12 ` [PATCH 2/3] dt-bindings: mmc: sprd: Add pinctrl support Baolin Wang
2019-06-21 6:12 ` [PATCH 3/3] mmc: sdhci-sprd: Add pin control support for voltage switch Baolin Wang
2019-07-01 13:31 ` Adrian Hunter
2019-07-08 11:55 ` [PATCH 0/3] Optimize voltage switch for the SD controller Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09a99609-9126-1df5-5ec4-bffe65daeca6@intel.com \
--to=adrian.hunter@intel.com \
--cc=baolin.wang@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).