From: Adrian Hunter <adrian.hunter@intel.com>
To: Baolin Wang <baolin.wang@linaro.org>,
ulf.hansson@linaro.org, zhang.lyra@gmail.com,
orsonzhai@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com
Cc: vincent.guittot@linaro.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] mmc: sdhci-sprd: Add pin control support for voltage switch
Date: Mon, 1 Jul 2019 16:31:25 +0300 [thread overview]
Message-ID: <bc6ae189-ca6b-5447-907e-41ec05b2926c@intel.com> (raw)
In-Reply-To: <db6d2b2d6170fd2409916c5c41b857f4bc587a15.1561094029.git.baolin.wang@linaro.org>
On 21/06/19 9:12 AM, Baolin Wang wrote:
> For Spreadtrum SD card voltage switching, besides regulator setting,
> it also need switch related pin's state to output corresponding voltage.
>
> This patch adds pin control operation to support voltage switch.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-sprd.c | 54 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 54 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 8b23c88..6ee340a 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -12,6 +12,7 @@
> #include <linux/of.h>
> #include <linux/of_device.h>
> #include <linux/of_gpio.h>
> +#include <linux/pinctrl/consumer.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/regulator/consumer.h>
> @@ -72,6 +73,9 @@ struct sdhci_sprd_host {
> struct clk *clk_sdio;
> struct clk *clk_enable;
> struct clk *clk_2x_enable;
> + struct pinctrl *pinctrl;
> + struct pinctrl_state *pins_uhs;
> + struct pinctrl_state *pins_default;
> u32 base_rate;
> int flags; /* backup of host attribute */
> u32 phy_delay[MMC_TIMING_MMC_HS400 + 2];
> @@ -405,6 +409,8 @@ static void sdhci_sprd_request(struct mmc_host *mmc, struct mmc_request *mrq)
>
> static int sdhci_sprd_voltage_switch(struct mmc_host *mmc, struct mmc_ios *ios)
> {
> + struct sdhci_host *host = mmc_priv(mmc);
> + struct sdhci_sprd_host *sprd_host = TO_SPRD_HOST(host);
> int ret;
>
> if (!IS_ERR(mmc->supply.vqmmc)) {
> @@ -416,6 +422,37 @@ static int sdhci_sprd_voltage_switch(struct mmc_host *mmc, struct mmc_ios *ios)
> }
> }
>
> + if (IS_ERR(sprd_host->pinctrl))
> + return 0;
> +
> + switch (ios->signal_voltage) {
> + case MMC_SIGNAL_VOLTAGE_180:
> + ret = pinctrl_select_state(sprd_host->pinctrl,
> + sprd_host->pins_uhs);
> + if (ret) {
> + pr_err("%s: failed to select uhs pin state\n",
> + mmc_hostname(mmc));
> + return ret;
> + }
> + break;
> +
> + default:
> + /* fall-through */
> + case MMC_SIGNAL_VOLTAGE_330:
> + ret = pinctrl_select_state(sprd_host->pinctrl,
> + sprd_host->pins_default);
> + if (ret) {
> + pr_err("%s: failed to select default pin state\n",
> + mmc_hostname(mmc));
> + return ret;
> + }
> + break;
> + }
> +
> + /* Wait for 300 ~ 500 us for pin state stable */
> + usleep_range(300, 500);
> + sdhci_reset(host, SDHCI_RESET_CMD | SDHCI_RESET_DATA);
> +
> return 0;
> }
>
> @@ -504,6 +541,23 @@ static int sdhci_sprd_probe(struct platform_device *pdev)
> sprd_host = TO_SPRD_HOST(host);
> sdhci_sprd_phy_param_parse(sprd_host, pdev->dev.of_node);
>
> + sprd_host->pinctrl = devm_pinctrl_get(&pdev->dev);
> + if (!IS_ERR(sprd_host->pinctrl)) {
> + sprd_host->pins_uhs =
> + pinctrl_lookup_state(sprd_host->pinctrl, "state_uhs");
> + if (IS_ERR(sprd_host->pins_uhs)) {
> + ret = PTR_ERR(sprd_host->pins_uhs);
> + goto pltfm_free;
> + }
> +
> + sprd_host->pins_default =
> + pinctrl_lookup_state(sprd_host->pinctrl, "default");
> + if (IS_ERR(sprd_host->pins_default)) {
> + ret = PTR_ERR(sprd_host->pins_default);
> + goto pltfm_free;
> + }
> + }
> +
> clk = devm_clk_get(&pdev->dev, "sdio");
> if (IS_ERR(clk)) {
> ret = PTR_ERR(clk);
>
next prev parent reply other threads:[~2019-07-01 13:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 6:12 [PATCH 0/3] Optimize voltage switch for the SD controller Baolin Wang
2019-06-21 6:12 ` [PATCH 1/3] mmc: sdhci-sprd: Add start_signal_voltage_switch ops Baolin Wang
2019-07-01 13:31 ` Adrian Hunter
2019-06-21 6:12 ` [PATCH 2/3] dt-bindings: mmc: sprd: Add pinctrl support Baolin Wang
2019-06-21 6:12 ` [PATCH 3/3] mmc: sdhci-sprd: Add pin control support for voltage switch Baolin Wang
2019-07-01 13:31 ` Adrian Hunter [this message]
2019-07-08 11:55 ` [PATCH 0/3] Optimize voltage switch for the SD controller Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc6ae189-ca6b-5447-907e-41ec05b2926c@intel.com \
--to=adrian.hunter@intel.com \
--cc=baolin.wang@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).