From: Lars-Peter Clausen <lars@metafoo.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Puranjay Mohan <puranjay12@gmail.com>
Cc: Alexandru Ardelean <alexandru.ardelean@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] iio: temperature: add driver support for ti tmp117
Date: Fri, 2 Apr 2021 10:14:47 +0200 [thread overview]
Message-ID: <0d2bce88-1c23-a711-6a37-118173066ab5@metafoo.de> (raw)
In-Reply-To: <CAHp75Vcmyvi4V2D0cnmobTGHCS_ci2FC=cBF8tEoG9v51o8RmQ@mail.gmail.com>
On 4/1/21 11:36 AM, Andy Shevchenko wrote:
> [...]
>> + case IIO_CHAN_INFO_SCALE:
>> + /* Conversion from 10s of uC to mC
>> + * as IIO reports temperature in mC
>> + */
>> + *val = TMP117_RESOLUTION_10UC / 10000;
>> + *val2 = (TMP117_RESOLUTION_10UC % 10000) * 100;
>> + return IIO_VAL_INT_PLUS_MICRO;
> You use 10000 many times, can you give it an appropriate name (via #define)?
#define TENTHOUSAND 10000 ;)
next prev parent reply other threads:[~2021-04-02 8:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 9:16 [PATCH v2 0/2] iio: temperature: add support for tmp117 Puranjay Mohan
2021-04-01 9:16 ` [PATCH v2 1/2] dt-bindings: iio: temperature: Add DT bindings for TMP117 Puranjay Mohan
2021-04-01 14:56 ` Rob Herring
2021-04-01 15:13 ` Jonathan Cameron
2021-04-01 16:09 ` Rob Herring
2021-04-01 9:16 ` [PATCH v2 2/2] iio: temperature: add driver support for ti tmp117 Puranjay Mohan
2021-04-01 9:36 ` Andy Shevchenko
2021-04-02 8:14 ` Lars-Peter Clausen [this message]
2021-04-03 13:52 ` Andy Shevchenko
2021-04-02 8:13 ` Lars-Peter Clausen
2021-04-03 14:58 ` Puranjay Mohan
2021-04-03 15:03 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d2bce88-1c23-a711-6a37-118173066ab5@metafoo.de \
--to=lars@metafoo.de \
--cc=alexandru.ardelean@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puranjay12@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).