From: Rob Herring <robh@kernel.org>
To: Puranjay Mohan <puranjay12@gmail.com>
Cc: alexandru.ardelean@analog.com, jic23@kernel.org,
devicetree@vger.kernel.org, knaack.h@gmx.de,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
lars@metafoo.de
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: temperature: Add DT bindings for TMP117
Date: Thu, 1 Apr 2021 11:09:51 -0500 [thread overview]
Message-ID: <20210401160951.GA522095@robh.at.kernel.org> (raw)
In-Reply-To: <20210401091648.87421-2-puranjay12@gmail.com>
On Thu, Apr 01, 2021 at 02:46:47PM +0530, Puranjay Mohan wrote:
> Add devicetree binding document for TMP117, a digital temperature sensor.
Please run checkpatch.pl and fix trailing WS.
>
> Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
> ---
> .../bindings/iio/temperature/ti,tmp117.yaml | 34 +++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> new file mode 100644
> index 000000000..1ead22317
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/iio/temperature/ti,tmp117.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: "TI TMP117 - Digital temperature sensor with integrated NV memory"
> +
> +description: |
> + TI TMP117 - Digital temperature sensor with integrated NV memory that supports
> + I2C interface.
> + https://www.ti.com/lit/gpn/tmp1
> +
> +maintainers:
> + - "Puranjay Mohan <puranjay12@gmail.com>"
Don't need quotes.
> +
> +properties:
> + compatible:
> + enum:
> + - "ti,tmp117"
Don't need quotes.
Blank line here.
> + reg:
> + maxItems: 1
blank line here.
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + tmp117@48 {
> + compatible = "ti,tmp117";
> + reg = <0x48>;
You could just add to trivial-devices.yaml.
> + };
> --
> 2.30.1
>
next prev parent reply other threads:[~2021-04-01 18:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 9:16 [PATCH v2 0/2] iio: temperature: add support for tmp117 Puranjay Mohan
2021-04-01 9:16 ` [PATCH v2 1/2] dt-bindings: iio: temperature: Add DT bindings for TMP117 Puranjay Mohan
2021-04-01 14:56 ` Rob Herring
2021-04-01 15:13 ` Jonathan Cameron
2021-04-01 16:09 ` Rob Herring [this message]
2021-04-01 9:16 ` [PATCH v2 2/2] iio: temperature: add driver support for ti tmp117 Puranjay Mohan
2021-04-01 9:36 ` Andy Shevchenko
2021-04-02 8:14 ` Lars-Peter Clausen
2021-04-03 13:52 ` Andy Shevchenko
2021-04-02 8:13 ` Lars-Peter Clausen
2021-04-03 14:58 ` Puranjay Mohan
2021-04-03 15:03 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401160951.GA522095@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puranjay12@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).