* [PATCH v3] ARM64: dts: meson-axg: enable IR controller
@ 2017-12-15 14:59 Yixun Lan
[not found] ` <20171215145906.1494-1-yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Yixun Lan @ 2017-12-15 14:59 UTC (permalink / raw)
To: Kevin Hilman, devicetree
Cc: Rob Herring, Neil Armstrong, Jerome Brunet, Mark Rutland,
Carlo Caione, Yixun Lan, linux-amlogic, linux-arm-kernel,
linux-kernel
Enable IR remote controller which found in Amlogic's Meson-AXG SoCs.
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
Changes since v2 at [2]
- rebase to Kevin's v4.16/dt64 branch
- this patch depend on pinctrl DT driver
Changes since v1 at [1]:
- drop the compatbile 'amlogic,meson-gx-ir'
[2]
http://lists.infradead.org/pipermail/linux-amlogic/2017-December/005574.html
[1]
http://lists.infradead.org/pipermail/linux-amlogic/2017-November/005527.html
---
arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 6 ++++++
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 14 ++++++++++++++
2 files changed, 20 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
index 70eca1f8736a..e85fb665f12e 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
@@ -20,3 +20,9 @@
&uart_AO {
status = "okay";
};
+
+&ir {
+ status = "okay";
+ pinctrl-0 = <&remote_input_ao_pins>;
+ pinctrl-names = "default";
+};
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index a0d7b10da512..1cd34141a5c1 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -223,6 +223,13 @@
#gpio-cells = <2>;
gpio-ranges = <&pinctrl_aobus 0 0 15>;
};
+
+ remote_input_ao_pins: remote_input_ao {
+ mux {
+ groups = "remote_input_ao";
+ function = "remote_input_ao";
+ };
+ };
};
uart_AO: serial@3000 {
@@ -242,6 +249,13 @@
clock-names = "xtal", "pclk", "baud";
status = "disabled";
};
+
+ ir: ir@8000 {
+ compatible = "amlogic,meson-gxbb-ir";
+ reg = <0x0 0x8000 0x0 0x20>;
+ interrupts = <GIC_SPI 196 IRQ_TYPE_EDGE_RISING>;
+ status = "disabled";
+ };
};
};
};
--
2.15.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] ARM64: dts: meson-axg: enable IR controller
[not found] ` <20171215145906.1494-1-yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
@ 2017-12-15 15:01 ` Jerome Brunet
[not found] ` <1513350088.2261.62.camel-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2018-01-17 1:04 ` Kevin Hilman
1 sibling, 1 reply; 4+ messages in thread
From: Jerome Brunet @ 2017-12-15 15:01 UTC (permalink / raw)
To: Yixun Lan, Kevin Hilman, devicetree-u79uwXL29TY76Z2rM5mHXA
Cc: Rob Herring, Neil Armstrong, Mark Rutland, Carlo Caione,
linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Fri, 2017-12-15 at 22:59 +0800, Yixun Lan wrote:
> Enable IR remote controller which found in Amlogic's Meson-AXG SoCs.
>
> Signed-off-by: Yixun Lan <yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
>
> ---
>
> Changes since v2 at [2]
> - rebase to Kevin's v4.16/dt64 branch
> - this patch depend on pinctrl DT driver
>
> Changes since v1 at [1]:
> - drop the compatbile 'amlogic,meson-gx-ir'
>
> [2]
> http://lists.infradead.org/pipermail/linux-amlogic/2017-December/005574.html
>
> [1]
> http://lists.infradead.org/pipermail/linux-amlogic/2017-November/005527.html
> ---
> arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 6 ++++++
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 14 ++++++++++++++
> 2 files changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> index 70eca1f8736a..e85fb665f12e 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> @@ -20,3 +20,9 @@
> &uart_AO {
> status = "okay";
> };
> +
> +&ir {
> + status = "okay";
> + pinctrl-0 = <&remote_input_ao_pins>;
> + pinctrl-names = "default";
> +};
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index a0d7b10da512..1cd34141a5c1 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -223,6 +223,13 @@
> #gpio-cells = <2>;
> gpio-ranges = <&pinctrl_aobus 0 0 15>;
> };
> +
> + remote_input_ao_pins: remote_input_ao {
> + mux {
> + groups = "remote_input_ao";
> + function = "remote_input_ao";
> + };
> + };
> };
>
> uart_AO: serial@3000 {
> @@ -242,6 +249,13 @@
> clock-names = "xtal", "pclk", "baud";
> status = "disabled";
> };
> +
> + ir: ir@8000 {
> + compatible = "amlogic,meson-gxbb-ir";
compatible = "amlogic,meson-axg-ir", "amlogic,meson-gxbb-ir";
please (and the binding doc patch)
> + reg = <0x0 0x8000 0x0 0x20>;
> + interrupts = <GIC_SPI 196 IRQ_TYPE_EDGE_RISING>;
> + status = "disabled";
> + };
> };
> };
> };
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] ARM64: dts: meson-axg: enable IR controller
[not found] ` <1513350088.2261.62.camel-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
@ 2017-12-15 15:06 ` Yixun Lan
0 siblings, 0 replies; 4+ messages in thread
From: Yixun Lan @ 2017-12-15 15:06 UTC (permalink / raw)
To: Jerome Brunet, Kevin Hilman, devicetree-u79uwXL29TY76Z2rM5mHXA
Cc: yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ, Rob Herring, Neil Armstrong,
Mark Rutland, Carlo Caione,
linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Hi Jerome
On 12/15/2017 11:01 PM, Jerome Brunet wrote:
> On Fri, 2017-12-15 at 22:59 +0800, Yixun Lan wrote:
>> Enable IR remote controller which found in Amlogic's Meson-AXG SoCs.
>>
>> Signed-off-by: Yixun Lan <yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
>>
>> ---
>>
>> Changes since v2 at [2]
>> - rebase to Kevin's v4.16/dt64 branch
>> - this patch depend on pinctrl DT driver
>>
>> Changes since v1 at [1]:
>> - drop the compatbile 'amlogic,meson-gx-ir'
>>
>> [2]
>> http://lists.infradead.org/pipermail/linux-amlogic/2017-December/005574.html
>>
>> [1]
>> http://lists.infradead.org/pipermail/linux-amlogic/2017-November/005527.html
>> ---
>> arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 6 ++++++
>> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 14 ++++++++++++++
>> 2 files changed, 20 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
>> index 70eca1f8736a..e85fb665f12e 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
>> @@ -20,3 +20,9 @@
>> &uart_AO {
>> status = "okay";
>> };
>> +
>> +&ir {
>> + status = "okay";
>> + pinctrl-0 = <&remote_input_ao_pins>;
>> + pinctrl-names = "default";
>> +};
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> index a0d7b10da512..1cd34141a5c1 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> @@ -223,6 +223,13 @@
>> #gpio-cells = <2>;
>> gpio-ranges = <&pinctrl_aobus 0 0 15>;
>> };
>> +
>> + remote_input_ao_pins: remote_input_ao {
>> + mux {
>> + groups = "remote_input_ao";
>> + function = "remote_input_ao";
>> + };
>> + };
>> };
>>
>> uart_AO: serial@3000 {
>> @@ -242,6 +249,13 @@
>> clock-names = "xtal", "pclk", "baud";
>> status = "disabled";
>> };
>> +
>> + ir: ir@8000 {
>> + compatible = "amlogic,meson-gxbb-ir";
>
> compatible = "amlogic,meson-axg-ir", "amlogic,meson-gxbb-ir";
>
> please (and the binding doc patch)
what's the policy for adding new compatible string?
is this a must even we don't use it for now?
or what's the problem if adding it when we really need it
>
>> + reg = <0x0 0x8000 0x0 0x20>;
>> + interrupts = <GIC_SPI 196 IRQ_TYPE_EDGE_RISING>;
>> + status = "disabled";
>> + };
>> };
>> };
>> };
>
> .
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] ARM64: dts: meson-axg: enable IR controller
[not found] ` <20171215145906.1494-1-yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
2017-12-15 15:01 ` Jerome Brunet
@ 2018-01-17 1:04 ` Kevin Hilman
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2018-01-17 1:04 UTC (permalink / raw)
To: Yixun Lan
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring, Neil Armstrong,
Jerome Brunet, Mark Rutland, Carlo Caione,
linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Yixun Lan <yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org> writes:
> Enable IR remote controller which found in Amlogic's Meson-AXG SoCs.
>
> Signed-off-by: Yixun Lan <yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
I think I forgot to reply to this one, but for the record, this was
applied to v4.16/dt64.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-17 1:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-15 14:59 [PATCH v3] ARM64: dts: meson-axg: enable IR controller Yixun Lan
[not found] ` <20171215145906.1494-1-yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
2017-12-15 15:01 ` Jerome Brunet
[not found] ` <1513350088.2261.62.camel-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-12-15 15:06 ` Yixun Lan
2018-01-17 1:04 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).