* [PATCH][v2] dt-bindings: ifc: Update endianness usage @ 2017-11-30 3:42 Prabhakar Kushwaha [not found] ` <1512013344-4042-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> 0 siblings, 1 reply; 10+ messages in thread From: Prabhakar Kushwaha @ 2017-11-30 3:42 UTC (permalink / raw) To: devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, shawnguo-DgEjT+Ai2ygdnm+yROfE0A Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Prabhakar Kushwaha IFC controller version < 2.0 support IFC register access as big endian. These controller version also require IFC NOR signals to be connected in reverse order with NOR flash. IFC >= 2.0 is other way around. So updating IFC binding to take care of both using endianness field. Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> --- Changes for v2: updated subject Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt index 89427b0..824a2ca 100644 --- a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt +++ b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt @@ -18,8 +18,10 @@ Properties: interrupt (NAND_EVTER_STAT). If there is only one, that interrupt reports both types of event. -- little-endian : If this property is absent, the big-endian mode will - be in use as default for registers. +- little-endian or big-endin : It represents how IFC registers to be accessed. + It also represents connection between controller and + NOR flash. If this property is absent, the big-endian + mode will be in use as default. - ranges : Each range corresponds to a single chipselect, and covers the entire access window as configured. -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 10+ messages in thread
[parent not found: <1512013344-4042-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>]
* [PATCH 1/2][v2] ARM: dts: Add big-endian for IFC on LS1021A [not found] ` <1512013344-4042-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> @ 2017-11-30 3:42 ` Prabhakar Kushwaha [not found] ` <1512013344-4042-2-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> 2017-11-30 3:42 ` [PATCH 2/2][v2] ARM: dts: ls1021aqds: Add nand node for ifc controller Prabhakar Kushwaha 2017-11-30 4:37 ` [PATCH][v2] dt-bindings: ifc: Update endianness usage Florian Fainelli 2 siblings, 1 reply; 10+ messages in thread From: Prabhakar Kushwaha @ 2017-11-30 3:42 UTC (permalink / raw) To: devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, shawnguo-DgEjT+Ai2ygdnm+yROfE0A Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Jagdish Gediya, Alison Wang, Prabhakar Kushwaha From: Jagdish Gediya <jagdish.gediya-3arQi8VN3Tc@public.gmane.org> For the patch to update struct map_info's swap field based on device characteristics defined in device tree, big-endian parameter is added for LS1021A. Signed-off-by: Alison Wang <alison.wang-3arQi8VN3Tc@public.gmane.org> Signed-off-by: Jagdish Gediya <jagdish.gediya-3arQi8VN3Tc@public.gmane.org> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> --- Changes for v2: updated subject arch/arm/boot/dts/ls1021a.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi index 9319e1f..babb086 100644 --- a/arch/arm/boot/dts/ls1021a.dtsi +++ b/arch/arm/boot/dts/ls1021a.dtsi @@ -145,6 +145,7 @@ ifc: ifc@1530000 { compatible = "fsl,ifc", "simple-bus"; reg = <0x0 0x1530000 0x0 0x10000>; + big-endian; interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>; }; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 10+ messages in thread
[parent not found: <1512013344-4042-2-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>]
* RE: [PATCH 1/2][v2] ARM: dts: Add big-endian for IFC on LS1021A [not found] ` <1512013344-4042-2-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> @ 2017-12-21 5:14 ` Prabhakar Kushwaha [not found] ` <HE1PR04MB1241E7538E97597B76606FF4970D0-6LN7OEpIatU9TB6uw0n1oM9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 0 siblings, 1 reply; 10+ messages in thread From: Prabhakar Kushwaha @ 2017-12-21 5:14 UTC (permalink / raw) To: Prabhakar Kushwaha, devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, shawnguo-DgEjT+Ai2ygdnm+yROfE0A Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Jagdish Gediya, Alison Wang Hi Shawn, > -----Original Message----- > From: Prabhakar Kushwaha [mailto:prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org] > Sent: Thursday, November 30, 2017 9:12 AM > To: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; mark.rutland-5wv7dgnIgG8@public.gmane.org; > shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; Jagdish Gediya > <jagdish.gediya-3arQi8VN3Tc@public.gmane.org>; Alison Wang <alison.wang-3arQi8VN3Tc@public.gmane.org>; Prabhakar > Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> > Subject: [PATCH 1/2][v2] ARM: dts: Add big-endian for IFC on LS1021A > > From: Jagdish Gediya <jagdish.gediya-3arQi8VN3Tc@public.gmane.org> > > For the patch to update struct map_info's swap field based on device > characteristics defined in device tree, big-endian parameter is added > for LS1021A. > > Signed-off-by: Alison Wang <alison.wang-3arQi8VN3Tc@public.gmane.org> > Signed-off-by: Jagdish Gediya <jagdish.gediya-3arQi8VN3Tc@public.gmane.org> > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> > --- > Changes for v2: updated subject > > arch/arm/boot/dts/ls1021a.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi > index 9319e1f..babb086 100644 > --- a/arch/arm/boot/dts/ls1021a.dtsi > +++ b/arch/arm/boot/dts/ls1021a.dtsi > @@ -145,6 +145,7 @@ > ifc: ifc@1530000 { > compatible = "fsl,ifc", "simple-bus"; > reg = <0x0 0x1530000 0x0 0x10000>; > + big-endian; > interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>; > }; > > -- > 1.9.1 There are no review comments on this patch. Can you please accept this patch --pk -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <HE1PR04MB1241E7538E97597B76606FF4970D0-6LN7OEpIatU9TB6uw0n1oM9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: [PATCH 1/2][v2] ARM: dts: Add big-endian for IFC on LS1021A [not found] ` <HE1PR04MB1241E7538E97597B76606FF4970D0-6LN7OEpIatU9TB6uw0n1oM9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2017-12-21 7:10 ` Shawn Guo 2017-12-21 7:19 ` Prabhakar Kushwaha 0 siblings, 1 reply; 10+ messages in thread From: Shawn Guo @ 2017-12-21 7:10 UTC (permalink / raw) To: Prabhakar Kushwaha Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, Alison Wang, Jagdish Gediya, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Thu, Dec 21, 2017 at 05:14:36AM +0000, Prabhakar Kushwaha wrote: > Hi Shawn, > > > -----Original Message----- > > From: Prabhakar Kushwaha [mailto:prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org] > > Sent: Thursday, November 30, 2017 9:12 AM > > To: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; mark.rutland-5wv7dgnIgG8@public.gmane.org; > > shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org > > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; Jagdish Gediya > > <jagdish.gediya-3arQi8VN3Tc@public.gmane.org>; Alison Wang <alison.wang-3arQi8VN3Tc@public.gmane.org>; Prabhakar > > Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> > > Subject: [PATCH 1/2][v2] ARM: dts: Add big-endian for IFC on LS1021A > > > > From: Jagdish Gediya <jagdish.gediya-3arQi8VN3Tc@public.gmane.org> > > > > For the patch to update struct map_info's swap field based on device > > characteristics defined in device tree, big-endian parameter is added > > for LS1021A. > > > > Signed-off-by: Alison Wang <alison.wang-3arQi8VN3Tc@public.gmane.org> > > Signed-off-by: Jagdish Gediya <jagdish.gediya-3arQi8VN3Tc@public.gmane.org> > > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> > > --- > > Changes for v2: updated subject > > > > arch/arm/boot/dts/ls1021a.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi > > index 9319e1f..babb086 100644 > > --- a/arch/arm/boot/dts/ls1021a.dtsi > > +++ b/arch/arm/boot/dts/ls1021a.dtsi > > @@ -145,6 +145,7 @@ > > ifc: ifc@1530000 { > > compatible = "fsl,ifc", "simple-bus"; > > reg = <0x0 0x1530000 0x0 0x10000>; > > + big-endian; > > interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>; > > }; > > > > -- > > 1.9.1 > > There are no review comments on this patch. > > Can you please accept this patch It seems that the bindings hasn't been ACK-ed by DT maintainer. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 1/2][v2] ARM: dts: Add big-endian for IFC on LS1021A 2017-12-21 7:10 ` Shawn Guo @ 2017-12-21 7:19 ` Prabhakar Kushwaha [not found] ` <HE1PR04MB1241243DE5FE86833DD0B509970D0-6LN7OEpIatU9TB6uw0n1oM9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 0 siblings, 1 reply; 10+ messages in thread From: Prabhakar Kushwaha @ 2017-12-21 7:19 UTC (permalink / raw) To: Shawn Guo Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, Alison Wang, Jagdish Gediya, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Hi Shawn, > -----Original Message----- > From: Shawn Guo [mailto:shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org] > Sent: Thursday, December 21, 2017 12:41 PM > To: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; mark.rutland-5wv7dgnIgG8@public.gmane.org; > Alison Wang <alison.wang-3arQi8VN3Tc@public.gmane.org>; Jagdish Gediya > <jagdish.gediya-3arQi8VN3Tc@public.gmane.org>; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Subject: Re: [PATCH 1/2][v2] ARM: dts: Add big-endian for IFC on LS1021A > > On Thu, Dec 21, 2017 at 05:14:36AM +0000, Prabhakar Kushwaha wrote: > > Hi Shawn, > > > > > -----Original Message----- > > > From: Prabhakar Kushwaha [mailto:prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org] > > > Sent: Thursday, November 30, 2017 9:12 AM > > > To: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; mark.rutland-5wv7dgnIgG8@public.gmane.org; > > > shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org > > > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; Jagdish Gediya > > > <jagdish.gediya-3arQi8VN3Tc@public.gmane.org>; Alison Wang <alison.wang-3arQi8VN3Tc@public.gmane.org>; > Prabhakar > > > Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> > > > Subject: [PATCH 1/2][v2] ARM: dts: Add big-endian for IFC on LS1021A > > > > > > From: Jagdish Gediya <jagdish.gediya-3arQi8VN3Tc@public.gmane.org> > > > > > > For the patch to update struct map_info's swap field based on device > > > characteristics defined in device tree, big-endian parameter is added > > > for LS1021A. > > > > > > Signed-off-by: Alison Wang <alison.wang-3arQi8VN3Tc@public.gmane.org> > > > Signed-off-by: Jagdish Gediya <jagdish.gediya-3arQi8VN3Tc@public.gmane.org> > > > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> > > > --- > > > Changes for v2: updated subject > > > > > > arch/arm/boot/dts/ls1021a.dtsi | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi > > > index 9319e1f..babb086 100644 > > > --- a/arch/arm/boot/dts/ls1021a.dtsi > > > +++ b/arch/arm/boot/dts/ls1021a.dtsi > > > @@ -145,6 +145,7 @@ > > > ifc: ifc@1530000 { > > > compatible = "fsl,ifc", "simple-bus"; > > > reg = <0x0 0x1530000 0x0 0x10000>; > > > + big-endian; > > > interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>; > > > }; > > > > > > -- > > > 1.9.1 > > > > There are no review comments on this patch. > > > > Can you please accept this patch > > It seems that the bindings hasn't been ACK-ed by DT maintainer. > Are you referring to this discussion https://patchwork.ozlabs.org/patch/842543/? Due to which binding are not ACK-ed. --pk -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <HE1PR04MB1241243DE5FE86833DD0B509970D0-6LN7OEpIatU9TB6uw0n1oM9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: [PATCH 1/2][v2] ARM: dts: Add big-endian for IFC on LS1021A [not found] ` <HE1PR04MB1241243DE5FE86833DD0B509970D0-6LN7OEpIatU9TB6uw0n1oM9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2017-12-21 7:32 ` Shawn Guo 0 siblings, 0 replies; 10+ messages in thread From: Shawn Guo @ 2017-12-21 7:32 UTC (permalink / raw) To: Prabhakar Kushwaha Cc: mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A, Alison Wang, Jagdish Gediya, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Thu, Dec 21, 2017 at 07:19:12AM +0000, Prabhakar Kushwaha wrote: > Are you referring to this discussion https://patchwork.ozlabs.org/patch/842543/? > Due to which binding are not ACK-ed. Hmm, I'm talking about Rob's comment below. https://www.spinics.net/lists/arm-kernel/msg620518.html In any case, I cannot apply the dts change before the bindings part gets ACK-ed by DT maintainer. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2][v2] ARM: dts: ls1021aqds: Add nand node for ifc controller [not found] ` <1512013344-4042-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> 2017-11-30 3:42 ` [PATCH 1/2][v2] ARM: dts: Add big-endian for IFC on LS1021A Prabhakar Kushwaha @ 2017-11-30 3:42 ` Prabhakar Kushwaha [not found] ` <1512013344-4042-3-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> 2017-11-30 4:37 ` [PATCH][v2] dt-bindings: ifc: Update endianness usage Florian Fainelli 2 siblings, 1 reply; 10+ messages in thread From: Prabhakar Kushwaha @ 2017-11-30 3:42 UTC (permalink / raw) To: devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, shawnguo-DgEjT+Ai2ygdnm+yROfE0A Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Prabhakar Kushwaha, Jagdish Gediya LS1021AQDS support NAND flash on IFC chip-select 2. So add NAND node in device tree for IFC controller. Signed-off-by: Jagdish Gediya <jagdish.gediya-3arQi8VN3Tc@public.gmane.org> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> --- Changes for v2: updated subject arch/arm/boot/dts/ls1021a-qds.dts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts index 9408753..2b37d04 100644 --- a/arch/arm/boot/dts/ls1021a-qds.dts +++ b/arch/arm/boot/dts/ls1021a-qds.dts @@ -239,6 +239,11 @@ device-width = <1>; }; + nand@2,0 { + compatible = "fsl,ifc-nand"; + reg = <0x2 0x0 0x10000>; + }; + fpga: board-control@3,0 { #address-cells = <1>; #size-cells = <1>; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 10+ messages in thread
[parent not found: <1512013344-4042-3-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>]
* RE: [PATCH 2/2][v2] ARM: dts: ls1021aqds: Add nand node for ifc controller [not found] ` <1512013344-4042-3-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> @ 2017-12-21 5:14 ` Prabhakar Kushwaha 2017-12-21 7:14 ` Shawn Guo 1 sibling, 0 replies; 10+ messages in thread From: Prabhakar Kushwaha @ 2017-12-21 5:14 UTC (permalink / raw) To: Prabhakar Kushwaha, devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, shawnguo-DgEjT+Ai2ygdnm+yROfE0A Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Jagdish Gediya Hi Shawn, > -----Original Message----- > From: Prabhakar Kushwaha [mailto:prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org] > Sent: Thursday, November 30, 2017 9:12 AM > To: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; mark.rutland-5wv7dgnIgG8@public.gmane.org; > shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; Prabhakar Kushwaha > <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>; Jagdish Gediya <jagdish.gediya-3arQi8VN3Tc@public.gmane.org> > Subject: [PATCH 2/2][v2] ARM: dts: ls1021aqds: Add nand node for ifc controller > > LS1021AQDS support NAND flash on IFC chip-select 2. > > So add NAND node in device tree for IFC controller. > > Signed-off-by: Jagdish Gediya <jagdish.gediya-3arQi8VN3Tc@public.gmane.org> > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> > --- > Changes for v2: updated subject > > arch/arm/boot/dts/ls1021a-qds.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a- > qds.dts > index 9408753..2b37d04 100644 > --- a/arch/arm/boot/dts/ls1021a-qds.dts > +++ b/arch/arm/boot/dts/ls1021a-qds.dts > @@ -239,6 +239,11 @@ > device-width = <1>; > }; > > + nand@2,0 { > + compatible = "fsl,ifc-nand"; > + reg = <0x2 0x0 0x10000>; > + }; > + > fpga: board-control@3,0 { > #address-cells = <1>; > #size-cells = <1>; > -- There are no review comments on this patch. Can you please accept this patch --pk -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2][v2] ARM: dts: ls1021aqds: Add nand node for ifc controller [not found] ` <1512013344-4042-3-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> 2017-12-21 5:14 ` Prabhakar Kushwaha @ 2017-12-21 7:14 ` Shawn Guo 1 sibling, 0 replies; 10+ messages in thread From: Shawn Guo @ 2017-12-21 7:14 UTC (permalink / raw) To: Prabhakar Kushwaha Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Jagdish Gediya On Thu, Nov 30, 2017 at 09:12:24AM +0530, Prabhakar Kushwaha wrote: > LS1021AQDS support NAND flash on IFC chip-select 2. > > So add NAND node in device tree for IFC controller. > > Signed-off-by: Jagdish Gediya <jagdish.gediya-3arQi8VN3Tc@public.gmane.org> > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][v2] dt-bindings: ifc: Update endianness usage [not found] ` <1512013344-4042-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> 2017-11-30 3:42 ` [PATCH 1/2][v2] ARM: dts: Add big-endian for IFC on LS1021A Prabhakar Kushwaha 2017-11-30 3:42 ` [PATCH 2/2][v2] ARM: dts: ls1021aqds: Add nand node for ifc controller Prabhakar Kushwaha @ 2017-11-30 4:37 ` Florian Fainelli 2 siblings, 0 replies; 10+ messages in thread From: Florian Fainelli @ 2017-11-30 4:37 UTC (permalink / raw) To: Prabhakar Kushwaha, devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, shawnguo-DgEjT+Ai2ygdnm+yROfE0A Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On 11/29/2017 07:42 PM, Prabhakar Kushwaha wrote: > IFC controller version < 2.0 support IFC register access as > big endian. These controller version also require IFC NOR signals to > be connected in reverse order with NOR flash. > > IFC >= 2.0 is other way around. > > So updating IFC binding to take care of both using endianness field. > > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> > --- > Changes for v2: updated subject > > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > index 89427b0..824a2ca 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > +++ b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > @@ -18,8 +18,10 @@ Properties: > interrupt (NAND_EVTER_STAT). If there is only one, > that interrupt reports both types of event. > > -- little-endian : If this property is absent, the big-endian mode will > - be in use as default for registers. > +- little-endian or big-endin : It represents how IFC registers to be accessed. ^==== big-endian (there is a typo) -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-12-21 7:32 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-11-30 3:42 [PATCH][v2] dt-bindings: ifc: Update endianness usage Prabhakar Kushwaha [not found] ` <1512013344-4042-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> 2017-11-30 3:42 ` [PATCH 1/2][v2] ARM: dts: Add big-endian for IFC on LS1021A Prabhakar Kushwaha [not found] ` <1512013344-4042-2-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> 2017-12-21 5:14 ` Prabhakar Kushwaha [not found] ` <HE1PR04MB1241E7538E97597B76606FF4970D0-6LN7OEpIatU9TB6uw0n1oM9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2017-12-21 7:10 ` Shawn Guo 2017-12-21 7:19 ` Prabhakar Kushwaha [not found] ` <HE1PR04MB1241243DE5FE86833DD0B509970D0-6LN7OEpIatU9TB6uw0n1oM9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2017-12-21 7:32 ` Shawn Guo 2017-11-30 3:42 ` [PATCH 2/2][v2] ARM: dts: ls1021aqds: Add nand node for ifc controller Prabhakar Kushwaha [not found] ` <1512013344-4042-3-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> 2017-12-21 5:14 ` Prabhakar Kushwaha 2017-12-21 7:14 ` Shawn Guo 2017-11-30 4:37 ` [PATCH][v2] dt-bindings: ifc: Update endianness usage Florian Fainelli
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).