* [PATCH 0/5] Add Sound support for iWave RZ/G1M board @ 2017-12-12 18:25 Biju Das 2017-12-12 18:25 ` [PATCH 1/5] ARM: shmobile: defconfig: Enable SGTL5000 audio codec Biju Das ` (5 more replies) 0 siblings, 6 replies; 12+ messages in thread From: Biju Das @ 2017-12-12 18:25 UTC (permalink / raw) To: Rob Herring, Mark Rutland, Russell King Cc: Simon Horman, Magnus Damm, Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel, Biju Das This series aims to add sound support for iWave RZ/G1M board. This patch series has documentation dependency on https://patchwork.kernel.org/patch/10108014/ Biju Das (5): ARM: shmobile: defconfig: Enable SGTL5000 audio codec ARM: dts: r8a7743: Add audio clocks ARM: dts: r8a7743: Add audio DMAC support ARM: dts: r8a7743: Add sound support ARM: dts: iwg20d-q7-common: Enable SGTL5000 audio codec arch/arm/boot/dts/iwg20d-q7-common.dtsi | 24 +++ arch/arm/boot/dts/r8a7743.dtsi | 270 ++++++++++++++++++++++++++++++++ arch/arm/configs/shmobile_defconfig | 1 + 3 files changed, 295 insertions(+) -- 1.9.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/5] ARM: shmobile: defconfig: Enable SGTL5000 audio codec 2017-12-12 18:25 [PATCH 0/5] Add Sound support for iWave RZ/G1M board Biju Das @ 2017-12-12 18:25 ` Biju Das 2017-12-12 18:25 ` [PATCH 2/5] ARM: dts: r8a7743: Add audio clocks Biju Das ` (4 subsequent siblings) 5 siblings, 0 replies; 12+ messages in thread From: Biju Das @ 2017-12-12 18:25 UTC (permalink / raw) To: Rob Herring, Mark Rutland, Russell King Cc: Simon Horman, Magnus Damm, Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel, Biju Das The iWave RZ/G1M Q7 carrier board supports I2S audio codec "SGTL5000". To increase hardware support enable the driver in the shmobile_defconfig multiplatform configuration. Signed-off-by: Biju Das <biju.das@bp.renesas.com> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> --- arch/arm/configs/shmobile_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig index 7b4fc01..d60dbe1 100644 --- a/arch/arm/configs/shmobile_defconfig +++ b/arch/arm/configs/shmobile_defconfig @@ -173,6 +173,7 @@ CONFIG_SND_SOC=y CONFIG_SND_SOC_SH4_FSI=y CONFIG_SND_SOC_RCAR=y CONFIG_SND_SOC_AK4642=y +CONFIG_SND_SOC_SGTL5000=y CONFIG_SND_SOC_WM8978=y CONFIG_SND_SIMPLE_SCU_CARD=y CONFIG_USB=y -- 1.9.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/5] ARM: dts: r8a7743: Add audio clocks 2017-12-12 18:25 [PATCH 0/5] Add Sound support for iWave RZ/G1M board Biju Das 2017-12-12 18:25 ` [PATCH 1/5] ARM: shmobile: defconfig: Enable SGTL5000 audio codec Biju Das @ 2017-12-12 18:25 ` Biju Das [not found] ` <1513103111-45830-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> ` (3 subsequent siblings) 5 siblings, 0 replies; 12+ messages in thread From: Biju Das @ 2017-12-12 18:25 UTC (permalink / raw) To: Rob Herring, Mark Rutland, Russell King Cc: Simon Horman, Magnus Damm, Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel, Biju Das Describe the external audio clocks required by the sound driver. Boards that provide audio clocks need to override the clock frequencies. Signed-off-by: Biju Das <biju.das@bp.renesas.com> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> --- arch/arm/boot/dts/r8a7743.dtsi | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index c09c667..2f0ec9d 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -1238,6 +1238,29 @@ clock-frequency = <0>; }; + /* + * The external audio clocks are configured as 0 Hz fixed frequency + * clocks by default. + * Boards that provide audio clocks should override them. + */ + audio_clk_a: audio_clk_a { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <0>; + }; + + audio_clk_b: audio_clk_b { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <0>; + }; + + audio_clk_c: audio_clk_c { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <0>; + }; + /* External USB clock - can be overridden by the board */ usb_extal_clk: usb_extal { compatible = "fixed-clock"; -- 1.9.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
[parent not found: <1513103111-45830-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>]
* [PATCH 3/5] ARM: dts: r8a7743: Add audio DMAC support [not found] ` <1513103111-45830-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> @ 2017-12-12 18:25 ` Biju Das 0 siblings, 0 replies; 12+ messages in thread From: Biju Das @ 2017-12-12 18:25 UTC (permalink / raw) To: Rob Herring, Mark Rutland, Russell King Cc: Simon Horman, Magnus Damm, Chris Paterson, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Biju Das Instantiate the two audio DMA controllers on the r8a7743 device tree. Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> Reviewed-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> --- arch/arm/boot/dts/r8a7743.dtsi | 62 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index 2f0ec9d..b60527a 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -359,6 +359,68 @@ dma-channels = <15>; }; + audma0: dma-controller@ec700000 { + compatible = "renesas,dmac-r8a7743", + "renesas,rcar-dmac"; + reg = <0 0xec700000 0 0x10000>; + interrupts = <GIC_SPI 346 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 320 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 321 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 322 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 323 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 325 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 326 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 328 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 329 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "error", + "ch0", "ch1", "ch2", "ch3", + "ch4", "ch5", "ch6", "ch7", + "ch8", "ch9", "ch10", "ch11", + "ch12"; + clocks = <&cpg CPG_MOD 502>; + clock-names = "fck"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 502>; + #dma-cells = <1>; + dma-channels = <13>; + }; + + audma1: dma-controller@ec720000 { + compatible = "renesas,dmac-r8a7743", + "renesas,rcar-dmac"; + reg = <0 0xec720000 0 0x10000>; + interrupts = <GIC_SPI 347 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 333 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 334 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 335 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 336 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 337 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 338 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 339 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 340 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 341 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 342 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 343 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 344 IRQ_TYPE_LEVEL_HIGH + GIC_SPI 345 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "error", + "ch0", "ch1", "ch2", "ch3", + "ch4", "ch5", "ch6", "ch7", + "ch8", "ch9", "ch10", "ch11", + "ch12"; + clocks = <&cpg CPG_MOD 501>; + clock-names = "fck"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 501>; + #dma-cells = <1>; + dma-channels = <13>; + }; + usb_dmac0: dma-controller@e65a0000 { compatible = "renesas,r8a7743-usb-dmac", "renesas,usb-dmac"; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4/5] ARM: dts: r8a7743: Add sound support 2017-12-12 18:25 [PATCH 0/5] Add Sound support for iWave RZ/G1M board Biju Das ` (2 preceding siblings ...) [not found] ` <1513103111-45830-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> @ 2017-12-12 18:25 ` Biju Das 2017-12-12 18:25 ` [PATCH 5/5] ARM: dts: iwg20d-q7-common: Enable SGTL5000 audio codec Biju Das 2017-12-13 9:02 ` [PATCH 0/5] Add Sound support for iWave RZ/G1M board Simon Horman 5 siblings, 0 replies; 12+ messages in thread From: Biju Das @ 2017-12-12 18:25 UTC (permalink / raw) To: Rob Herring, Mark Rutland, Russell King Cc: Simon Horman, Magnus Damm, Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel, Biju Das Define the generic r8a7743(RZ/G1M) part of the sound device node. This patch is based on the r8a7791 sound work by Kuninori Morimoto. Signed-off-by: Biju Das <biju.das@bp.renesas.com> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> --- arch/arm/boot/dts/r8a7743.dtsi | 185 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 185 insertions(+) diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index b60527a..59860c8 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -1290,6 +1290,191 @@ resets = <&cpg 319>; status = "disabled"; }; + + rcar_sound: sound@ec500000 { + /* + * #sound-dai-cells is required + * + * Single DAI : #sound-dai-cells = <0>; <&rcar_sound>; + * Multi DAI : #sound-dai-cells = <1>; <&rcar_sound N>; + */ + compatible = "renesas,rcar_sound-r8a7743", + "renesas,rcar_sound-gen2"; + reg = <0 0xec500000 0 0x1000>, /* SCU */ + <0 0xec5a0000 0 0x100>, /* ADG */ + <0 0xec540000 0 0x1000>, /* SSIU */ + <0 0xec541000 0 0x280>, /* SSI */ + <0 0xec740000 0 0x200>; /* Audio DMAC peri peri*/ + reg-names = "scu", "adg", "ssiu", "ssi", "audmapp"; + + clocks = <&cpg CPG_MOD 1005>, + <&cpg CPG_MOD 1006>, <&cpg CPG_MOD 1007>, + <&cpg CPG_MOD 1008>, <&cpg CPG_MOD 1009>, + <&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>, + <&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>, + <&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>, + <&cpg CPG_MOD 1022>, <&cpg CPG_MOD 1023>, + <&cpg CPG_MOD 1024>, <&cpg CPG_MOD 1025>, + <&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>, + <&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>, + <&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>, + <&cpg CPG_MOD 1021>, <&cpg CPG_MOD 1020>, + <&cpg CPG_MOD 1021>, <&cpg CPG_MOD 1020>, + <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>, + <&audio_clk_a>, <&audio_clk_b>, <&audio_clk_c>, + <&cpg CPG_CORE R8A7743_CLK_M2>; + clock-names = "ssi-all", + "ssi.9", "ssi.8", "ssi.7", "ssi.6", "ssi.5", + "ssi.4", "ssi.3", "ssi.2", "ssi.1", "ssi.0", + "src.9", "src.8", "src.7", "src.6", "src.5", + "src.4", "src.3", "src.2", "src.1", "src.0", + "ctu.0", "ctu.1", + "mix.0", "mix.1", + "dvc.0", "dvc.1", + "clk_a", "clk_b", "clk_c", "clk_i"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 1005>, + <&cpg 1006>, <&cpg 1007>, <&cpg 1008>, <&cpg 1009>, + <&cpg 1010>, <&cpg 1011>, <&cpg 1012>, <&cpg 1013>, + <&cpg 1014>, <&cpg 1015>; + reset-names = "ssi-all", + "ssi.9", "ssi.8", "ssi.7", "ssi.6", "ssi.5", + "ssi.4", "ssi.3", "ssi.2", "ssi.1", "ssi.0"; + status = "disabled"; + + rcar_sound,dvc { + dvc0: dvc-0 { + dmas = <&audma1 0xbc>; + dma-names = "tx"; + }; + dvc1: dvc-1 { + dmas = <&audma1 0xbe>; + dma-names = "tx"; + }; + }; + + rcar_sound,mix { + mix0: mix-0 { }; + mix1: mix-1 { }; + }; + + rcar_sound,ctu { + ctu00: ctu-0 { }; + ctu01: ctu-1 { }; + ctu02: ctu-2 { }; + ctu03: ctu-3 { }; + ctu10: ctu-4 { }; + ctu11: ctu-5 { }; + ctu12: ctu-6 { }; + ctu13: ctu-7 { }; + }; + + rcar_sound,src { + src0: src-0 { + interrupts = <GIC_SPI 352 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x85>, <&audma1 0x9a>; + dma-names = "rx", "tx"; + }; + src1: src-1 { + interrupts = <GIC_SPI 353 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x87>, <&audma1 0x9c>; + dma-names = "rx", "tx"; + }; + src2: src-2 { + interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x89>, <&audma1 0x9e>; + dma-names = "rx", "tx"; + }; + src3: src-3 { + interrupts = <GIC_SPI 355 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x8b>, <&audma1 0xa0>; + dma-names = "rx", "tx"; + }; + src4: src-4 { + interrupts = <GIC_SPI 356 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x8d>, <&audma1 0xb0>; + dma-names = "rx", "tx"; + }; + src5: src-5 { + interrupts = <GIC_SPI 357 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x8f>, <&audma1 0xb2>; + dma-names = "rx", "tx"; + }; + src6: src-6 { + interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x91>, <&audma1 0xb4>; + dma-names = "rx", "tx"; + }; + src7: src-7 { + interrupts = <GIC_SPI 359 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x93>, <&audma1 0xb6>; + dma-names = "rx", "tx"; + }; + src8: src-8 { + interrupts = <GIC_SPI 360 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x95>, <&audma1 0xb8>; + dma-names = "rx", "tx"; + }; + src9: src-9 { + interrupts = <GIC_SPI 361 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x97>, <&audma1 0xba>; + dma-names = "rx", "tx"; + }; + }; + + rcar_sound,ssi { + ssi0: ssi-0 { + interrupts = <GIC_SPI 370 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x01>, <&audma1 0x02>, <&audma0 0x15>, <&audma1 0x16>; + dma-names = "rx", "tx", "rxu", "txu"; + }; + ssi1: ssi-1 { + interrupts = <GIC_SPI 371 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x03>, <&audma1 0x04>, <&audma0 0x49>, <&audma1 0x4a>; + dma-names = "rx", "tx", "rxu", "txu"; + }; + ssi2: ssi-2 { + interrupts = <GIC_SPI 372 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x05>, <&audma1 0x06>, <&audma0 0x63>, <&audma1 0x64>; + dma-names = "rx", "tx", "rxu", "txu"; + }; + ssi3: ssi-3 { + interrupts = <GIC_SPI 373 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x07>, <&audma1 0x08>, <&audma0 0x6f>, <&audma1 0x70>; + dma-names = "rx", "tx", "rxu", "txu"; + }; + ssi4: ssi-4 { + interrupts = <GIC_SPI 374 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x09>, <&audma1 0x0a>, <&audma0 0x71>, <&audma1 0x72>; + dma-names = "rx", "tx", "rxu", "txu"; + }; + ssi5: ssi-5 { + interrupts = <GIC_SPI 375 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x0b>, <&audma1 0x0c>, <&audma0 0x73>, <&audma1 0x74>; + dma-names = "rx", "tx", "rxu", "txu"; + }; + ssi6: ssi-6 { + interrupts = <GIC_SPI 376 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x0d>, <&audma1 0x0e>, <&audma0 0x75>, <&audma1 0x76>; + dma-names = "rx", "tx", "rxu", "txu"; + }; + ssi7: ssi-7 { + interrupts = <GIC_SPI 377 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x0f>, <&audma1 0x10>, <&audma0 0x79>, <&audma1 0x7a>; + dma-names = "rx", "tx", "rxu", "txu"; + }; + ssi8: ssi-8 { + interrupts = <GIC_SPI 378 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x11>, <&audma1 0x12>, <&audma0 0x7b>, <&audma1 0x7c>; + dma-names = "rx", "tx", "rxu", "txu"; + }; + ssi9: ssi-9 { + interrupts = <GIC_SPI 379 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&audma0 0x13>, <&audma1 0x14>, <&audma0 0x7d>, <&audma1 0x7e>; + dma-names = "rx", "tx", "rxu", "txu"; + }; + }; + }; }; /* External root clock */ -- 1.9.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 5/5] ARM: dts: iwg20d-q7-common: Enable SGTL5000 audio codec 2017-12-12 18:25 [PATCH 0/5] Add Sound support for iWave RZ/G1M board Biju Das ` (3 preceding siblings ...) 2017-12-12 18:25 ` [PATCH 4/5] ARM: dts: r8a7743: Add sound support Biju Das @ 2017-12-12 18:25 ` Biju Das 2017-12-20 9:58 ` Simon Horman 2017-12-13 9:02 ` [PATCH 0/5] Add Sound support for iWave RZ/G1M board Simon Horman 5 siblings, 1 reply; 12+ messages in thread From: Biju Das @ 2017-12-12 18:25 UTC (permalink / raw) To: Rob Herring, Mark Rutland, Russell King Cc: Simon Horman, Magnus Damm, Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel, Biju Das This patch enables SGTL5000 audio codec on the carrier board. Signed-off-by: Biju Das <biju.das@bp.renesas.com> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> --- arch/arm/boot/dts/iwg20d-q7-common.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi b/arch/arm/boot/dts/iwg20d-q7-common.dtsi index 54470c6..2070b14 100644 --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi @@ -20,6 +20,20 @@ stdout-path = "serial0:115200n8"; }; + audio_clock: audio_clock { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <26000000>; + }; + + reg_1p5v: 1p5v { + compatible = "regulator-fixed"; + regulator-name = "1P5V"; + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <1500000>; + regulator-always-on; + }; + vcc_sdhi1: regulator-vcc-sdhi1 { compatible = "regulator-fixed"; @@ -83,6 +97,16 @@ compatible = "ti,bq32000"; reg = <0x68>; }; + + sgtl5000: codec@0a { + compatible = "fsl,sgtl5000"; + #sound-dai-cells = <0>; + reg = <0x0a>; + clocks = <&audio_clock>; + VDDA-supply = <®_3p3v>; + VDDIO-supply = <®_3p3v>; + VDDD-supply = <®_1p5v>; + }; }; &pci0 { -- 1.9.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 5/5] ARM: dts: iwg20d-q7-common: Enable SGTL5000 audio codec 2017-12-12 18:25 ` [PATCH 5/5] ARM: dts: iwg20d-q7-common: Enable SGTL5000 audio codec Biju Das @ 2017-12-20 9:58 ` Simon Horman [not found] ` <20171220095806.jqtkmximxybsq6tr-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 0 siblings, 1 reply; 12+ messages in thread From: Simon Horman @ 2017-12-20 9:58 UTC (permalink / raw) To: Biju Das Cc: Rob Herring, Mark Rutland, Russell King, Magnus Damm, Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel On Tue, Dec 12, 2017 at 06:25:11PM +0000, Biju Das wrote: > This patch enables SGTL5000 audio codec on the carrier board. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Somehow I missed applying this one. I have now done so with the minor update noted below. > --- > arch/arm/boot/dts/iwg20d-q7-common.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > index 54470c6..2070b14 100644 > --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi > +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > @@ -20,6 +20,20 @@ > stdout-path = "serial0:115200n8"; > }; > > + audio_clock: audio_clock { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <26000000>; > + }; > + > + reg_1p5v: 1p5v { > + compatible = "regulator-fixed"; > + regulator-name = "1P5V"; > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <1500000>; > + regulator-always-on; > + }; > + > vcc_sdhi1: regulator-vcc-sdhi1 { > compatible = "regulator-fixed"; > > @@ -83,6 +97,16 @@ > compatible = "ti,bq32000"; > reg = <0x68>; > }; > + > + sgtl5000: codec@0a { s/@0a/@a/ Base addresses should not have a leading 0. # make dtbs W=1 DTC arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dtb arch/arm/boot/dts/r8a7743-iwg20d-q7.dtb: Warning (unit_address_format): Node /soc/i2c@e6530000/codec@0a unit name should not have leading 0s > + compatible = "fsl,sgtl5000"; > + #sound-dai-cells = <0>; > + reg = <0x0a>; > + clocks = <&audio_clock>; > + VDDA-supply = <®_3p3v>; > + VDDIO-supply = <®_3p3v>; > + VDDD-supply = <®_1p5v>; > + }; > }; > > &pci0 { > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <20171220095806.jqtkmximxybsq6tr-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* RE: [PATCH 5/5] ARM: dts: iwg20d-q7-common: Enable SGTL5000 audio codec [not found] ` <20171220095806.jqtkmximxybsq6tr-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> @ 2017-12-20 10:02 ` Biju Das [not found] ` <KL1PR06MB1702453058AFB66AA8110825B80C0-k6wCOA2IOKSx7cDWSRonpW0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 0 siblings, 1 reply; 12+ messages in thread From: Biju Das @ 2017-12-20 10:02 UTC (permalink / raw) To: Simon Horman Cc: Rob Herring, Mark Rutland, Russell King, Magnus Damm, Chris Paterson, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Thanks Simon for this information. Next time I will make sure that compiler won't give any warning message with make dtbs W=1 Regards, Biju > -----Original Message----- > From: Simon Horman [mailto:horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org] > Sent: 20 December 2017 09:58 > To: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> > Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>; Mark Rutland > <mark.rutland-5wv7dgnIgG8@public.gmane.org>; Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>; Magnus > Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>; Chris Paterson > <Chris.Paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-renesas- > soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Subject: Re: [PATCH 5/5] ARM: dts: iwg20d-q7-common: Enable SGTL5000 > audio codec > > On Tue, Dec 12, 2017 at 06:25:11PM +0000, Biju Das wrote: > > This patch enables SGTL5000 audio codec on the carrier board. > > > > Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> > > Reviewed-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> > > Somehow I missed applying this one. > I have now done so with the minor update noted below. > > > --- > > arch/arm/boot/dts/iwg20d-q7-common.dtsi | 24 > ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi > b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > index 54470c6..2070b14 100644 > > --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > @@ -20,6 +20,20 @@ > > stdout-path = "serial0:115200n8"; > > }; > > > > +audio_clock: audio_clock { > > +compatible = "fixed-clock"; > > +#clock-cells = <0>; > > +clock-frequency = <26000000>; > > +}; > > + > > +reg_1p5v: 1p5v { > > +compatible = "regulator-fixed"; > > +regulator-name = "1P5V"; > > +regulator-min-microvolt = <1500000>; > > +regulator-max-microvolt = <1500000>; > > +regulator-always-on; > > +}; > > + > > vcc_sdhi1: regulator-vcc-sdhi1 { > > compatible = "regulator-fixed"; > > > > @@ -83,6 +97,16 @@ > > compatible = "ti,bq32000"; > > reg = <0x68>; > > }; > > + > > +sgtl5000: codec@0a { > > s/@0a/@a/ > > Base addresses should not have a leading 0. > > # make dtbs W=1 > DTC arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dtb > arch/arm/boot/dts/r8a7743-iwg20d-q7.dtb: Warning (unit_address_format): > Node /soc/i2c@e6530000/codec@0a unit name should not have leading 0s > > > +compatible = "fsl,sgtl5000"; > > +#sound-dai-cells = <0>; > > +reg = <0x0a>; > > +clocks = <&audio_clock>; > > +VDDA-supply = <®_3p3v>; > > +VDDIO-supply = <®_3p3v>; > > +VDDD-supply = <®_1p5v>; > > +}; > > }; > > > > &pci0 { > > -- > > 1.9.1 > > [https://www2.renesas.eu/media/email/unicef_2017.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <KL1PR06MB1702453058AFB66AA8110825B80C0-k6wCOA2IOKSx7cDWSRonpW0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: [PATCH 5/5] ARM: dts: iwg20d-q7-common: Enable SGTL5000 audio codec [not found] ` <KL1PR06MB1702453058AFB66AA8110825B80C0-k6wCOA2IOKSx7cDWSRonpW0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2017-12-20 10:11 ` Simon Horman 0 siblings, 0 replies; 12+ messages in thread From: Simon Horman @ 2017-12-20 10:11 UTC (permalink / raw) To: Biju Das Cc: Rob Herring, Mark Rutland, Russell King, Magnus Damm, Chris Paterson, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Wed, Dec 20, 2017 at 10:02:54AM +0000, Biju Das wrote: > Thanks Simon for this information. > > Next time I will make sure that compiler won't give any warning message with make dtbs W=1 Thanks, I've been on a bit of a mission to clean up such warnings of late. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/5] Add Sound support for iWave RZ/G1M board 2017-12-12 18:25 [PATCH 0/5] Add Sound support for iWave RZ/G1M board Biju Das ` (4 preceding siblings ...) 2017-12-12 18:25 ` [PATCH 5/5] ARM: dts: iwg20d-q7-common: Enable SGTL5000 audio codec Biju Das @ 2017-12-13 9:02 ` Simon Horman [not found] ` <20171213090240.xqgihh4bqsfzeaip-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 5 siblings, 1 reply; 12+ messages in thread From: Simon Horman @ 2017-12-13 9:02 UTC (permalink / raw) To: Biju Das Cc: Rob Herring, Mark Rutland, Russell King, Magnus Damm, Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel On Tue, Dec 12, 2017 at 06:25:06PM +0000, Biju Das wrote: > This series aims to add sound support for iWave RZ/G1M board. > > This patch series has documentation dependency on > https://patchwork.kernel.org/patch/10108014/ > > Biju Das (5): > ARM: shmobile: defconfig: Enable SGTL5000 audio codec > ARM: dts: r8a7743: Add audio clocks > ARM: dts: r8a7743: Add audio DMAC support > ARM: dts: r8a7743: Add sound support > ARM: dts: iwg20d-q7-common: Enable SGTL5000 audio codec > > arch/arm/boot/dts/iwg20d-q7-common.dtsi | 24 +++ > arch/arm/boot/dts/r8a7743.dtsi | 270 ++++++++++++++++++++++++++++++++ > arch/arm/configs/shmobile_defconfig | 1 + > 3 files changed, 295 insertions(+) These patches seem clean to me although I do not have sufficient documentation to properly review the last patch. I will leave these sit for a few days to allow others to review them. ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <20171213090240.xqgihh4bqsfzeaip-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* RE: [PATCH 0/5] Add Sound support for iWave RZ/G1M board [not found] ` <20171213090240.xqgihh4bqsfzeaip-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> @ 2017-12-13 9:27 ` Biju Das 2017-12-18 11:12 ` Simon Horman 0 siblings, 1 reply; 12+ messages in thread From: Biju Das @ 2017-12-13 9:27 UTC (permalink / raw) To: Simon Horman Cc: Rob Herring, Mark Rutland, Russell King, Magnus Damm, Chris Paterson, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Hi Simon, Thanks. There is a typo in the documentation dependency link. The correct one is https://patchwork.kernel.org/patch/10108015/ Regards, Biju > -----Original Message----- > From: Simon Horman [mailto:horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org] > Sent: 13 December 2017 09:03 > To: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> > Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>; Mark Rutland > <mark.rutland-5wv7dgnIgG8@public.gmane.org>; Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>; Magnus > Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>; Chris Paterson > <Chris.Paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-renesas- > soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Subject: Re: [PATCH 0/5] Add Sound support for iWave RZ/G1M board > > On Tue, Dec 12, 2017 at 06:25:06PM +0000, Biju Das wrote: > > This series aims to add sound support for iWave RZ/G1M board. > > > > This patch series has documentation dependency on > > https://patchwork.kernel.org/patch/10108014/ > > > > Biju Das (5): > > ARM: shmobile: defconfig: Enable SGTL5000 audio codec > > ARM: dts: r8a7743: Add audio clocks > > ARM: dts: r8a7743: Add audio DMAC support > > ARM: dts: r8a7743: Add sound support > > ARM: dts: iwg20d-q7-common: Enable SGTL5000 audio codec > > > > arch/arm/boot/dts/iwg20d-q7-common.dtsi | 24 +++ > > arch/arm/boot/dts/r8a7743.dtsi | 270 > ++++++++++++++++++++++++++++++++ > > arch/arm/configs/shmobile_defconfig | 1 + > > 3 files changed, 295 insertions(+) > > These patches seem clean to me although I do not have sufficient > documentation to properly review the last patch. > > I will leave these sit for a few days to allow others to review them. [https://www2.renesas.eu/media/email/unicef_2017.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/5] Add Sound support for iWave RZ/G1M board 2017-12-13 9:27 ` Biju Das @ 2017-12-18 11:12 ` Simon Horman 0 siblings, 0 replies; 12+ messages in thread From: Simon Horman @ 2017-12-18 11:12 UTC (permalink / raw) To: Biju Das Cc: Rob Herring, Mark Rutland, Russell King, Magnus Damm, Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel On Wed, Dec 13, 2017 at 09:27:30AM +0000, Biju Das wrote: > Hi Simon, > > Thanks. > > There is a typo in the documentation dependency link. > The correct one is https://patchwork.kernel.org/patch/10108015/ Thanks, series applied. ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-12-20 10:11 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-12-12 18:25 [PATCH 0/5] Add Sound support for iWave RZ/G1M board Biju Das 2017-12-12 18:25 ` [PATCH 1/5] ARM: shmobile: defconfig: Enable SGTL5000 audio codec Biju Das 2017-12-12 18:25 ` [PATCH 2/5] ARM: dts: r8a7743: Add audio clocks Biju Das [not found] ` <1513103111-45830-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> 2017-12-12 18:25 ` [PATCH 3/5] ARM: dts: r8a7743: Add audio DMAC support Biju Das 2017-12-12 18:25 ` [PATCH 4/5] ARM: dts: r8a7743: Add sound support Biju Das 2017-12-12 18:25 ` [PATCH 5/5] ARM: dts: iwg20d-q7-common: Enable SGTL5000 audio codec Biju Das 2017-12-20 9:58 ` Simon Horman [not found] ` <20171220095806.jqtkmximxybsq6tr-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2017-12-20 10:02 ` Biju Das [not found] ` <KL1PR06MB1702453058AFB66AA8110825B80C0-k6wCOA2IOKSx7cDWSRonpW0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2017-12-20 10:11 ` Simon Horman 2017-12-13 9:02 ` [PATCH 0/5] Add Sound support for iWave RZ/G1M board Simon Horman [not found] ` <20171213090240.xqgihh4bqsfzeaip-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2017-12-13 9:27 ` Biju Das 2017-12-18 11:12 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).