devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2]  Add thermal support for iWave RZ/G1M board
@ 2017-12-13 10:57 Biju Das
  2017-12-13 10:57 ` [PATCH 1/2] dt-bindings: thermal: rcar: Add device tree support for r8a7743 Biju Das
  2017-12-13 10:57 ` [PATCH 2/2] ARM: dts: r8a7743: Add thermal device to DT Biju Das
  0 siblings, 2 replies; 7+ messages in thread
From: Biju Das @ 2017-12-13 10:57 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Zhang Rui, Eduardo Valentin
  Cc: Simon Horman, Magnus Damm, Chris Paterson, devicetree,
	linux-renesas-soc, linux-pm, Biju Das

This series aims to add thermal support for iWave RZ/G1M board.

This patch series based on renesas tag renesas-devel-20171211-v4.15-rc3.

Biju Das (2):
  dt-bindings: thermal: rcar: Add device tree support for r8a7743
  ARM: dts: r8a7743: Add thermal device to DT

 .../devicetree/bindings/thermal/rcar-thermal.txt   |  1 +
 arch/arm/boot/dts/r8a7743.dtsi                     | 32 ++++++++++++++++++++++
 2 files changed, 33 insertions(+)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] dt-bindings: thermal: rcar: Add device tree support for r8a7743
  2017-12-13 10:57 [PATCH 0/2] Add thermal support for iWave RZ/G1M board Biju Das
@ 2017-12-13 10:57 ` Biju Das
       [not found]   ` <1513162673-31531-2-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
  2017-12-15 23:06   ` Rob Herring
  2017-12-13 10:57 ` [PATCH 2/2] ARM: dts: r8a7743: Add thermal device to DT Biju Das
  1 sibling, 2 replies; 7+ messages in thread
From: Biju Das @ 2017-12-13 10:57 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Zhang Rui, Eduardo Valentin
  Cc: Simon Horman, Magnus Damm, Chris Paterson, devicetree,
	linux-renesas-soc, linux-pm, Biju Das

Add thermal sensor support for r8a7743 SoC. The Renesas RZ/G1M
(r8a7743) thermal sensor module is identical to the R-Car Gen2 family.

No driver change is needed due to the fallback compatible value
"renesas,rcar-gen2-thermal".

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 Documentation/devicetree/bindings/thermal/rcar-thermal.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
index a8e52c8..349e635 100644
--- a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
@@ -6,6 +6,7 @@ Required properties:
 			   "renesas,rcar-thermal" (without thermal-zone) as fallback.
 			  Examples with soctypes are:
 			    - "renesas,thermal-r8a73a4" (R-Mobile APE6)
+			    - "renesas,thermal-r8a7743" (RZ/G1M)
 			    - "renesas,thermal-r8a7779" (R-Car H1)
 			    - "renesas,thermal-r8a7790" (R-Car H2)
 			    - "renesas,thermal-r8a7791" (R-Car M2-W)
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/2] ARM: dts: r8a7743: Add thermal device to DT
  2017-12-13 10:57 [PATCH 0/2] Add thermal support for iWave RZ/G1M board Biju Das
  2017-12-13 10:57 ` [PATCH 1/2] dt-bindings: thermal: rcar: Add device tree support for r8a7743 Biju Das
@ 2017-12-13 10:57 ` Biju Das
  2017-12-19 11:44   ` Geert Uytterhoeven
  1 sibling, 1 reply; 7+ messages in thread
From: Biju Das @ 2017-12-13 10:57 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Zhang Rui, Eduardo Valentin
  Cc: Simon Horman, Magnus Damm, Chris Paterson, devicetree,
	linux-renesas-soc, linux-pm, Biju Das

This patch instantiates the thermal sensor module with thermal-zone
support.

This patch is based on the commit cac68a56e34b
("ARM: dts: r8a7791: enable to use thermal-zone") by Kuninori Morimoto.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 arch/arm/boot/dts/r8a7743.dtsi | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index 0e2834a..e056bc5 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -250,6 +250,38 @@
 			resets = <&cpg 407>;
 		};
 
+		thermal: thermal@e61f0000 {
+			compatible = "renesas,thermal-r8a7743",
+				     "renesas,rcar-gen2-thermal",
+				     "renesas,rcar-thermal";
+			reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 0x38>;
+			interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 522>;
+			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
+			resets = <&cpg 522>;
+			#thermal-sensor-cells = <0>;
+		};
+
+		thermal-zones {
+			cpu_thermal: cpu-thermal {
+				polling-delay-passive = <0>;
+				polling-delay = <0>;
+
+				thermal-sensors = <&thermal>;
+
+				trips {
+					cpu-crit {
+						temperature = <95000>;
+						hysteresis = <0>;
+						type = "critical";
+					};
+				};
+
+				cooling-maps {
+				};
+			};
+		};
+
 		timer {
 			compatible = "arm,armv7-timer";
 			interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) |
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] dt-bindings: thermal: rcar: Add device tree support for r8a7743
       [not found]   ` <1513162673-31531-2-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
@ 2017-12-13 13:34     ` Geert Uytterhoeven
  0 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2017-12-13 13:34 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Mark Rutland, Zhang Rui, Eduardo Valentin,
	Simon Horman, Magnus Damm, Chris Paterson,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Linux-Renesas, Linux PM list

On Wed, Dec 13, 2017 at 11:57 AM, Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> wrote:
> Add thermal sensor support for r8a7743 SoC. The Renesas RZ/G1M
> (r8a7743) thermal sensor module is identical to the R-Car Gen2 family.
>
> No driver change is needed due to the fallback compatible value
> "renesas,rcar-gen2-thermal".
>
> Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> Reviewed-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] dt-bindings: thermal: rcar: Add device tree support for r8a7743
  2017-12-13 10:57 ` [PATCH 1/2] dt-bindings: thermal: rcar: Add device tree support for r8a7743 Biju Das
       [not found]   ` <1513162673-31531-2-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
@ 2017-12-15 23:06   ` Rob Herring
  1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2017-12-15 23:06 UTC (permalink / raw)
  To: Biju Das
  Cc: Mark Rutland, Zhang Rui, Eduardo Valentin, Simon Horman,
	Magnus Damm, Chris Paterson, devicetree, linux-renesas-soc,
	linux-pm

On Wed, Dec 13, 2017 at 10:57:52AM +0000, Biju Das wrote:
> Add thermal sensor support for r8a7743 SoC. The Renesas RZ/G1M
> (r8a7743) thermal sensor module is identical to the R-Car Gen2 family.
> 
> No driver change is needed due to the fallback compatible value
> "renesas,rcar-gen2-thermal".
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/thermal/rcar-thermal.txt | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] ARM: dts: r8a7743: Add thermal device to DT
  2017-12-13 10:57 ` [PATCH 2/2] ARM: dts: r8a7743: Add thermal device to DT Biju Das
@ 2017-12-19 11:44   ` Geert Uytterhoeven
  2017-12-19 12:11     ` Biju Das
  0 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2017-12-19 11:44 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Mark Rutland, Zhang Rui, Eduardo Valentin,
	Simon Horman, Magnus Damm, Chris Paterson, devicetree,
	Linux-Renesas, Linux PM list

On Wed, Dec 13, 2017 at 11:57 AM, Biju Das <biju.das@bp.renesas.com> wrote:
> This patch instantiates the thermal sensor module with thermal-zone
> support.
>
> This patch is based on the commit cac68a56e34b
> ("ARM: dts: r8a7791: enable to use thermal-zone") by Kuninori Morimoto.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Minor nit below...

> --- a/arch/arm/boot/dts/r8a7743.dtsi
> +++ b/arch/arm/boot/dts/r8a7743.dtsi
> @@ -250,6 +250,38 @@
>                         resets = <&cpg 407>;
>                 };
>
> +               thermal: thermal@e61f0000 {
> +                       compatible = "renesas,thermal-r8a7743",
> +                                    "renesas,rcar-gen2-thermal",
> +                                    "renesas,rcar-thermal";
> +                       reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 0x38>;

<0 0xe61f0000 0 0x10>?

The register at offset 0x10 seems to exist on R-Mobile APE6 only, but
all R-Car Gen2 .dtsis include it in the range...

Not that it matters much, mapping granularity is PAGE_SIZE anyway...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH 2/2] ARM: dts: r8a7743: Add thermal device to DT
  2017-12-19 11:44   ` Geert Uytterhoeven
@ 2017-12-19 12:11     ` Biju Das
  0 siblings, 0 replies; 7+ messages in thread
From: Biju Das @ 2017-12-19 12:11 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rob Herring, Mark Rutland, Zhang Rui, Eduardo Valentin,
	Simon Horman, Magnus Damm, Chris Paterson, devicetree,
	Linux-Renesas, Linux PM list

Hi Geert,

Thanks, I will send v2.

Regards,
Biju

> -----Original Message-----
> From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com]
> On Behalf Of Geert Uytterhoeven
> Sent: 19 December 2017 11:45
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Zhang Rui <rui.zhang@intel.com>; Eduardo
> Valentin <edubezval@gmail.com>; Simon Horman <horms@verge.net.au>;
> Magnus Damm <magnus.damm@gmail.com>; Chris Paterson
> <Chris.Paterson2@renesas.com>; devicetree@vger.kernel.org; Linux-Renesas
> <linux-renesas-soc@vger.kernel.org>; Linux PM list <linux-
> pm@vger.kernel.org>
> Subject: Re: [PATCH 2/2] ARM: dts: r8a7743: Add thermal device to DT
>
> On Wed, Dec 13, 2017 at 11:57 AM, Biju Das <biju.das@bp.renesas.com>
> wrote:
> > This patch instantiates the thermal sensor module with thermal-zone
> > support.
> >
> > This patch is based on the commit cac68a56e34b
> > ("ARM: dts: r8a7791: enable to use thermal-zone") by Kuninori Morimoto.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Minor nit below...
>
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -250,6 +250,38 @@
> >                         resets = <&cpg 407>;
> >                 };
> >
> > +               thermal: thermal@e61f0000 {
> > +                       compatible = "renesas,thermal-r8a7743",
> > +                                    "renesas,rcar-gen2-thermal",
> > +                                    "renesas,rcar-thermal";
> > +                       reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0
> > + 0x38>;
>
> <0 0xe61f0000 0 0x10>?
>
> The register at offset 0x10 seems to exist on R-Mobile APE6 only, but all R-Car
> Gen2 .dtsis include it in the range...
>
> Not that it matters much, mapping granularity is PAGE_SIZE anyway...
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But when
> I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds


[https://www2.renesas.eu/media/email/unicef_2017.jpg]

This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2017-12-19 12:11 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-13 10:57 [PATCH 0/2] Add thermal support for iWave RZ/G1M board Biju Das
2017-12-13 10:57 ` [PATCH 1/2] dt-bindings: thermal: rcar: Add device tree support for r8a7743 Biju Das
     [not found]   ` <1513162673-31531-2-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-12-13 13:34     ` Geert Uytterhoeven
2017-12-15 23:06   ` Rob Herring
2017-12-13 10:57 ` [PATCH 2/2] ARM: dts: r8a7743: Add thermal device to DT Biju Das
2017-12-19 11:44   ` Geert Uytterhoeven
2017-12-19 12:11     ` Biju Das

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).