From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCH v2 01/16] dt-bindings: clock: mediatek: add missing required #reset-cells
Date: Fri, 9 Feb 2018 11:38:56 +0800 [thread overview]
Message-ID: <1518147536.9025.9.camel@mtkswgap22> (raw)
In-Reply-To: <391278e5-9b72-1142-0262-5d286fe17d8d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wed, 2018-02-07 at 11:45 +0100, Matthias Brugger wrote:
>
> On 02/06/2018 10:52 AM, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote:
> > From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> >
> > All ethsys, pciesys and ssusbsys internally include reset controller, so
> > explicitly add back these missing cell definitions to related bindings
> > and examples.
> >
> > Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > Cc: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > Cc: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> > Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > ---
> > Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt | 2 ++
> > Documentation/devicetree/bindings/arm/mediatek/mediatek,pciesys.txt | 2 ++
> > Documentation/devicetree/bindings/arm/mediatek/mediatek,ssusbsys.txt | 2 ++
> > 3 files changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt
> > index 7aa3fa1..8f5335b 100644
> > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt
> > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt
> > @@ -9,6 +9,7 @@ Required Properties:
> > - "mediatek,mt2701-ethsys", "syscon"
> > - "mediatek,mt7622-ethsys", "syscon"
> > - #clock-cells: Must be 1
> > +- #reset-cells: Must be 1
> >
> > The ethsys controller uses the common clk binding from
> > Documentation/devicetree/bindings/clock/clock-bindings.txt
> > @@ -20,4 +21,5 @@ ethsys: clock-controller@1b000000 {
> > compatible = "mediatek,mt2701-ethsys", "syscon";
> > reg = <0 0x1b000000 0 0x1000>;
> > #clock-cells = <1>;
> > + #reset-cells = <1>;
>
> The example is already fixed upstream, but I forgot the binding description,
> please rebase this patch.
>
> And please don't forget to add all clock maintainers.
>
okay, i will do it.
> Regards,
> Matthias
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-09 3:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 9:52 [PATCH v2 00/16] add dts nodes to MT7622 SoC sean.wang-NuS5LvNUpcJWk0Htik3J/w
2018-02-06 9:52 ` [PATCH v2 01/16] dt-bindings: clock: mediatek: add missing required #reset-cells sean.wang
[not found] ` <d58fcf36319254d6de4c7fe100cbdca1bbec27a5.1517910489.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-02-07 10:45 ` Matthias Brugger
[not found] ` <391278e5-9b72-1142-0262-5d286fe17d8d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-02-09 3:38 ` Sean Wang [this message]
2018-02-06 9:52 ` [PATCH v2 08/16] arm64: dts: mt7622: add SoC and peripheral related device nodes sean.wang
2018-02-06 9:52 ` [PATCH v2 09/16] arm64: dts: mt7622: add flash " sean.wang
2018-02-06 9:52 ` [PATCH v2 10/16] arm64: dts: mt7622: add ethernet " sean.wang
[not found] ` <cover.1517910489.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-02-06 9:52 ` [PATCH v2 02/16] arm64: dts: mt7622: add clock controller " sean.wang-NuS5LvNUpcJWk0Htik3J/w
2018-02-06 9:52 ` [PATCH v2 03/16] arm64: dts: mt7622: add power domain " sean.wang-NuS5LvNUpcJWk0Htik3J/w
2018-02-06 9:52 ` [PATCH v2 04/16] arm64: dts: mt7622: add pinctrl related " sean.wang-NuS5LvNUpcJWk0Htik3J/w
2018-02-07 11:31 ` Matthias Brugger
[not found] ` <7f7d3d94-7d4e-9b66-048a-e100a45a2137-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-02-09 3:41 ` Sean Wang
2018-02-06 9:52 ` [PATCH v2 05/16] arm64: dts: mt7622: add PMIC MT6380 related nodes sean.wang-NuS5LvNUpcJWk0Htik3J/w
[not found] ` <38270e84210144d52178def5ec7364b966a616eb.1517910489.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-02-08 14:46 ` Philippe Ombredanne
2018-02-06 9:52 ` [PATCH v2 06/16] arm64: dts: mt7622: add cpufreq related device nodes sean.wang-NuS5LvNUpcJWk0Htik3J/w
[not found] ` <fc5bdf53b92bd7a96e94b714d8d13deebca95c28.1517910489.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-02-07 3:33 ` Viresh Kumar
2018-02-07 6:16 ` Sean Wang
2018-02-07 6:18 ` Viresh Kumar
2018-02-07 8:34 ` Sean Wang
2018-02-06 9:52 ` [PATCH v2 07/16] arm64: dts: mt7622: turn uart0 clock to real ones sean.wang-NuS5LvNUpcJWk0Htik3J/w
2018-02-06 9:53 ` [PATCH v2 11/16] arm64: dts: mt7622: add PCIe device nodes sean.wang-NuS5LvNUpcJWk0Htik3J/w
2018-02-06 9:53 ` [PATCH v2 12/16] arm64: dts: mt7622: add SATA " sean.wang-NuS5LvNUpcJWk0Htik3J/w
2018-02-06 9:53 ` [PATCH v2 13/16] arm64: dts: mt7622: add usb " sean.wang-NuS5LvNUpcJWk0Htik3J/w
2018-02-06 9:53 ` [PATCH v2 15/16] arm64: dts: mt7622: add High-Speed DMA " sean.wang-NuS5LvNUpcJWk0Htik3J/w
2018-02-06 9:53 ` [PATCH v2 14/16] arm64: dts: mt7622: add thermal and related nodes sean.wang
[not found] ` <687a7c43e3e3260ebdf004a96d2cde143f563250.1517910489.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-02-07 11:43 ` Matthias Brugger
2018-02-09 3:51 ` Sean Wang
2018-02-12 11:55 ` Matthias Brugger
2018-02-06 9:53 ` [PATCH v2 16/16] arm64: dts: mt7622: add mmc related device nodes sean.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518147536.9025.9.camel@mtkswgap22 \
--to=sean.wang-nus5lvnupcjwk0htik3j/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).