From: Sam Shih <sam.shih@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RESEND, PATCH 1/1] arm: dts: mediatek: add mt7629 pwm support
Date: Tue, 19 Nov 2019 15:57:20 +0800 [thread overview]
Message-ID: <1574150240.19262.7.camel@mtksdccf07> (raw)
In-Reply-To: <31fddc2b-65c7-02e8-dca2-b5d6dc050f87@gmail.com>
On Sun, 2019-11-10 at 21:51 +0100, Matthias Brugger wrote:
>
> On 22/10/2019 15:30, Sam Shih wrote:
> > This adds pwm support for MT7629.
> > Used:
> > https://patchwork.kernel.org/patch/11160851/
> >
> > Signed-off-by: Sam Shih <sam.shih@mediatek.com>
> > ---
> > arch/arm/boot/dts/mt7629.dtsi | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi
> > index 9608bc2ccb3f..24375fc5f936 100644
> > --- a/arch/arm/boot/dts/mt7629.dtsi
> > +++ b/arch/arm/boot/dts/mt7629.dtsi
> > @@ -241,6 +241,21 @@
> > status = "disabled";
> > };
> >
> > + pwm: pwm@11006000 {
> > + compatible = "mediatek,mt7629-pwm";
> > + reg = <0x11006000 0x1000>;
> > + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&topckgen CLK_TOP_PWM_SEL>,
> > + <&pericfg CLK_PERI_PWM_PD>,
> > + <&pericfg CLK_PERI_PWM1_PD>;
> > + clock-names = "top", "main", "pwm1";
> > + assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>;
> > + assigned-clock-parents =
> > + <&topckgen CLK_TOP_UNIVPLL2_D4>;
> > + num-pwms = <1>;
>
> num-pwms is not defined. Did you mean pwm-cells?
>
> Regards,
> Matthias
>
> > + status = "disabled";
> > + };
> > +
> > i2c: i2c@11007000 {
> > compatible = "mediatek,mt7629-i2c",
> > "mediatek,mt2712-i2c";
> >
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
Sorry for the Late Reply,
The num-pwms field is redundant after we derive it from the compatible
string. I forgot to remove it from the device tree.
I will send a new version.
Thanks,
Best Regards,
Sam Shih
prev parent reply other threads:[~2019-11-19 7:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 13:30 [RESEMD, PATCH 0/1] Add mt7629 pwm support Sam Shih
2019-10-22 13:30 ` [RESEND, PATCH 1/1] arm: dts: mediatek: add " Sam Shih
2019-11-10 20:51 ` Matthias Brugger
2019-11-19 7:57 ` Sam Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574150240.19262.7.camel@mtksdccf07 \
--to=sam.shih@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).