* [RESEMD, PATCH 0/1] Add mt7629 pwm support
@ 2019-10-22 13:30 Sam Shih
2019-10-22 13:30 ` [RESEND, PATCH 1/1] arm: dts: mediatek: add " Sam Shih
0 siblings, 1 reply; 4+ messages in thread
From: Sam Shih @ 2019-10-22 13:30 UTC (permalink / raw)
To: Matthias Brugger, Rob Herring, Mark Rutland
Cc: devicetree, linux-kernel, linux-mediatek, linux-arm-kernel, Sam Shih
A gentle ping on this whole patch series
This adds pwm support for MT7629.
Separate this dtsi update from pwm patches series,
Used:
https://patchwork.kernel.org/patch/11160851/
Related dependent driver updates have been merged into maintainer's kernel
source tree.
Sam Shih (1):
arm: dts: mediatek: add mt7629 pwm support
arch/arm/boot/dts/mt7629.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RESEND, PATCH 1/1] arm: dts: mediatek: add mt7629 pwm support
2019-10-22 13:30 [RESEMD, PATCH 0/1] Add mt7629 pwm support Sam Shih
@ 2019-10-22 13:30 ` Sam Shih
2019-11-10 20:51 ` Matthias Brugger
0 siblings, 1 reply; 4+ messages in thread
From: Sam Shih @ 2019-10-22 13:30 UTC (permalink / raw)
To: Matthias Brugger, Rob Herring, Mark Rutland
Cc: devicetree, linux-kernel, linux-mediatek, linux-arm-kernel, Sam Shih
This adds pwm support for MT7629.
Used:
https://patchwork.kernel.org/patch/11160851/
Signed-off-by: Sam Shih <sam.shih@mediatek.com>
---
arch/arm/boot/dts/mt7629.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi
index 9608bc2ccb3f..24375fc5f936 100644
--- a/arch/arm/boot/dts/mt7629.dtsi
+++ b/arch/arm/boot/dts/mt7629.dtsi
@@ -241,6 +241,21 @@
status = "disabled";
};
+ pwm: pwm@11006000 {
+ compatible = "mediatek,mt7629-pwm";
+ reg = <0x11006000 0x1000>;
+ interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;
+ clocks = <&topckgen CLK_TOP_PWM_SEL>,
+ <&pericfg CLK_PERI_PWM_PD>,
+ <&pericfg CLK_PERI_PWM1_PD>;
+ clock-names = "top", "main", "pwm1";
+ assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>;
+ assigned-clock-parents =
+ <&topckgen CLK_TOP_UNIVPLL2_D4>;
+ num-pwms = <1>;
+ status = "disabled";
+ };
+
i2c: i2c@11007000 {
compatible = "mediatek,mt7629-i2c",
"mediatek,mt2712-i2c";
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [RESEND, PATCH 1/1] arm: dts: mediatek: add mt7629 pwm support
2019-10-22 13:30 ` [RESEND, PATCH 1/1] arm: dts: mediatek: add " Sam Shih
@ 2019-11-10 20:51 ` Matthias Brugger
2019-11-19 7:57 ` Sam Shih
0 siblings, 1 reply; 4+ messages in thread
From: Matthias Brugger @ 2019-11-10 20:51 UTC (permalink / raw)
To: Sam Shih, Rob Herring, Mark Rutland
Cc: devicetree, linux-kernel, linux-mediatek, linux-arm-kernel
On 22/10/2019 15:30, Sam Shih wrote:
> This adds pwm support for MT7629.
> Used:
> https://patchwork.kernel.org/patch/11160851/
>
> Signed-off-by: Sam Shih <sam.shih@mediatek.com>
> ---
> arch/arm/boot/dts/mt7629.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi
> index 9608bc2ccb3f..24375fc5f936 100644
> --- a/arch/arm/boot/dts/mt7629.dtsi
> +++ b/arch/arm/boot/dts/mt7629.dtsi
> @@ -241,6 +241,21 @@
> status = "disabled";
> };
>
> + pwm: pwm@11006000 {
> + compatible = "mediatek,mt7629-pwm";
> + reg = <0x11006000 0x1000>;
> + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;
> + clocks = <&topckgen CLK_TOP_PWM_SEL>,
> + <&pericfg CLK_PERI_PWM_PD>,
> + <&pericfg CLK_PERI_PWM1_PD>;
> + clock-names = "top", "main", "pwm1";
> + assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>;
> + assigned-clock-parents =
> + <&topckgen CLK_TOP_UNIVPLL2_D4>;
> + num-pwms = <1>;
num-pwms is not defined. Did you mean pwm-cells?
Regards,
Matthias
> + status = "disabled";
> + };
> +
> i2c: i2c@11007000 {
> compatible = "mediatek,mt7629-i2c",
> "mediatek,mt2712-i2c";
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RESEND, PATCH 1/1] arm: dts: mediatek: add mt7629 pwm support
2019-11-10 20:51 ` Matthias Brugger
@ 2019-11-19 7:57 ` Sam Shih
0 siblings, 0 replies; 4+ messages in thread
From: Sam Shih @ 2019-11-19 7:57 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, Mark Rutland, devicetree, linux-mediatek,
linux-kernel, linux-arm-kernel
On Sun, 2019-11-10 at 21:51 +0100, Matthias Brugger wrote:
>
> On 22/10/2019 15:30, Sam Shih wrote:
> > This adds pwm support for MT7629.
> > Used:
> > https://patchwork.kernel.org/patch/11160851/
> >
> > Signed-off-by: Sam Shih <sam.shih@mediatek.com>
> > ---
> > arch/arm/boot/dts/mt7629.dtsi | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi
> > index 9608bc2ccb3f..24375fc5f936 100644
> > --- a/arch/arm/boot/dts/mt7629.dtsi
> > +++ b/arch/arm/boot/dts/mt7629.dtsi
> > @@ -241,6 +241,21 @@
> > status = "disabled";
> > };
> >
> > + pwm: pwm@11006000 {
> > + compatible = "mediatek,mt7629-pwm";
> > + reg = <0x11006000 0x1000>;
> > + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&topckgen CLK_TOP_PWM_SEL>,
> > + <&pericfg CLK_PERI_PWM_PD>,
> > + <&pericfg CLK_PERI_PWM1_PD>;
> > + clock-names = "top", "main", "pwm1";
> > + assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>;
> > + assigned-clock-parents =
> > + <&topckgen CLK_TOP_UNIVPLL2_D4>;
> > + num-pwms = <1>;
>
> num-pwms is not defined. Did you mean pwm-cells?
>
> Regards,
> Matthias
>
> > + status = "disabled";
> > + };
> > +
> > i2c: i2c@11007000 {
> > compatible = "mediatek,mt7629-i2c",
> > "mediatek,mt2712-i2c";
> >
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
Sorry for the Late Reply,
The num-pwms field is redundant after we derive it from the compatible
string. I forgot to remove it from the device tree.
I will send a new version.
Thanks,
Best Regards,
Sam Shih
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-19 7:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-22 13:30 [RESEMD, PATCH 0/1] Add mt7629 pwm support Sam Shih
2019-10-22 13:30 ` [RESEND, PATCH 1/1] arm: dts: mediatek: add " Sam Shih
2019-11-10 20:51 ` Matthias Brugger
2019-11-19 7:57 ` Sam Shih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).