* [PATCH RESEND 1/1] ARM: dts: imx7s: Add power domain for imx7d HSIC
@ 2019-12-03 3:01 Peter Chen
2019-12-11 2:37 ` Shawn Guo
2020-02-11 8:57 ` André Draszik
0 siblings, 2 replies; 3+ messages in thread
From: Peter Chen @ 2019-12-03 3:01 UTC (permalink / raw)
To: shawnguo
Cc: linux-arm-kernel, devicetree, kernel, linux-imx, Peter Chen,
André Draszik
Otherwise, the system will hang if USB driver try to access
portsc register.
Cc: André Draszik <git@andred.net>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
arch/arm/boot/dts/imx7s.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index c1a4fff5ceda..a5b380f530f8 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -658,6 +658,12 @@
reg = <1>;
power-supply = <®_1p0d>;
};
+
+ pgc_hsic_phy: power-domain@2 {
+ #power-domain-cells = <0>;
+ reg = <2>;
+ power-supply = <®_1p2>;
+ };
};
};
};
@@ -1101,6 +1107,7 @@
compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
reg = <0x30b30000 0x200>;
interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
+ power-domains = <&pgc_hsic_phy>;
clocks = <&clks IMX7D_USB_CTRL_CLK>;
fsl,usbphy = <&usbphynop3>;
fsl,usbmisc = <&usbmisc3 0>;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND 1/1] ARM: dts: imx7s: Add power domain for imx7d HSIC
2019-12-03 3:01 [PATCH RESEND 1/1] ARM: dts: imx7s: Add power domain for imx7d HSIC Peter Chen
@ 2019-12-11 2:37 ` Shawn Guo
2020-02-11 8:57 ` André Draszik
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2019-12-11 2:37 UTC (permalink / raw)
To: Peter Chen
Cc: linux-arm-kernel, devicetree, kernel, linux-imx, André Draszik
On Tue, Dec 03, 2019 at 11:01:52AM +0800, Peter Chen wrote:
> Otherwise, the system will hang if USB driver try to access
> portsc register.
>
> Cc: André Draszik <git@andred.net>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND 1/1] ARM: dts: imx7s: Add power domain for imx7d HSIC
2019-12-03 3:01 [PATCH RESEND 1/1] ARM: dts: imx7s: Add power domain for imx7d HSIC Peter Chen
2019-12-11 2:37 ` Shawn Guo
@ 2020-02-11 8:57 ` André Draszik
1 sibling, 0 replies; 3+ messages in thread
From: André Draszik @ 2020-02-11 8:57 UTC (permalink / raw)
To: Peter Chen, shawnguo; +Cc: linux-arm-kernel, devicetree, kernel, linux-imx
On Tue, 2019-12-03 at 11:01 +0800, Peter Chen wrote:
> Otherwise, the system will hang if USB driver try to access
> portsc register.
>
> Cc: André Draszik <git@andred.net>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> arch/arm/boot/dts/imx7s.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index c1a4fff5ceda..a5b380f530f8 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -658,6 +658,12 @@
> reg = <1>;
> power-supply = <®_1p0d>;
> };
> +
> + pgc_hsic_phy: power-domain@2 {
> + #power-domain-cells = <0>;
> + reg = <2>;
> + power-supply = <®_1p2>;
> + };
> };
> };
> };
> @@ -1101,6 +1107,7 @@
> compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
> reg = <0x30b30000 0x200>;
> interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> + power-domains = <&pgc_hsic_phy>;
> clocks = <&clks IMX7D_USB_CTRL_CLK>;
> fsl,usbphy = <&usbphynop3>;
> fsl,usbmisc = <&usbmisc3 0>;
It's a bit late now, but for completeness, with this patch applied
the HSIC port works fine on my iMX7d board now.
Thanks Peter.
Tested-by: André Draszik <git@andred.net>
Cheers,
Andre'
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-11 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-03 3:01 [PATCH RESEND 1/1] ARM: dts: imx7s: Add power domain for imx7d HSIC Peter Chen
2019-12-11 2:37 ` Shawn Guo
2020-02-11 8:57 ` André Draszik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).