* [PATCH v6 0/5] add meson secure watchdog driver
@ 2020-01-14 3:45 Xingyu Chen
2020-01-14 3:45 ` [PATCH v6 3/5] dt-bindings: watchdog: add new binding for meson secure watchdog Xingyu Chen
0 siblings, 1 reply; 3+ messages in thread
From: Xingyu Chen @ 2020-01-14 3:45 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Kevin Hilman, Neil Armstrong
Cc: Xingyu Chen, Rob Herring, Jerome Brunet, Martin Blumenstingl,
Qianggui Song, Jianxin Pan, Jian Hu, linux-watchdog,
linux-amlogic, linux-arm-kernel, linux-kernel, devicetree
The watchdog controller on the Meson-A/C series SoCs is moved to secure world,
We have to call SMC instruction to trap the ATF for watchdog operation. These
operations are different from previous SoCs, so we introduce a new watchdog
driver to support this kind of SoCs.
Changes since v5 at [4]:
- take the wdt node as child node of secure-monitor
- update dt-binding description
- invoke of_platform_default_populate() instantiate wdt device according to Rob's suggestion at [5]
- find the secure-monitor node through the wdt parent node instead of of_find_compatible_node()
- add Guenter's Reviewed-by
Changes since v4 at [3]:
- add watchdog node in dts, and introduce a new optional property "timeout-sec"
- add dt-binding for meson secure watchdog
- instantiate wdt device through dts node instead of platform_device_register_simple()
Changes since v3 at [2]:
- add SM_A1_ prefix for WATCHDOG_OPS
- remove phandle to secure-monitor node
- remove watchdog node from dts, and register wdt device by platform_device_register_simple()
- remove dt-binding for meson secure watchdog
- use the msec as unit of timeout parameter which is passed to fw side
Changes since v2 at [1]:
- remove useless dependency in Kconfig
- return zero when getting left time value fails
Changes since v1 at [0]:
- add a new dependency in Kconfig
- simplify/add the return operation
- remove useless ping operation when setting the timeout
- fix some return values
- fix the license statement
[0]:https://lore.kernel.org/linux-amlogic/1570874721-36077-1-git-send-email-xingyu.chen@amlogic.com
[1]:https://lore.kernel.org/linux-amlogic/1571387622-35132-1-git-send-email-xingyu.chen@amlogic.com
[2]:https://lore.kernel.org/linux-amlogic/1571983984-11771-1-git-send-email-xingyu.chen@amlogic.com
[3]:https://lore.kernel.org/linux-amlogic/1574685218-31164-1-git-send-email-xingyu.chen@amlogic.com
[4]:https://lore.kernel.org/linux-amlogic/1576153187-28378-1-git-send-email-xingyu.chen@amlogic.com
[5]:https://patchwork.kernel.org/patch/11288017
Xingyu Chen (5):
firmware: meson_sm: add new SMC ID support for accessing secure
watchdog
firmware: meson_sm: populate platform device based on the child node
dt-bindings: watchdog: add new binding for meson secure watchdog
watchdog: add meson secure watchdog driver
arm64: dts: a1: add secure watchdog controller
.../bindings/watchdog/amlogic,meson-sec-wdt.yaml | 40 +++++
arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 6 +
drivers/firmware/meson/meson_sm.c | 3 +
drivers/watchdog/Kconfig | 16 ++
drivers/watchdog/Makefile | 1 +
drivers/watchdog/meson_sec_wdt.c | 185 +++++++++++++++++++++
include/linux/firmware/meson/meson_sm.h | 1 +
7 files changed, 252 insertions(+)
create mode 100644 Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml
create mode 100644 drivers/watchdog/meson_sec_wdt.c
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v6 3/5] dt-bindings: watchdog: add new binding for meson secure watchdog
2020-01-14 3:45 [PATCH v6 0/5] add meson secure watchdog driver Xingyu Chen
@ 2020-01-14 3:45 ` Xingyu Chen
2020-01-14 22:22 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Xingyu Chen @ 2020-01-14 3:45 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Kevin Hilman, Neil Armstrong
Cc: Xingyu Chen, Rob Herring, Jerome Brunet, Martin Blumenstingl,
Qianggui Song, Jianxin Pan, Jian Hu, linux-watchdog,
linux-amlogic, linux-arm-kernel, linux-kernel, devicetree
The binding targets the Meson-A/C series compatible SoCs, in which the
watchdog registers are in secure world.
Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
---
.../bindings/watchdog/amlogic,meson-sec-wdt.yaml | 40 ++++++++++++++++++++++
1 file changed, 40 insertions(+)
create mode 100644 Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml
diff --git a/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml b/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml
new file mode 100644
index 00000000..8e9d62a
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml
@@ -0,0 +1,40 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+# Copyright (c) 2019 Amlogic, Inc
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/power/amlogic,meson-sec-wdt.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Amlogic Meson Secure Watchdog Timer
+
+maintainers:
+ - Xingyu Chen <xingyu.chen@amlogic.com>
+
+description: |+
+ Secure Watchdog Timer used in Meson-A/C series Compatible SoCs,
+ and its device node must be the child node of secure-monitor.
+
+properties:
+ compatible:
+ enum:
+ - amlogic,meson-sec-wdt
+
+ timeout-sec:
+ minimum: 1
+ maximum: 65
+ description:
+ Watchdog timeout values (in seconds)
+
+required:
+ - compatible
+
+examples:
+ - |
+ secure-monitor {
+ compatible = "amlogic,meson-gxbb-sm";
+
+ watchdog {
+ compatible = "amlogic,meson-sec-wdt";
+ timeout-sec = <60>;
+ };
+ };
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v6 3/5] dt-bindings: watchdog: add new binding for meson secure watchdog
2020-01-14 3:45 ` [PATCH v6 3/5] dt-bindings: watchdog: add new binding for meson secure watchdog Xingyu Chen
@ 2020-01-14 22:22 ` Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-01-14 22:22 UTC (permalink / raw)
To: Xingyu Chen
Cc: Wim Van Sebroeck, Guenter Roeck, Kevin Hilman, Neil Armstrong,
Xingyu Chen, Jerome Brunet, Martin Blumenstingl, Qianggui Song,
Jianxin Pan, Jian Hu, linux-watchdog, linux-amlogic,
linux-arm-kernel, linux-kernel, devicetree
On Tue, 14 Jan 2020 11:45:25 +0800, Xingyu Chen wrote:
> The binding targets the Meson-A/C series compatible SoCs, in which the
> watchdog registers are in secure world.
>
> Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
> ---
> .../bindings/watchdog/amlogic,meson-sec-wdt.yaml | 40 ++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-14 22:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-14 3:45 [PATCH v6 0/5] add meson secure watchdog driver Xingyu Chen
2020-01-14 3:45 ` [PATCH v6 3/5] dt-bindings: watchdog: add new binding for meson secure watchdog Xingyu Chen
2020-01-14 22:22 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).