* Re: [PATCH v17 1/3] dt-bindings: Add bindings for Mediatek matrix keypad
[not found] ` <20200810064058.6467-2-fengping.yu@mediatek.com>
@ 2020-08-11 1:47 ` Yingjoe Chen
2020-08-12 22:13 ` Dmitry Torokhov
2020-08-12 22:37 ` Dmitry Torokhov
1 sibling, 1 reply; 4+ messages in thread
From: Yingjoe Chen @ 2020-08-11 1:47 UTC (permalink / raw)
To: Fengping Yu
Cc: Rob Herring, Andy Shevchenko, Dmitry Torokhov, Marco Felsch,
linux-input, devicetree, linux-mediatek, linux-kernel,
linux-arm-kernel
Hi,
On Mon, 2020-08-10 at 14:40 +0800, Fengping Yu wrote:
> From: "fengping.yu" <fengping.yu@mediatek.com>
>
> This patch add devicetree bindings for Mediatek matrix keypad driver.
>
> Signed-off-by: fengping.yu <fengping.yu@mediatek.com>
> ---
> .../devicetree/bindings/input/mtk-kpd.yaml | 87 +++++++++++++++++++
> 1 file changed, 87 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.yaml
>
> diff --git a/Documentation/devicetree/bindings/input/mtk-kpd.yaml b/Documentation/devicetree/bindings/input/mtk-kpd.yaml
> new file mode 100644
> index 000000000000..d74dd8a6fbde
<...>
> + keypad,num-columns:
> + description: Number of column lines connected to the keypad controller,
> + it is not equal to PCB columns number, instead you should add required value
> + for each IC. If not specified, the default value is 1.
> +
> + keypad,num-rows:
> + description: Number of row lines connected to the keypad controller, it is
> + not equal to PCB rows number, instead you should add required value for each IC.
> + If not specified, the default value is 1.
Your source code can't really handle dts without rows/columns
properties. Also, the default value doesn't make any sense. No IC will
have rows or columns set to 1.
Since these are IC specified, not board specified, I think you should
just have the correct numbers in driver.
Joe.C
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v17 1/3] dt-bindings: Add bindings for Mediatek matrix keypad
[not found] ` <20200810064058.6467-2-fengping.yu@mediatek.com>
2020-08-11 1:47 ` [PATCH v17 1/3] dt-bindings: Add bindings for Mediatek matrix keypad Yingjoe Chen
@ 2020-08-12 22:37 ` Dmitry Torokhov
1 sibling, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2020-08-12 22:37 UTC (permalink / raw)
To: Fengping Yu
Cc: Yingjoe Chen, Rob Herring, Andy Shevchenko, Marco Felsch,
linux-input, devicetree, linux-mediatek, linux-kernel,
linux-arm-kernel
Hi,
On Mon, Aug 10, 2020 at 02:40:57PM +0800, Fengping Yu wrote:
> From: "fengping.yu" <fengping.yu@mediatek.com>
>
> This patch add devicetree bindings for Mediatek matrix keypad driver.
>
> Signed-off-by: fengping.yu <fengping.yu@mediatek.com>
> ---
> .../devicetree/bindings/input/mtk-kpd.yaml | 87 +++++++++++++++++++
> 1 file changed, 87 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.yaml
>
> diff --git a/Documentation/devicetree/bindings/input/mtk-kpd.yaml b/Documentation/devicetree/bindings/input/mtk-kpd.yaml
> new file mode 100644
> index 000000000000..d74dd8a6fbde
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/mtk-kpd.yaml
> @@ -0,0 +1,87 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +version: 1
> +
> +$id: http://devicetree.org/schemas/input/mtk-keypad.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek's Keypad Controller device tree bindings
> +
> +maintainer:
> + - Fengping Yu <fengping.yu@mediatek.com>
> +
> +description: |
> + Mediatek's Keypad controller is used to interface a SoC with a matrix-type
> + keypad device. The keypad controller supports multiple row and column lines.
> + A key can be placed at each intersection of a unique row and a unique column.
> + The keypad controller can sense a key-press and key-release and report the
> + event using a interrupt to the cpu.
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: "mediatek,mt6779-keypad"
> + - const: "mediatek,mt6873-keypad"
> +
> + clock-names:
> + description: Names of the clocks listed in clocks property in the same order
> + maxItems: 1
> + items:
> + - const: kpd
> +
> + clocks:
> + description: Must contain one entry, for the module clock
> + refs: devicetree/bindings/clocks/clock-bindings.txt for details.
> +
> + interrupts:
> + description: A single interrupt specifier
> + maxItems: 1
> +
> + linux,keymap:
> + description: The keymap for keys as described in the binding document
> + refs: devicetree/bindings/input/matrix-keymap.txt
> + minItems: 1
> +
> + reg:
> + description: The base address of the Keypad register bank
> + maxItems: 1
> +
> + wakeup-source:
> + description: use any event on keypad as wakeup event
> + type: boolean
> +
> + keypad,num-columns:
> + description: Number of column lines connected to the keypad controller,
> + it is not equal to PCB columns number, instead you should add required value
> + for each IC. If not specified, the default value is 1.
What sets the default? matrix_keymap_parse_properties() will error out
if either property is not present....
> +
> + keypad,num-rows:
> + description: Number of row lines connected to the keypad controller, it is
> + not equal to PCB rows number, instead you should add required value for each IC.
> + If not specified, the default value is 1.
> +
> + mediatek,debounce-us:
> + description: Debounce interval in microseconds, if not specified, the default
> + value is 16000
> + maximum: 256000
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - linux,keymap
> + - clocks
> + - clock-names
> +
> +examples:
> + - |
> +
> + kp@10010000 {
> + compatible = "mediatek,mt6779-keypad";
Should we call the driver mt6779-keypad ?
> + reg = <0 0x10010000 0 0x1000>;
> + linux,keymap = < MATRIX_KEY(0x00, 0x00, KEY_VOLUMEDOWN) >;
> + interrupts = <GIC_SPI 75 IRQ_TYPE_EDGE_FALLING>;
> + clocks = <&clk26m>;
> + clock-names = "kpd";
> + };
> --
> 2.18.0
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread