devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: tas2562: Remove duplicate code for I/V sense
@ 2020-09-22 14:24 Dan Murphy
  2020-09-22 15:05 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Murphy @ 2020-09-22 14:24 UTC (permalink / raw)
  To: lgirdwood, broonie, tiwai, robh+dt
  Cc: devicetree, alsa-devel, linux-kernel, Dan Murphy

Remove duplicate code for programming the I/V sense the call to update
the register was duplicated in commit 09ed395b05feb ("ASoC: tas2562:
Add voltage sense slot configuration").

Fixes: 09ed395b05feb ("ASoC: tas2562: Add voltage sense slot configuration")
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
 sound/soc/codecs/tas2562.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c
index da820e8d59a1..f1ff204e3ad0 100644
--- a/sound/soc/codecs/tas2562.c
+++ b/sound/soc/codecs/tas2562.c
@@ -253,18 +253,6 @@ static int tas2562_set_dai_tdm_slot(struct snd_soc_dai *dai,
 	if (ret < 0)
 		return ret;
 
-	ret = snd_soc_component_update_bits(component, TAS2562_TDM_CFG5,
-					    TAS2562_TDM_CFG5_VSNS_SLOT_MASK,
-					    tas2562->v_sense_slot);
-	if (ret < 0)
-		return ret;
-
-	ret = snd_soc_component_update_bits(component, TAS2562_TDM_CFG6,
-					    TAS2562_TDM_CFG6_ISNS_SLOT_MASK,
-					    tas2562->i_sense_slot);
-	if (ret < 0)
-		return ret;
-
 	return 0;
 }
 
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: tas2562: Remove duplicate code for I/V sense
  2020-09-22 14:24 [PATCH] ASoC: tas2562: Remove duplicate code for I/V sense Dan Murphy
@ 2020-09-22 15:05 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2020-09-22 15:05 UTC (permalink / raw)
  To: lgirdwood, tiwai, robh+dt, Dan Murphy
  Cc: alsa-devel, linux-kernel, devicetree

On Tue, 22 Sep 2020 09:24:11 -0500, Dan Murphy wrote:
> Remove duplicate code for programming the I/V sense the call to update
> the register was duplicated in commit 09ed395b05feb ("ASoC: tas2562:
> Add voltage sense slot configuration").

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: tas2562: Remove duplicate code for I/V sense
      commit: 90e2a588c9e743f104849fb2da4c121e1a487201

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-22 15:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22 14:24 [PATCH] ASoC: tas2562: Remove duplicate code for I/V sense Dan Murphy
2020-09-22 15:05 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).