devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node
@ 2020-11-02 14:19 Pablo Greco
  2020-11-02 17:07 ` Maxime Ripard
  0 siblings, 1 reply; 4+ messages in thread
From: Pablo Greco @ 2020-11-02 14:19 UTC (permalink / raw)
  To: linux-sunxi
  Cc: Pablo Greco, Rob Herring, Maxime Ripard, Chen-Yu Tsai,
	Jernej Skrabec, devicetree, linux-arm-kernel, linux-kernel

Ethernet PHY on BananaPi M2 Berry provides RX and TX delays. Fix ethernet
node to reflect that fact.

Fixes: 27e81e1970a8 ("ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC ethernet controller")
Signed-off-by: Pablo Greco <pgreco@centosproject.org>
---
 arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
index 15c22b06fc4b..3ab6f47cea4f 100644
--- a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
+++ b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
@@ -120,7 +120,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac_rgmii_pins>;
 	phy-handle = <&phy1>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-supply = <&reg_dc1sw>;
 	status = "okay";
 };
-- 
2.18.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node
  2020-11-02 14:19 [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node Pablo Greco
@ 2020-11-02 17:07 ` Maxime Ripard
  0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2020-11-02 17:07 UTC (permalink / raw)
  To: Pablo Greco
  Cc: linux-sunxi, Rob Herring, Chen-Yu Tsai, Jernej Skrabec,
	devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

On Mon, Nov 02, 2020 at 11:19:29AM -0300, Pablo Greco wrote:
> Ethernet PHY on BananaPi M2 Berry provides RX and TX delays. Fix ethernet
> node to reflect that fact.
> 
> Fixes: 27e81e1970a8 ("ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC ethernet controller")
> Signed-off-by: Pablo Greco <pgreco@centosproject.org>

Applied, thanks!
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node
  2020-11-01  0:34 ` [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node Pablo Greco
@ 2020-11-01  7:29   ` Jernej Škrabec
  0 siblings, 0 replies; 4+ messages in thread
From: Jernej Škrabec @ 2020-11-01  7:29 UTC (permalink / raw)
  To: linux-sunxi, Pablo Greco
  Cc: Pablo Greco, Rob Herring, Maxime Ripard, Chen-Yu Tsai,
	Hans de Goede, Icenowy Zheng, devicetree, linux-arm-kernel,
	linux-kernel

Dne nedelja, 01. november 2020 ob 01:34:17 CET je Pablo Greco napisal(a):
> Ethernet PHY on BananaPi M2 Berry provides RX and TX delays. Fix ethernet
> node to reflect that fact.
> 
> Fixes: 27e81e1970a8 ("ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC 
ethernet controller")
> Signed-off-by: Pablo Greco <pgreco@centosproject.org>

Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>

Thanks!

Jernej



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node
  2020-11-01  0:34 [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY Pablo Greco
@ 2020-11-01  0:34 ` Pablo Greco
  2020-11-01  7:29   ` Jernej Škrabec
  0 siblings, 1 reply; 4+ messages in thread
From: Pablo Greco @ 2020-11-01  0:34 UTC (permalink / raw)
  To: linux-sunxi
  Cc: Pablo Greco, Rob Herring, Maxime Ripard, Chen-Yu Tsai,
	Jernej Skrabec, Hans de Goede, Icenowy Zheng, devicetree,
	linux-arm-kernel, linux-kernel

Ethernet PHY on BananaPi M2 Berry provides RX and TX delays. Fix ethernet
node to reflect that fact.

Fixes: 27e81e1970a8 ("ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC ethernet controller")
Signed-off-by: Pablo Greco <pgreco@centosproject.org>
---
 arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
index 15c22b06fc4b..3ab6f47cea4f 100644
--- a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
+++ b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
@@ -120,7 +120,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac_rgmii_pins>;
 	phy-handle = <&phy1>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-supply = <&reg_dc1sw>;
 	status = "okay";
 };
-- 
2.18.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-11-02 17:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-02 14:19 [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node Pablo Greco
2020-11-02 17:07 ` Maxime Ripard
  -- strict thread matches above, loose matches on Subject: below --
2020-11-01  0:34 [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY Pablo Greco
2020-11-01  0:34 ` [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node Pablo Greco
2020-11-01  7:29   ` Jernej Škrabec

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).