* [PATCH] dt-bindings: phy: hisilicon: Fix 'hisilicon,eye-diagram-param' differing types
@ 2023-01-25 22:14 Rob Herring
2023-01-26 8:10 ` Mauro Carvalho Chehab
2023-02-02 23:17 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2023-01-25 22:14 UTC (permalink / raw)
To: Yu Chen, Binghui Wang, Vinod Koul, Kishon Vijay Abraham I,
Krzysztof Kozlowski, Mauro Carvalho Chehab, Carvalho Chehab
Cc: linux-usb, linux-phy, devicetree, linux-kernel
'hisilicon,eye-diagram-param' is also defined in
hisilicon,phy-hi3670-pcie.yaml as a 'uint32-array'. Unify it to use
'uint32-array' everywhere.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/phy/hisilicon,hi3660-usb3.yaml | 3 ++-
.../devicetree/bindings/phy/hisilicon,hi3670-usb3.yaml | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/hisilicon,hi3660-usb3.yaml b/Documentation/devicetree/bindings/phy/hisilicon,hi3660-usb3.yaml
index 20b79e2e8b82..b11d9873854a 100644
--- a/Documentation/devicetree/bindings/phy/hisilicon,hi3660-usb3.yaml
+++ b/Documentation/devicetree/bindings/phy/hisilicon,hi3660-usb3.yaml
@@ -27,7 +27,8 @@ properties:
description: phandle of syscon used to control usb tcxo.
hisilicon,eye-diagram-param:
- $ref: /schemas/types.yaml#/definitions/uint32
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ maxItems: 1
description: Eye diagram for phy.
required:
diff --git a/Documentation/devicetree/bindings/phy/hisilicon,hi3670-usb3.yaml b/Documentation/devicetree/bindings/phy/hisilicon,hi3670-usb3.yaml
index 1cb00dbcd4c5..3c69aca6c7eb 100644
--- a/Documentation/devicetree/bindings/phy/hisilicon,hi3670-usb3.yaml
+++ b/Documentation/devicetree/bindings/phy/hisilicon,hi3670-usb3.yaml
@@ -32,7 +32,8 @@ properties:
description: phandle of syscon used to control phy deep sleep.
hisilicon,eye-diagram-param:
- $ref: /schemas/types.yaml#/definitions/uint32
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ maxItems: 1
description: Eye diagram for phy.
hisilicon,tx-vboost-lvl:
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: phy: hisilicon: Fix 'hisilicon,eye-diagram-param' differing types
2023-01-25 22:14 [PATCH] dt-bindings: phy: hisilicon: Fix 'hisilicon,eye-diagram-param' differing types Rob Herring
@ 2023-01-26 8:10 ` Mauro Carvalho Chehab
2023-02-02 23:17 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2023-01-26 8:10 UTC (permalink / raw)
To: Rob Herring
Cc: Yu Chen, Binghui Wang, Vinod Koul, Kishon Vijay Abraham I,
Krzysztof Kozlowski, Carvalho Chehab, linux-usb, linux-phy,
devicetree, linux-kernel
Em Wed, 25 Jan 2023 16:14:43 -0600
Rob Herring <robh@kernel.org> escreveu:
> 'hisilicon,eye-diagram-param' is also defined in
> hisilicon,phy-hi3670-pcie.yaml as a 'uint32-array'. Unify it to use
> 'uint32-array' everywhere.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
> .../devicetree/bindings/phy/hisilicon,hi3660-usb3.yaml | 3 ++-
> .../devicetree/bindings/phy/hisilicon,hi3670-usb3.yaml | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/hisilicon,hi3660-usb3.yaml b/Documentation/devicetree/bindings/phy/hisilicon,hi3660-usb3.yaml
> index 20b79e2e8b82..b11d9873854a 100644
> --- a/Documentation/devicetree/bindings/phy/hisilicon,hi3660-usb3.yaml
> +++ b/Documentation/devicetree/bindings/phy/hisilicon,hi3660-usb3.yaml
> @@ -27,7 +27,8 @@ properties:
> description: phandle of syscon used to control usb tcxo.
>
> hisilicon,eye-diagram-param:
> - $ref: /schemas/types.yaml#/definitions/uint32
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + maxItems: 1
> description: Eye diagram for phy.
>
> required:
> diff --git a/Documentation/devicetree/bindings/phy/hisilicon,hi3670-usb3.yaml b/Documentation/devicetree/bindings/phy/hisilicon,hi3670-usb3.yaml
> index 1cb00dbcd4c5..3c69aca6c7eb 100644
> --- a/Documentation/devicetree/bindings/phy/hisilicon,hi3670-usb3.yaml
> +++ b/Documentation/devicetree/bindings/phy/hisilicon,hi3670-usb3.yaml
> @@ -32,7 +32,8 @@ properties:
> description: phandle of syscon used to control phy deep sleep.
>
> hisilicon,eye-diagram-param:
> - $ref: /schemas/types.yaml#/definitions/uint32
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + maxItems: 1
> description: Eye diagram for phy.
>
> hisilicon,tx-vboost-lvl:
Thanks,
Mauro
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: phy: hisilicon: Fix 'hisilicon,eye-diagram-param' differing types
2023-01-25 22:14 [PATCH] dt-bindings: phy: hisilicon: Fix 'hisilicon,eye-diagram-param' differing types Rob Herring
2023-01-26 8:10 ` Mauro Carvalho Chehab
@ 2023-02-02 23:17 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2023-02-02 23:17 UTC (permalink / raw)
To: Rob Herring
Cc: Binghui Wang, Mauro Carvalho Chehab, Vinod Koul, Carvalho Chehab,
devicetree, linux-kernel, linux-usb, Yu Chen, linux-phy,
Krzysztof Kozlowski, Kishon Vijay Abraham I
On Wed, 25 Jan 2023 16:14:43 -0600, Rob Herring wrote:
> 'hisilicon,eye-diagram-param' is also defined in
> hisilicon,phy-hi3670-pcie.yaml as a 'uint32-array'. Unify it to use
> 'uint32-array' everywhere.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/phy/hisilicon,hi3660-usb3.yaml | 3 ++-
> .../devicetree/bindings/phy/hisilicon,hi3670-usb3.yaml | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-02 23:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-25 22:14 [PATCH] dt-bindings: phy: hisilicon: Fix 'hisilicon,eye-diagram-param' differing types Rob Herring
2023-01-26 8:10 ` Mauro Carvalho Chehab
2023-02-02 23:17 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).