* [PATCH 1/3] arm64: dts: rockchip: correct panel supplies
@ 2023-03-26 20:45 Krzysztof Kozlowski
2023-03-26 20:45 ` [PATCH 2/3] arm64: dts: rockchip: use just "port" in panel on Pinebook Pro Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-26 20:45 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
Cc: Krzysztof Kozlowski
The Anbernic and Odroid Go have different panels and take differently
named supplies, so move all the supplies to DTS defining actual panel to
fix warnings like:
rk3326-odroid-go3.dtb: panel@0: 'IOVCC-supply' is a required property
rk3326-odroid-go3.dtb: panel@0: 'iovcc-supply', 'vdd-supply' do not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/rockchip/rk3326-anbernic-rg351m.dts | 2 ++
arch/arm64/boot/dts/rockchip/rk3326-odroid-go.dtsi | 2 --
arch/arm64/boot/dts/rockchip/rk3326-odroid-go2-v11.dts | 2 ++
arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts | 2 ++
arch/arm64/boot/dts/rockchip/rk3326-odroid-go3.dts | 1 +
5 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3326-anbernic-rg351m.dts b/arch/arm64/boot/dts/rockchip/rk3326-anbernic-rg351m.dts
index 61b31688b469..ce318e05f0a6 100644
--- a/arch/arm64/boot/dts/rockchip/rk3326-anbernic-rg351m.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3326-anbernic-rg351m.dts
@@ -24,6 +24,8 @@ vibrator {
&internal_display {
compatible = "elida,kd35t133";
+ iovcc-supply = <&vcc_lcd>;
+ vdd-supply = <&vcc_lcd>;
};
&pwm0 {
diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go.dtsi b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go.dtsi
index 04eba432fb0e..80fc53c807a4 100644
--- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go.dtsi
@@ -235,10 +235,8 @@ mipi_out_panel: endpoint {
internal_display: panel@0 {
reg = <0>;
backlight = <&backlight>;
- iovcc-supply = <&vcc_lcd>;
reset-gpios = <&gpio3 RK_PC0 GPIO_ACTIVE_LOW>;
rotation = <270>;
- vdd-supply = <&vcc_lcd>;
port {
mipi_in_panel: endpoint {
diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2-v11.dts b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2-v11.dts
index 139c898e590e..d94ac81eb4e6 100644
--- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2-v11.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2-v11.dts
@@ -83,6 +83,8 @@ button-sw21 {
&internal_display {
compatible = "elida,kd35t133";
+ iovcc-supply = <&vcc_lcd>;
+ vdd-supply = <&vcc_lcd>;
};
&rk817 {
diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
index 4702183b673c..aa6f5b12206b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
@@ -59,6 +59,8 @@ battery: battery {
&internal_display {
compatible = "elida,kd35t133";
+ iovcc-supply = <&vcc_lcd>;
+ vdd-supply = <&vcc_lcd>;
};
&rk817_charger {
diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go3.dts b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go3.dts
index 1b9769ccfdeb..35bbaf559ca3 100644
--- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go3.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go3.dts
@@ -144,6 +144,7 @@ button-sw22 {
&internal_display {
compatible = "elida,kd50t048a", "sitronix,st7701";
reset-gpios = <&gpio3 RK_PC0 GPIO_ACTIVE_HIGH>;
+ IOVCC-supply = <&vcc_lcd>;
VCC-supply = <&vcc_lcd>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/3] arm64: dts: rockchip: use just "port" in panel on Pinebook Pro
2023-03-26 20:45 [PATCH 1/3] arm64: dts: rockchip: correct panel supplies Krzysztof Kozlowski
@ 2023-03-26 20:45 ` Krzysztof Kozlowski
2023-03-26 20:45 ` [PATCH 3/3] arm64: dts: rockchip: use just "port" in panel on RockPro64 Krzysztof Kozlowski
2023-04-05 17:45 ` [PATCH 1/3] arm64: dts: rockchip: correct panel supplies Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-26 20:45 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
Cc: Krzysztof Kozlowski
The panel bindings expect to have only one port, thus they do not allow
to use "ports" node:
rk3399-pinebook-pro.dtb: edp-panel: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../boot/dts/rockchip/rk3399-pinebook-pro.dts | 16 +++-------------
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
index 54bb0398128f..ddd45de97950 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
@@ -50,19 +50,9 @@ edp_panel: edp-panel {
pinctrl-0 = <&panel_en_pin>;
power-supply = <&vcc3v3_panel>;
- ports {
- #address-cells = <1>;
- #size-cells = <0>;
-
- port@0 {
- reg = <0>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- panel_in_edp: endpoint@0 {
- reg = <0>;
- remote-endpoint = <&edp_out_panel>;
- };
+ port {
+ panel_in_edp: endpoint {
+ remote-endpoint = <&edp_out_panel>;
};
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 3/3] arm64: dts: rockchip: use just "port" in panel on RockPro64
2023-03-26 20:45 [PATCH 1/3] arm64: dts: rockchip: correct panel supplies Krzysztof Kozlowski
2023-03-26 20:45 ` [PATCH 2/3] arm64: dts: rockchip: use just "port" in panel on Pinebook Pro Krzysztof Kozlowski
@ 2023-03-26 20:45 ` Krzysztof Kozlowski
2023-04-05 17:45 ` [PATCH 1/3] arm64: dts: rockchip: correct panel supplies Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-26 20:45 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
Cc: Krzysztof Kozlowski
The panel bindings expect to have only one port, thus they do not allow
to use "ports" node:
rk3399-rockpro64.dtb: panel@0: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'
There is only one endpoint, so use simpler form without "reg".
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
index 78157521e944..bca2b50e0a93 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
@@ -647,16 +647,10 @@ mipi_panel: panel@0 {
avdd-supply = <&avdd>;
backlight = <&backlight>;
dvdd-supply = <&vcc3v3_s0>;
- ports {
- #address-cells = <1>;
- #size-cells = <0>;
- port@0 {
- reg = <0>;
-
- mipi_in_panel: endpoint {
- remote-endpoint = <&mipi_out_panel>;
- };
+ port {
+ mipi_in_panel: endpoint {
+ remote-endpoint = <&mipi_out_panel>;
};
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/3] arm64: dts: rockchip: correct panel supplies
2023-03-26 20:45 [PATCH 1/3] arm64: dts: rockchip: correct panel supplies Krzysztof Kozlowski
2023-03-26 20:45 ` [PATCH 2/3] arm64: dts: rockchip: use just "port" in panel on Pinebook Pro Krzysztof Kozlowski
2023-03-26 20:45 ` [PATCH 3/3] arm64: dts: rockchip: use just "port" in panel on RockPro64 Krzysztof Kozlowski
@ 2023-04-05 17:45 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2023-04-05 17:45 UTC (permalink / raw)
To: devicetree, Rob Herring, Krzysztof Kozlowski,
Krzysztof Kozlowski, linux-kernel, linux-arm-kernel,
linux-rockchip
Cc: Heiko Stuebner
On Sun, 26 Mar 2023 22:45:18 +0200, Krzysztof Kozlowski wrote:
> The Anbernic and Odroid Go have different panels and take differently
> named supplies, so move all the supplies to DTS defining actual panel to
> fix warnings like:
>
> rk3326-odroid-go3.dtb: panel@0: 'IOVCC-supply' is a required property
> rk3326-odroid-go3.dtb: panel@0: 'iovcc-supply', 'vdd-supply' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> [...]
Applied, thanks!
Applied most of the series as fix for 6.3, but split the first patch into
two, as the Odroid Go3 display support only got added for 6.4
[1/3] arm64: dts: rockchip: correct panel supplies
commit: 60a655debd36e3278a46872accc1a51a54f94f02
(fixes)
commit: 07099a551803e05d3ee42fae152bf404f8dc21f9
(for 6.4)
[2/3] arm64: dts: rockchip: use just "port" in panel on Pinebook Pro
commit: 5438b349c0512a6fe023976aad8b9f19ca671dd1
[3/3] arm64: dts: rockchip: use just "port" in panel on RockPro64
commit: 2dd16a23e8c687bde605dbdcfedaed97bb2a0c0e
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-05 17:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-26 20:45 [PATCH 1/3] arm64: dts: rockchip: correct panel supplies Krzysztof Kozlowski
2023-03-26 20:45 ` [PATCH 2/3] arm64: dts: rockchip: use just "port" in panel on Pinebook Pro Krzysztof Kozlowski
2023-03-26 20:45 ` [PATCH 3/3] arm64: dts: rockchip: use just "port" in panel on RockPro64 Krzysztof Kozlowski
2023-04-05 17:45 ` [PATCH 1/3] arm64: dts: rockchip: correct panel supplies Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).