devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Add USB-C
@ 2024-04-25 15:25 Garrett Giordano
  2024-04-26 12:54 ` Wadim Egorov
  2024-04-26 22:43 ` Nishanth Menon
  0 siblings, 2 replies; 3+ messages in thread
From: Garrett Giordano @ 2024-04-25 15:25 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt, w.egorov
  Cc: linux-arm-kernel, devicetree, linux-kernel, upstream

The USB-C PD manages plug orientation, power delivery, and our endpoint
for the USB interface. Add this node and include its endpoint.

Configure USB0 for role-switching and wire it to our USB-C PD endpoint.

Signed-off-by: Garrett Giordano <ggiordano@phytec.com>
---
 .../dts/ti/k3-am625-phyboard-lyra-rdk.dts     | 26 ++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
index dfc78995d30a..fb3bc914a018 100644
--- a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
@@ -348,6 +348,24 @@ gpio_exp: gpio-expander@21 {
 				  "GPIO6_ETH1_USER_RESET", "GPIO7_AUDIO_USER_RESET";
 	};
 
+	usb-pd@22 {
+		compatible = "ti,tps6598x";
+		reg = <0x22>;
+
+		connector {
+			compatible = "usb-c-connector";
+			label = "USB-C";
+			self-powered;
+			data-role = "dual";
+			power-role = "sink";
+			port {
+				usb_con_hs: endpoint {
+					remote-endpoint = <&typec_hs>;
+				};
+			};
+		};
+	};
+
 	sii9022: bridge-hdmi@39 {
 		compatible = "sil,sii9022";
 		reg = <0x39>;
@@ -449,7 +467,13 @@ &usbss1 {
 };
 
 &usb0 {
-	dr_mode = "peripheral";
+	usb-role-switch;
+
+	port {
+		typec_hs: endpoint {
+			remote-endpoint = <&usb_con_hs>;
+		};
+	};
 };
 
 &usb1 {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Add USB-C
  2024-04-25 15:25 [PATCH] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Add USB-C Garrett Giordano
@ 2024-04-26 12:54 ` Wadim Egorov
  2024-04-26 22:43 ` Nishanth Menon
  1 sibling, 0 replies; 3+ messages in thread
From: Wadim Egorov @ 2024-04-26 12:54 UTC (permalink / raw)
  To: Garrett Giordano, nm, vigneshr, kristo, robh, krzk+dt, conor+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel, upstream

Hi Garrett,

thanks for sending!

It seems like this patch completes the board's support. Every 
interface/component is now fully supported.

Am 25.04.24 um 17:25 schrieb Garrett Giordano:
> The USB-C PD manages plug orientation, power delivery, and our endpoint
> for the USB interface. Add this node and include its endpoint.
> 
> Configure USB0 for role-switching and wire it to our USB-C PD endpoint.
> 
> Signed-off-by: Garrett Giordano <ggiordano@phytec.com>

Reviewed-by: Wadim Egorov <w.egorov@phytec.de>

> ---
>   .../dts/ti/k3-am625-phyboard-lyra-rdk.dts     | 26 ++++++++++++++++++-
>   1 file changed, 25 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> index dfc78995d30a..fb3bc914a018 100644
> --- a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> @@ -348,6 +348,24 @@ gpio_exp: gpio-expander@21 {
>   				  "GPIO6_ETH1_USER_RESET", "GPIO7_AUDIO_USER_RESET";
>   	};
>   
> +	usb-pd@22 {
> +		compatible = "ti,tps6598x";
> +		reg = <0x22>;
> +
> +		connector {
> +			compatible = "usb-c-connector";
> +			label = "USB-C";
> +			self-powered;
> +			data-role = "dual";
> +			power-role = "sink";
> +			port {
> +				usb_con_hs: endpoint {
> +					remote-endpoint = <&typec_hs>;
> +				};
> +			};
> +		};
> +	};
> +
>   	sii9022: bridge-hdmi@39 {
>   		compatible = "sil,sii9022";
>   		reg = <0x39>;
> @@ -449,7 +467,13 @@ &usbss1 {
>   };
>   
>   &usb0 {
> -	dr_mode = "peripheral";
> +	usb-role-switch;
> +
> +	port {
> +		typec_hs: endpoint {
> +			remote-endpoint = <&usb_con_hs>;
> +		};
> +	};
>   };
>   
>   &usb1 {

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Add USB-C
  2024-04-25 15:25 [PATCH] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Add USB-C Garrett Giordano
  2024-04-26 12:54 ` Wadim Egorov
@ 2024-04-26 22:43 ` Nishanth Menon
  1 sibling, 0 replies; 3+ messages in thread
From: Nishanth Menon @ 2024-04-26 22:43 UTC (permalink / raw)
  To: vigneshr, kristo, robh, krzk+dt, conor+dt, w.egorov, Garrett Giordano
  Cc: Nishanth Menon, linux-arm-kernel, devicetree, linux-kernel, upstream

Hi Garrett Giordano,

On Thu, 25 Apr 2024 08:25:58 -0700, Garrett Giordano wrote:
> The USB-C PD manages plug orientation, power delivery, and our endpoint
> for the USB interface. Add this node and include its endpoint.
> 
> Configure USB0 for role-switching and wire it to our USB-C PD endpoint.
> 
> 

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/1] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Add USB-C
      commit: 3454b58dd9d99e317871e9abd57f589ae7580642

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-26 22:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-25 15:25 [PATCH] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Add USB-C Garrett Giordano
2024-04-26 12:54 ` Wadim Egorov
2024-04-26 22:43 ` Nishanth Menon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).