* [PATCH] dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value
@ 2020-10-18 19:30 Fabien Parent
2020-10-19 10:18 ` Matthias Brugger
2020-10-23 16:49 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Fabien Parent @ 2020-10-18 19:30 UTC (permalink / raw)
To: linux-kernel, linux-mediatek, linux-arm-kernel, devicetree
Cc: dennis-yc.hsieh, ck.hu, bibby.hsieh, jaswinder.singh,
matthias.bgg, Fabien Parent
As the binding documentation says, #mbox-cells must have a value of 2,
but the example use a value 3. The MT8173 device tree correctly use
mbox-cells = <2>. This commit fixes the example.
Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
index cf48cd806e00..7771ecaac586 100644
--- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
+++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
@@ -47,7 +47,7 @@ Example:
interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_LOW>;
clocks = <&infracfg CLK_INFRA_GCE>;
clock-names = "gce";
- #mbox-cells = <3>;
+ #mbox-cells = <2>;
};
Example for a client device:
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value
2020-10-18 19:30 [PATCH] dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value Fabien Parent
@ 2020-10-19 10:18 ` Matthias Brugger
2020-10-23 16:49 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2020-10-19 10:18 UTC (permalink / raw)
To: Fabien Parent, linux-kernel, linux-mediatek, linux-arm-kernel,
devicetree
Cc: dennis-yc.hsieh, ck.hu, bibby.hsieh, jaswinder.singh
On 18/10/2020 21:30, Fabien Parent wrote:
> As the binding documentation says, #mbox-cells must have a value of 2,
> but the example use a value 3. The MT8173 device tree correctly use
> mbox-cells = <2>. This commit fixes the example.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
Fixes: 19d8e335d58a ("dt-binding: gce: remove atomic_exec in mboxes property")
With that:
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> index cf48cd806e00..7771ecaac586 100644
> --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> @@ -47,7 +47,7 @@ Example:
> interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_LOW>;
> clocks = <&infracfg CLK_INFRA_GCE>;
> clock-names = "gce";
> - #mbox-cells = <3>;
> + #mbox-cells = <2>;
> };
>
> Example for a client device:
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value
2020-10-18 19:30 [PATCH] dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value Fabien Parent
2020-10-19 10:18 ` Matthias Brugger
@ 2020-10-23 16:49 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-10-23 16:49 UTC (permalink / raw)
To: Fabien Parent
Cc: linux-arm-kernel, linux-kernel, devicetree, dennis-yc.hsieh,
bibby.hsieh, ck.hu, matthias.bgg, linux-mediatek,
jaswinder.singh
On Sun, 18 Oct 2020 21:30:16 +0200, Fabien Parent wrote:
> As the binding documentation says, #mbox-cells must have a value of 2,
> but the example use a value 3. The MT8173 device tree correctly use
> mbox-cells = <2>. This commit fixes the example.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
> Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-23 16:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-18 19:30 [PATCH] dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value Fabien Parent
2020-10-19 10:18 ` Matthias Brugger
2020-10-23 16:49 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).