* Re: [PATCH 2/2] remoteproc: mediatek: Support mt8186 scp [not found] ` <20220103075854.10438-2-allen-kh.cheng@mediatek.com> @ 2022-01-04 8:43 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 2+ messages in thread From: AngeloGioacchino Del Regno @ 2022-01-04 8:43 UTC (permalink / raw) To: allen-kh.cheng, Ohad Ben-Cohen, Bjorn Andersson, Mathieu Poirier, Rob Herring, Matthias Brugger, Tinghan Shen Cc: Mark Brown, linux-remoteproc, Project_Global_Chrome_Upstream_Group, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek Il 03/01/22 08:58, allen-kh.cheng ha scritto: > Add SCP support for mt8186 > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> Hello! Thanks for the patch! However, there's something to improve... > --- > drivers/remoteproc/mtk_scp.c | 39 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 36e48cf58ed6..38eab6b86fd7 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -365,6 +365,31 @@ static int mt8183_scp_before_load(struct mtk_scp *scp) > return 0; > } > > +static int mt8186_scp_before_load(struct mtk_scp *scp) > +{ > + int i; > + > + /* Clear SCP to host interrupt */ > + writel(MT8183_SCP_IPC_INT_BIT, scp->reg_base + MT8183_SCP_TO_HOST); > + > + /* Reset clocks before loading FW */ > + writel(0x0, scp->reg_base + MT8183_SCP_CLK_SW_SEL); > + writel(0x0, scp->reg_base + MT8183_SCP_CLK_DIV_SEL); > + ............. > + /* Turn on the power of SCP's SRAM before using it. Enable 1 block per time*/ > + for (i = 31; i >= 0; i--) > + writel(GENMASK(i, 0), scp->reg_base + MT8183_SCP_SRAM_PDN); > + writel(0, scp->reg_base + MT8183_SCP_SRAM_PDN); > + ............. This snippet corresponds exactly to the mt8192_power_on_sram() helper: please avoid code duplication by simply calling that function instead. Thanks, - Angelo ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Add binding for mt8186 scp [not found] <20220103075854.10438-1-allen-kh.cheng@mediatek.com> [not found] ` <20220103075854.10438-2-allen-kh.cheng@mediatek.com> @ 2022-01-04 8:43 ` AngeloGioacchino Del Regno 1 sibling, 0 replies; 2+ messages in thread From: AngeloGioacchino Del Regno @ 2022-01-04 8:43 UTC (permalink / raw) To: allen-kh.cheng, Ohad Ben-Cohen, Bjorn Andersson, Mathieu Poirier, Rob Herring, Matthias Brugger, Tinghan Shen Cc: Mark Brown, linux-remoteproc, Project_Global_Chrome_Upstream_Group, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek Il 03/01/22 08:58, allen-kh.cheng ha scritto: > Add mt8186 compatible to binding document. > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > --- > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > index d21a25ee96e6..5b693a2d049c 100644 > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > @@ -17,6 +17,7 @@ properties: > compatible: > enum: > - mediatek,mt8183-scp > + - mediatek,mt8186-scp > - mediatek,mt8192-scp > - mediatek,mt8195-scp > > Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-04 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220103075854.10438-1-allen-kh.cheng@mediatek.com>
[not found] ` <20220103075854.10438-2-allen-kh.cheng@mediatek.com>
2022-01-04 8:43 ` [PATCH 2/2] remoteproc: mediatek: Support mt8186 scp AngeloGioacchino Del Regno
2022-01-04 8:43 ` [PATCH 1/2] dt-bindings: remoteproc: mediatek: Add binding for " AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).