* Re: [PATCH v3 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml
@ 2020-07-07 13:35 Guenter Roeck
2020-07-08 3:34 ` Chris Ruehl
0 siblings, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2020-07-07 13:35 UTC (permalink / raw)
To: Chris Ruehl
Cc: Jack Lo, devicetree, Jean Delvare, Rob Herring, linux-hwmon,
linux-kernel
On Tue, Jul 07, 2020 at 04:01:03PM +0800, Chris Ruehl wrote:
> Add documentation for the newly added DTS support in the shtc1 driver.
> To align with the drivers logic to have high precision by default
> a boolean sensirion,low_precision is used to switch to low precision.
>
> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
> ---
> .../bindings/hwmon/sensirion,shtc1.yaml | 53 +++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml
> new file mode 100644
> index 000000000000..bcccdcadd86b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/sensirion,shtc1.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sensirion SHTC1 Humidity and Temperature Sensor IC
> +
> +maintainers:
> + - jdelvare@suse.com
Did Jean agree to maintain this file ?
> +
> +description: |
> + The SHTC1, SHTW1 and SHTC3 are digital humidity and temperature sensor
> + designed especially for battery-driven high-volume consumer electronics
> + applications.
> + For further information refere to Documentation/hwmon/shtc1.rst
> +
> + This binding document describes the binding for the hardware monitor
> + portion of the driver.
> +
> +properties:
> + compatible:
> + enum:
> + - sensirion,shtc1
> + - sensirion,shtw1
> + - sensirion,shtc3
> +
> + reg: I2C address 0x70
> +
> +Optional properties:
> + sensirion,blocking_io: |
> + bool, if set the i2c bus hold until measure finished
> + sensirion,low_precision: |
> + bool, if set aquire data with low precision (not recommend)
recommended
It might make sense to mention that the default is expected to be high precision
if not specified.
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +Example:
> + &i2c1 {
> + status = "okay";
> + clock-frequency = <400000>;
> +
> + shtc3@70 {
> + compatible = "sensirion,shtc3";
> + reg = <0x70>
> + sensirion,blocking_io;
> + status = "okay";
> + };
> + };
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml
2020-07-07 13:35 [PATCH v3 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml Guenter Roeck
@ 2020-07-08 3:34 ` Chris Ruehl
2020-07-08 3:50 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Chris Ruehl @ 2020-07-08 3:34 UTC (permalink / raw)
To: Guenter Roeck
Cc: Jack Lo, devicetree, Jean Delvare, Rob Herring, linux-hwmon,
linux-kernel
Hi Guenter,
On 7/7/2020 9:35 pm, Guenter Roeck wrote:
> On Tue, Jul 07, 2020 at 04:01:03PM +0800, Chris Ruehl wrote:
>> Add documentation for the newly added DTS support in the shtc1 driver.
>> To align with the drivers logic to have high precision by default
>> a boolean sensirion,low_precision is used to switch to low precision.
>>
>> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
>> ---
>> .../bindings/hwmon/sensirion,shtc1.yaml | 53 +++++++++++++++++++
>> 1 file changed, 53 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml
>> new file mode 100644
>> index 000000000000..bcccdcadd86b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml
>> @@ -0,0 +1,53 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/hwmon/sensirion,shtc1.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Sensirion SHTC1 Humidity and Temperature Sensor IC
>> +
>> +maintainers:
>> + - jdelvare@suse.com
>
> Did Jean agree to maintain this file ?
I thought its OK to set the maintainer from the list shown with
get_maintainer.pl here. I don't mind take care of this file - there will be
small changes only in case the dt-schema change and requires updates.
I put me here, if that is acceptable.
Chris
>
>> +
>> +description: |
>> + The SHTC1, SHTW1 and SHTC3 are digital humidity and temperature sensor
>> + designed especially for battery-driven high-volume consumer electronics
>> + applications.
>> + For further information refere to Documentation/hwmon/shtc1.rst
>> +
>> + This binding document describes the binding for the hardware monitor
>> + portion of the driver.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - sensirion,shtc1
>> + - sensirion,shtw1
>> + - sensirion,shtc3
>> +
>> + reg: I2C address 0x70
>> +
>> +Optional properties:
>> + sensirion,blocking_io: |
>> + bool, if set the i2c bus hold until measure finished
>> + sensirion,low_precision: |
>> + bool, if set aquire data with low precision (not recommend)
>
> recommended
>
> It might make sense to mention that the default is expected to be high precision
> if not specified.
>
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +additionalProperties: false
>> +
>> +Example:
>> + &i2c1 {
>> + status = "okay";
>> + clock-frequency = <400000>;
>> +
>> + shtc3@70 {
>> + compatible = "sensirion,shtc3";
>> + reg = <0x70>
>> + sensirion,blocking_io;
>> + status = "okay";
>> + };
>> + };
>> --
>> 2.20.1
>>
--
GTSYS Limited RFID Technology
9/F, Unit E, R07, Kwai Shing Industrial Building Phase 2,
42-46 Tai Lin Pai Road, Kwai Chung, N.T., Hong Kong
Tel (852) 9079 9521
Disclaimer: https://www.gtsys.com.hk/email/classified.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml
2020-07-08 3:34 ` Chris Ruehl
@ 2020-07-08 3:50 ` Guenter Roeck
0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2020-07-08 3:50 UTC (permalink / raw)
To: Chris Ruehl
Cc: Jack Lo, devicetree, Jean Delvare, Rob Herring, linux-hwmon,
linux-kernel
On 7/7/20 8:34 PM, Chris Ruehl wrote:
> Hi Guenter,
>
> On 7/7/2020 9:35 pm, Guenter Roeck wrote:
>> On Tue, Jul 07, 2020 at 04:01:03PM +0800, Chris Ruehl wrote:
>>> Add documentation for the newly added DTS support in the shtc1 driver.
>>> To align with the drivers logic to have high precision by default
>>> a boolean sensirion,low_precision is used to switch to low precision.
>>>
>>> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
>>> ---
>>> .../bindings/hwmon/sensirion,shtc1.yaml | 53 +++++++++++++++++++
>>> 1 file changed, 53 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml
>>> new file mode 100644
>>> index 000000000000..bcccdcadd86b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml
>>> @@ -0,0 +1,53 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/hwmon/sensirion,shtc1.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Sensirion SHTC1 Humidity and Temperature Sensor IC
>>> +
>>> +maintainers:
>>> + - jdelvare@suse.com
>>
>> Did Jean agree to maintain this file ?
>
> I thought its OK to set the maintainer from the list shown with
> get_maintainer.pl here. I don't mind take care of this file - there will be small changes only in case the dt-schema change and requires updates.
>
No, it isn't. Jean and I are the maintainers for the hwmon
subsystem, but that doesn't mean or suggest that we should
be listed as maintainers in individual files.
> I put me here, if that is acceptable.
>
Either you, or none.
Thanks,
Guenter
> Chris
>
>>
>>> +
>>> +description: |
>>> + The SHTC1, SHTW1 and SHTC3 are digital humidity and temperature sensor
>>> + designed especially for battery-driven high-volume consumer electronics
>>> + applications.
>>> + For further information refere to Documentation/hwmon/shtc1.rst
>>> +
>>> + This binding document describes the binding for the hardware monitor
>>> + portion of the driver.
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - sensirion,shtc1
>>> + - sensirion,shtw1
>>> + - sensirion,shtc3
>>> +
>>> + reg: I2C address 0x70
>>> +
>>> +Optional properties:
>>> + sensirion,blocking_io: |
>>> + bool, if set the i2c bus hold until measure finished
>>> + sensirion,low_precision: |
>>> + bool, if set aquire data with low precision (not recommend)
>>
>> recommended
>>
>> It might make sense to mention that the default is expected to be high precision
>> if not specified.
>>
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> +
>>> +additionalProperties: false
>>> +
>>> +Example:
>>> + &i2c1 {
>>> + status = "okay";
>>> + clock-frequency = <400000>;
>>> +
>>> + shtc3@70 {
>>> + compatible = "sensirion,shtc3";
>>> + reg = <0x70>
>>> + sensirion,blocking_io;
>>> + status = "okay";
>>> + };
>>> + };
>>> --
>>> 2.20.1
>>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml
2020-07-07 8:01 [PATCH v3 0/2] shtc1: add support for device tree bindings Chris Ruehl
@ 2020-07-07 8:01 ` Chris Ruehl
0 siblings, 0 replies; 4+ messages in thread
From: Chris Ruehl @ 2020-07-07 8:01 UTC (permalink / raw)
To: Chris Ruehl
Cc: Jack Lo, devicetree, Jean Delvare, Guenter Roeck, Rob Herring,
linux-hwmon, linux-kernel
Add documentation for the newly added DTS support in the shtc1 driver.
To align with the drivers logic to have high precision by default
a boolean sensirion,low_precision is used to switch to low precision.
Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
.../bindings/hwmon/sensirion,shtc1.yaml | 53 +++++++++++++++++++
1 file changed, 53 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml
diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml
new file mode 100644
index 000000000000..bcccdcadd86b
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/sensirion,shtc1.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sensirion SHTC1 Humidity and Temperature Sensor IC
+
+maintainers:
+ - jdelvare@suse.com
+
+description: |
+ The SHTC1, SHTW1 and SHTC3 are digital humidity and temperature sensor
+ designed especially for battery-driven high-volume consumer electronics
+ applications.
+ For further information refere to Documentation/hwmon/shtc1.rst
+
+ This binding document describes the binding for the hardware monitor
+ portion of the driver.
+
+properties:
+ compatible:
+ enum:
+ - sensirion,shtc1
+ - sensirion,shtw1
+ - sensirion,shtc3
+
+ reg: I2C address 0x70
+
+Optional properties:
+ sensirion,blocking_io: |
+ bool, if set the i2c bus hold until measure finished
+ sensirion,low_precision: |
+ bool, if set aquire data with low precision (not recommend)
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+Example:
+ &i2c1 {
+ status = "okay";
+ clock-frequency = <400000>;
+
+ shtc3@70 {
+ compatible = "sensirion,shtc3";
+ reg = <0x70>
+ sensirion,blocking_io;
+ status = "okay";
+ };
+ };
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-08 3:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-07 13:35 [PATCH v3 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml Guenter Roeck
2020-07-08 3:34 ` Chris Ruehl
2020-07-08 3:50 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2020-07-07 8:01 [PATCH v3 0/2] shtc1: add support for device tree bindings Chris Ruehl
2020-07-07 8:01 ` [PATCH v3 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml Chris Ruehl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).