* [PATCH] arm64: dts: amlogic: odroid-n2: set usb-pwr-en regulator always on
@ 2020-02-16 20:21 Anand Moon
2020-02-17 7:38 ` Jerome Brunet
0 siblings, 1 reply; 3+ messages in thread
From: Anand Moon @ 2020-02-16 20:21 UTC (permalink / raw)
To: Rob Herring, Kevin Hilman, Martin Blumenstingl, Neil Armstrong
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel, Jerome Brunet
usb-pwr-en regulator is getting disable after booting, setting
regulator-alway-on help enable the regulator after booting.
[ 31.766097] USB_PWR_EN: disabling
Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2)
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
Patch generated on top of my earier patch.
[0] https://patchwork.kernel.org/patch/11384531/
[1] https://patchwork.kernel.org/patch/11384533/
Before
[root@alarm ~]# cat /sys/kernel/debug/regulator/regulator_summary | grep USB
USB_PWR_EN 0 1 0 unknown 5000mV 0mA 5000mV 5000mV
After
[root@alarm ~]# cat /sys/kernel/debug/regulator/regulator_summary | grep USB
USB_PWR_EN 1 1 0 unknown 5000mV 0mA 5000mV 5000mV
---
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
index 23eddff85fe5..938a9e15adfc 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
@@ -177,6 +177,7 @@ usb_pwr_en: regulator-usb_pwr_en {
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
vin-supply = <&vcc_5v>;
+ regulator-always-on;
/* Connected to the microUSB port power enable */
gpio = <&gpio GPIOH_6 GPIO_ACTIVE_HIGH>;
--
2.25.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: amlogic: odroid-n2: set usb-pwr-en regulator always on
2020-02-16 20:21 [PATCH] arm64: dts: amlogic: odroid-n2: set usb-pwr-en regulator always on Anand Moon
@ 2020-02-17 7:38 ` Jerome Brunet
2020-02-17 8:06 ` Anand Moon
0 siblings, 1 reply; 3+ messages in thread
From: Jerome Brunet @ 2020-02-17 7:38 UTC (permalink / raw)
To: Anand Moon, Rob Herring, Kevin Hilman, Martin Blumenstingl,
Neil Armstrong
Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
On Sun 16 Feb 2020 at 21:21, Anand Moon <linux.amoon@gmail.com> wrote:
> usb-pwr-en regulator is getting disable after booting, setting
> regulator-alway-on help enable the regulator after booting.
This explains what your patch does, not why it needs to be done.
Why does this regulator need be on at all time ? What device needs it
and cannot claim it properly ?
>
> [ 31.766097] USB_PWR_EN: disabling
>
> Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2)
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Patch generated on top of my earier patch.
> [0] https://patchwork.kernel.org/patch/11384531/
> [1] https://patchwork.kernel.org/patch/11384533/
>
> Before
> [root@alarm ~]# cat /sys/kernel/debug/regulator/regulator_summary | grep USB
> USB_PWR_EN 0 1 0 unknown 5000mV 0mA 5000mV 5000mV
> After
> [root@alarm ~]# cat /sys/kernel/debug/regulator/regulator_summary | grep USB
> USB_PWR_EN 1 1 0 unknown 5000mV 0mA 5000mV 5000mV
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> index 23eddff85fe5..938a9e15adfc 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> @@ -177,6 +177,7 @@ usb_pwr_en: regulator-usb_pwr_en {
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
> vin-supply = <&vcc_5v>;
> + regulator-always-on;
>
> /* Connected to the microUSB port power enable */
> gpio = <&gpio GPIOH_6 GPIO_ACTIVE_HIGH>;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: amlogic: odroid-n2: set usb-pwr-en regulator always on
2020-02-17 7:38 ` Jerome Brunet
@ 2020-02-17 8:06 ` Anand Moon
0 siblings, 0 replies; 3+ messages in thread
From: Anand Moon @ 2020-02-17 8:06 UTC (permalink / raw)
To: Jerome Brunet
Cc: Rob Herring, Kevin Hilman, Martin Blumenstingl, Neil Armstrong,
devicetree, linux-arm-kernel, linux-amlogic, Linux Kernel
Hi Jerome,
On Mon, 17 Feb 2020 at 13:08, Jerome Brunet <jbrunet@baylibre.com> wrote:
>
>
> On Sun 16 Feb 2020 at 21:21, Anand Moon <linux.amoon@gmail.com> wrote:
>
> > usb-pwr-en regulator is getting disable after booting, setting
> > regulator-alway-on help enable the regulator after booting.
>
> This explains what your patch does, not why it needs to be done.
> Why does this regulator need be on at all time ? What device needs it
> and cannot claim it properly ?
>
I missed this node is for micro usb, plz discard this patch.
I am relay sorry for this, sorry for the noise.
-Anand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-17 8:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-16 20:21 [PATCH] arm64: dts: amlogic: odroid-n2: set usb-pwr-en regulator always on Anand Moon
2020-02-17 7:38 ` Jerome Brunet
2020-02-17 8:06 ` Anand Moon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).