* [PATCH v2 1/2] video: goldfishfb: add devicetree bindings
@ 2016-03-10 15:39 Alan
[not found] ` <20160310153845.8996.17736.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Alan @ 2016-03-10 15:39 UTC (permalink / raw)
To: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA, tomi.valkeinen-l0cyMroinI0,
plagnioj-sclMFOaUSTBWk0Htik3J/w
From: Greg Hackmann <ghackmann-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Add device tree bindings to the Goldfish frame buffer interface.
Signed-off-by: Greg Hackmann <ghackmann-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Jin Qian <jinqian-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
Documentation/devicetree/bindings/goldfish/fb.txt | 17 +++++++++++++++++
drivers/video/fbdev/goldfishfb.c | 9 ++++++++-
2 files changed, 25 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/goldfish/fb.txt
diff --git a/Documentation/devicetree/bindings/goldfish/fb.txt b/Documentation/devicetree/bindings/goldfish/fb.txt
new file mode 100644
index 0000000..8e7a6f8
--- /dev/null
+++ b/Documentation/devicetree/bindings/goldfish/fb.txt
@@ -0,0 +1,17 @@
+Android Goldfish Framebuffer
+
+Android goldfish framebuffer device generated by android emulator.
+
+Required properties:
+
+- compatible : should contain "google,goldfish-fb" to match emulator
+- reg : <registers mapping>
+- interrupts : <interrupt mapping>
+
+Example:
+
+ goldfish_fb@9010000 {
+ compatible = "google,goldfish-fb";
+ reg = <0x9010000 0x100>;
+ interrupts = <0x2>;
+ };
diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c
index 7f6c9e6..f0e651b 100644
--- a/drivers/video/fbdev/goldfishfb.c
+++ b/drivers/video/fbdev/goldfishfb.c
@@ -304,12 +304,19 @@ static int goldfish_fb_remove(struct platform_device *pdev)
return 0;
}
+static const struct of_device_id goldfish_fb_of_match[] = {
+ { .compatible = "google,goldfish-fb", },
+ {},
+};
+MODULE_DEVICE_TABLE(of, goldfish_fb_of_match);
static struct platform_driver goldfish_fb_driver = {
.probe = goldfish_fb_probe,
.remove = goldfish_fb_remove,
.driver = {
- .name = "goldfish_fb"
+ .name = "goldfish_fb",
+ .owner = THIS_MODULE,
+ .of_match_table = goldfish_fb_of_match,
}
};
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] goldfish: Enable ACPI-based enumeration for goldfish framebuffer
[not found] ` <20160310153845.8996.17736.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
@ 2016-03-10 15:39 ` Alan
2016-03-18 16:23 ` [PATCH v2 1/2] video: goldfishfb: add devicetree bindings Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Alan @ 2016-03-10 15:39 UTC (permalink / raw)
To: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA, tomi.valkeinen-l0cyMroinI0,
plagnioj-sclMFOaUSTBWk0Htik3J/w
From: Yu Ning <yu.ning-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Enable ACPI bindings for the Goldfish framebuffer device.
Signed-off-by: Yu Ning <yu.ning-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Jin Qian <jinqian-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Alan <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
drivers/video/fbdev/goldfishfb.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c
index f0e651b..58b33e4 100644
--- a/drivers/video/fbdev/goldfishfb.c
+++ b/drivers/video/fbdev/goldfishfb.c
@@ -26,6 +26,7 @@
#include <linux/interrupt.h>
#include <linux/ioport.h>
#include <linux/platform_device.h>
+#include <linux/acpi.h>
enum {
FB_GET_WIDTH = 0x00,
@@ -310,6 +311,12 @@ static const struct of_device_id goldfish_fb_of_match[] = {
};
MODULE_DEVICE_TABLE(of, goldfish_fb_of_match);
+static const struct acpi_device_id goldfish_fb_acpi_match[] = {
+ { "GFSH0004", 0 },
+ { },
+};
+MODULE_DEVICE_TABLE(acpi, goldfish_fb_acpi_match);
+
static struct platform_driver goldfish_fb_driver = {
.probe = goldfish_fb_probe,
.remove = goldfish_fb_remove,
@@ -317,6 +324,7 @@ static struct platform_driver goldfish_fb_driver = {
.name = "goldfish_fb",
.owner = THIS_MODULE,
.of_match_table = goldfish_fb_of_match,
+ .acpi_match_table = ACPI_PTR(goldfish_fb_acpi_match),
}
};
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] video: goldfishfb: add devicetree bindings
[not found] ` <20160310153845.8996.17736.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2016-03-10 15:39 ` [PATCH v2 2/2] goldfish: Enable ACPI-based enumeration for goldfish framebuffer Alan
@ 2016-03-18 16:23 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2016-03-18 16:23 UTC (permalink / raw)
To: Alan
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA, tomi.valkeinen-l0cyMroinI0,
plagnioj-sclMFOaUSTBWk0Htik3J/w
On Thu, Mar 10, 2016 at 03:39:00PM +0000, Alan wrote:
> From: Greg Hackmann <ghackmann-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
>
> Add device tree bindings to the Goldfish frame buffer interface.
>
> Signed-off-by: Greg Hackmann <ghackmann-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Jin Qian <jinqian-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
[...]
> diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c
> index 7f6c9e6..f0e651b 100644
> --- a/drivers/video/fbdev/goldfishfb.c
> +++ b/drivers/video/fbdev/goldfishfb.c
> @@ -304,12 +304,19 @@ static int goldfish_fb_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static const struct of_device_id goldfish_fb_of_match[] = {
> + { .compatible = "google,goldfish-fb", },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, goldfish_fb_of_match);
>
> static struct platform_driver goldfish_fb_driver = {
> .probe = goldfish_fb_probe,
> .remove = goldfish_fb_remove,
> .driver = {
> - .name = "goldfish_fb"
> + .name = "goldfish_fb",
> + .owner = THIS_MODULE,
This can be dropped. Otherwise,
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> + .of_match_table = goldfish_fb_of_match,
> }
> };
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-18 16:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-10 15:39 [PATCH v2 1/2] video: goldfishfb: add devicetree bindings Alan
[not found] ` <20160310153845.8996.17736.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2016-03-10 15:39 ` [PATCH v2 2/2] goldfish: Enable ACPI-based enumeration for goldfish framebuffer Alan
2016-03-18 16:23 ` [PATCH v2 1/2] video: goldfishfb: add devicetree bindings Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).