From: Peter Chen <hzpeterchen@gmail.com>
To: Roger Quadros <rogerq@ti.com>
Cc: peter.chen@freescale.com, stern@rowland.harvard.edu,
balbi@kernel.org, gregkh@linuxfoundation.org,
dan.j.williams@intel.com, jun.li@freescale.com,
mathias.nyman@linux.intel.com, tony@atomide.com,
Joao.Pinto@synopsys.com, abrestic@chromium.org,
yoshihiro.shimoda.uh@renesas.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v7 08/14] usb: otg: add OTG/dual-role core
Date: Wed, 11 May 2016 16:34:21 +0800 [thread overview]
Message-ID: <20160511083421.GE16910@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <1462191537-10314-9-git-send-email-rogerq@ti.com>
On Mon, May 02, 2016 at 03:18:51PM +0300, Roger Quadros wrote:
> +
> + if (config->otg_work) /* custom otg_work ? */
> + INIT_WORK(&otg->work, config->otg_work);
> + else
> + INIT_WORK(&otg->work, usb_drd_work);
> +
> + otg->wq = create_singlethread_workqueue("usb_otg");
Using create_freezable_workqueue like I suggested before.
> + */
> +
> +#ifndef __DRIVERS_USB_COMMON_USB_OTG_H
> +#define __DRIVERS_USB_COMMON_USB_OTG_H
> +
> +/*
> + * A-DEVICE timing constants
> + */
> +
> +/* Wait for VBUS Rise */
> +#define TA_WAIT_VRISE (100) /* a_wait_vrise: section 7.1.2
> + * a_wait_vrise_tmr: section 7.4.5.1
> + * TA_VBUS_RISE <= 100ms, section 4.4
> + * Table 4-1: Electrical Characteristics
> + * ->DC Electrical Timing
> + */
> +/* Wait for VBUS Fall */
> +#define TA_WAIT_VFALL (1000) /* a_wait_vfall: section 7.1.7
> + * a_wait_vfall_tmr: section: 7.4.5.2
> + */
> +/* Wait for B-Connect */
> +#define TA_WAIT_BCON (10000) /* a_wait_bcon: section 7.1.3
> + * TA_WAIT_BCON: should be between 1100
> + * and 30000 ms, section 5.5, Table 5-1
> + */
> +/* A-Idle to B-Disconnect */
> +#define TA_AIDL_BDIS (5000) /* a_suspend min 200 ms, section 5.2.1
> + * TA_AIDL_BDIS: section 5.5, Table 5-1
> + */
> +/* B-Idle to A-Disconnect */
> +#define TA_BIDL_ADIS (500) /* TA_BIDL_ADIS: section 5.2.1
> + * 500ms is used for B switch to host
> + * for safe
> + */
> +
> +/*
> + * B-device timing constants
> + */
> +
> +/* Data-Line Pulse Time*/
> +#define TB_DATA_PLS (10) /* b_srp_init,continue 5~10ms
> + * section:5.1.3
> + */
> +/* SRP Fail Time */
> +#define TB_SRP_FAIL (6000) /* b_srp_init,fail time 5~6s
> + * section:5.1.6
> + */
> +/* A-SE0 to B-Reset */
> +#define TB_ASE0_BRST (155) /* minimum 155 ms, section:5.3.1 */
> +/* SE0 Time Before SRP */
> +#define TB_SE0_SRP (1000) /* b_idle,minimum 1s, section:5.1.2 */
> +/* SSEND time before SRP */
> +#define TB_SSEND_SRP (1500) /* minimum 1.5 sec, section:5.1.2 */
> +
> +#define TB_SESS_VLD (1000)
Seems you agree to remove above definitions.
>
> /* Current usb protocol used: 0:undefine; 1:host; 2:client */
> diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h
> index 85b8fb5..b094352 100644
> --- a/include/linux/usb/otg.h
> +++ b/include/linux/usb/otg.h
> @@ -10,10 +10,55 @@
> #define __LINUX_USB_OTG_H
>
> #include <linux/phy/phy.h>
> -#include <linux/usb/phy.h>
> -#include <linux/usb/otg-fsm.h>
> +#include <linux/device.h>
> +#include <linux/hrtimer.h>
> +#include <linux/ktime.h>
Above two headers are not needed
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2016-05-11 8:34 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 12:18 [PATCH v7 00/14] USB OTG/dual-role framework Roger Quadros
2016-05-02 12:18 ` [PATCH v7 01/14] usb: hcd: Initialize hcd->flags to 0 Roger Quadros
[not found] ` <1462191537-10314-2-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-06 9:05 ` Peter Chen
2016-05-02 12:18 ` [PATCH v7 02/14] usb: otg-fsm: Prevent build warning "VDBG" redefined Roger Quadros
2016-05-11 8:17 ` Peter Chen
2016-05-02 12:18 ` [PATCH v7 03/14] usb: hcd.h: Add OTG to HCD interface Roger Quadros
2016-05-06 9:41 ` Peter Chen
[not found] ` <20160506094103.GF32359-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-05-09 9:45 ` Roger Quadros
[not found] ` <57305C42.90300-l0cyMroinI0@public.gmane.org>
2016-05-10 3:14 ` Peter Chen
2016-05-10 7:34 ` Roger Quadros
2016-05-10 8:03 ` Jun Li
2016-05-10 9:20 ` Roger Quadros
2016-05-11 6:19 ` Peter Chen
2016-05-10 8:12 ` Felipe Balbi
2016-05-10 9:12 ` Roger Quadros
[not found] ` <1462191537-10314-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-02 12:18 ` [PATCH v7 04/14] usb: otg-fsm: use usb_otg wherever possible Roger Quadros
2016-05-02 12:18 ` [PATCH v7 05/14] usb: otg-fsm: move host controller operations into usb_otg->hcd_ops Roger Quadros
[not found] ` <1462191537-10314-6-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-11 6:10 ` Peter Chen
[not found] ` <20160511061001.GA16910-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-05-11 11:02 ` Roger Quadros
[not found] ` <5733113D.2030009-l0cyMroinI0@public.gmane.org>
2016-05-11 12:32 ` Roger Quadros
[not found] ` <5733265E.2040105-l0cyMroinI0@public.gmane.org>
2016-05-12 8:18 ` Peter Chen
[not found] ` <20160512081843.GA23083-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-05-12 8:29 ` Roger Quadros
2016-05-02 12:18 ` [PATCH v7 06/14] usb: gadget.h: Add OTG to gadget interface Roger Quadros
2016-05-02 12:18 ` [PATCH v7 07/14] usb: otg: get rid of CONFIG_USB_OTG_FSM in favour of CONFIG_USB_OTG Roger Quadros
[not found] ` <1462191537-10314-8-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-11 8:21 ` Peter Chen
2016-05-02 12:18 ` [PATCH v7 08/14] usb: otg: add OTG/dual-role core Roger Quadros
2016-05-11 8:34 ` Peter Chen [this message]
2016-05-11 11:03 ` Roger Quadros
2016-05-02 12:18 ` [PATCH v7 09/14] usb: of: add an API to get OTG device from USB controller node Roger Quadros
[not found] ` <1462191537-10314-10-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-04 13:15 ` Rob Herring
2016-05-11 8:40 ` Peter Chen
2016-05-11 11:04 ` Roger Quadros
2016-05-02 12:18 ` [PATCH v7 10/14] usb: otg: add hcd companion support Roger Quadros
[not found] ` <1462191537-10314-11-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-04 13:17 ` Rob Herring
2016-05-04 13:47 ` Roger Quadros
2016-05-11 13:54 ` Rob Herring
2016-05-11 14:13 ` Roger Quadros
[not found] ` <57333DFF.3090609-l0cyMroinI0@public.gmane.org>
2016-05-11 14:47 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1605111043030.1882-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2016-05-12 4:00 ` Yoshihiro Shimoda
[not found] ` <SG2PR06MB09194AB523C3ABDB425285C7D8730-ESzmfEwOt/zNQ8RBPPB5A20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-05-12 8:34 ` Roger Quadros
[not found] ` <57343FFC.9090105-l0cyMroinI0@public.gmane.org>
2016-05-12 9:31 ` Roger Quadros
[not found] ` <57344D7B.3050005-l0cyMroinI0@public.gmane.org>
2016-05-12 10:31 ` Yoshihiro Shimoda
[not found] ` <SG2PR06MB091923EEBAA67EC1D1E48B6DD8730-ESzmfEwOt/zNQ8RBPPB5A20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-05-12 12:13 ` Roger Quadros
2016-05-16 2:13 ` Peter Chen
[not found] ` <20160516021350.GA24609-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-05-16 8:01 ` Roger Quadros
[not found] ` <57397E57.8060903-l0cyMroinI0@public.gmane.org>
2016-05-16 8:13 ` Peter Chen
[not found] ` <20160516081326.GC24609-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-05-16 8:35 ` Roger Quadros
2016-05-12 18:16 ` Alan Stern
2016-05-11 8:43 ` Peter Chen
2016-05-02 12:18 ` [PATCH v7 11/14] usb: otg: use dev_dbg() instead of VDBG() Roger Quadros
[not found] ` <1462191537-10314-12-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-06 9:04 ` Peter Chen
[not found] ` <20160506090425.GD32359-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-05-09 9:48 ` Roger Quadros
2016-05-11 8:43 ` Peter Chen
2016-05-02 12:18 ` [PATCH v7 13/14] usb: gadget: udc: adapt to OTG core Roger Quadros
2016-05-11 8:36 ` [PATCH v7 00/14] USB OTG/dual-role framework Peter Chen
[not found] ` <20160511083619.GF16910-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-05-11 11:05 ` Roger Quadros
2016-05-02 12:18 ` [PATCH v7 12/14] usb: hcd: Adapt to OTG core Roger Quadros
[not found] ` <1462191537-10314-13-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-11 8:57 ` Peter Chen
2016-05-02 12:18 ` [PATCH v7 14/14] usb: host: xhci-plat: Add otg device to platform data Roger Quadros
2016-05-11 9:00 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511083421.GE16910@shlinux2.ap.freescale.net \
--to=hzpeterchen@gmail.com \
--cc=Joao.Pinto@synopsys.com \
--cc=abrestic@chromium.org \
--cc=balbi@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=peter.chen@freescale.com \
--cc=rogerq@ti.com \
--cc=stern@rowland.harvard.edu \
--cc=tony@atomide.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).