From: Roger Quadros <rogerq@ti.com>
To: Peter Chen <hzpeterchen@gmail.com>
Cc: peter.chen@freescale.com, stern@rowland.harvard.edu,
balbi@kernel.org, gregkh@linuxfoundation.org,
dan.j.williams@intel.com, jun.li@freescale.com,
mathias.nyman@linux.intel.com, tony@atomide.com,
Joao.Pinto@synopsys.com, abrestic@chromium.org,
yoshihiro.shimoda.uh@renesas.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v7 09/14] usb: of: add an API to get OTG device from USB controller node
Date: Wed, 11 May 2016 14:04:12 +0300 [thread overview]
Message-ID: <573311AC.8040800@ti.com> (raw)
In-Reply-To: <20160511084057.GG16910@shlinux2.ap.freescale.net>
On 11/05/16 11:40, Peter Chen wrote:
> On Mon, May 02, 2016 at 03:18:52PM +0300, Roger Quadros wrote:
>> The OTG controller and the USB controller an be linked via the
>
> Typo?
Will fix.
cheers,
-roger
>
> Others are ok for me.
>
> Acked-by: Peter Chen <peter.chen@nxp.com>
>
>> 'otg-controller' property in the USB controller's device node.
>>
>> of_usb_get_otg() can be used to get the OTG controller device
>> from the USB controller's device node.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>> Documentation/devicetree/bindings/usb/generic.txt | 3 +++
>> drivers/usb/common/common.c | 27 +++++++++++++++++++++++
>> include/linux/usb/of.h | 9 ++++++++
>> 3 files changed, 39 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/generic.txt b/Documentation/devicetree/bindings/usb/generic.txt
>> index bba8257..f6866c1 100644
>> --- a/Documentation/devicetree/bindings/usb/generic.txt
>> +++ b/Documentation/devicetree/bindings/usb/generic.txt
>> @@ -24,6 +24,9 @@ Optional properties:
>> optional for OTG device.
>> - adp-disable: tells OTG controllers we want to disable OTG ADP, ADP is
>> optional for OTG device.
>> + - otg-controller: phandle to otg controller. Host or gadget controllers can
>> + contain this property to link it to a particular OTG
>> + controller.
>>
>> This is an attribute to a USB controller such as:
>>
>> diff --git a/drivers/usb/common/common.c b/drivers/usb/common/common.c
>> index e3d0161..d7ec471 100644
>> --- a/drivers/usb/common/common.c
>> +++ b/drivers/usb/common/common.c
>> @@ -238,6 +238,33 @@ int of_usb_update_otg_caps(struct device_node *np,
>> }
>> EXPORT_SYMBOL_GPL(of_usb_update_otg_caps);
>>
>> +#ifdef CONFIG_USB_OTG
>> +/**
>> + * of_usb_get_otg - get the OTG controller linked to the USB controller
>> + * @np: Pointer to the device_node of the USB controller
>> + * @otg_caps: Pointer to the target usb_otg_caps to be set
>> + *
>> + * Returns the OTG controller device or NULL on error.
>> + */
>> +struct device *of_usb_get_otg(struct device_node *np)
>> +{
>> + struct device_node *otg_np;
>> + struct platform_device *pdev;
>> +
>> + otg_np = of_parse_phandle(np, "otg-controller", 0);
>> + if (!otg_np)
>> + return NULL;
>> +
>> + pdev = of_find_device_by_node(otg_np);
>> + of_node_put(otg_np);
>> + if (!pdev)
>> + return NULL;
>> +
>> + return &pdev->dev;
>> +}
>> +EXPORT_SYMBOL_GPL(of_usb_get_otg);
>> +#endif
>> +
>> #endif
>>
>> MODULE_LICENSE("GPL");
>> diff --git a/include/linux/usb/of.h b/include/linux/usb/of.h
>> index de3237f..499a4e8 100644
>> --- a/include/linux/usb/of.h
>> +++ b/include/linux/usb/of.h
>> @@ -40,6 +40,15 @@ static inline struct device_node *usb_of_get_child_node
>> }
>> #endif
>>
>> +#if IS_ENABLED(CONFIG_OF) && IS_ENABLED(CONFIG_USB_OTG)
>> +struct device *of_usb_get_otg(struct device_node *np);
>> +#else
>> +static inline struct device *of_usb_get_otg(struct device_node *np)
>> +{
>> + return NULL;
>> +}
>> +#endif
>> +
>> #if IS_ENABLED(CONFIG_OF) && IS_ENABLED(CONFIG_USB_SUPPORT)
>> enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np);
>> #else
>> --
>> 2.7.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-05-11 11:04 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 12:18 [PATCH v7 00/14] USB OTG/dual-role framework Roger Quadros
2016-05-02 12:18 ` [PATCH v7 01/14] usb: hcd: Initialize hcd->flags to 0 Roger Quadros
[not found] ` <1462191537-10314-2-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-06 9:05 ` Peter Chen
2016-05-02 12:18 ` [PATCH v7 02/14] usb: otg-fsm: Prevent build warning "VDBG" redefined Roger Quadros
2016-05-11 8:17 ` Peter Chen
2016-05-02 12:18 ` [PATCH v7 03/14] usb: hcd.h: Add OTG to HCD interface Roger Quadros
2016-05-06 9:41 ` Peter Chen
[not found] ` <20160506094103.GF32359-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-05-09 9:45 ` Roger Quadros
[not found] ` <57305C42.90300-l0cyMroinI0@public.gmane.org>
2016-05-10 3:14 ` Peter Chen
2016-05-10 7:34 ` Roger Quadros
2016-05-10 8:03 ` Jun Li
2016-05-10 9:20 ` Roger Quadros
2016-05-11 6:19 ` Peter Chen
2016-05-10 8:12 ` Felipe Balbi
2016-05-10 9:12 ` Roger Quadros
[not found] ` <1462191537-10314-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-02 12:18 ` [PATCH v7 04/14] usb: otg-fsm: use usb_otg wherever possible Roger Quadros
2016-05-02 12:18 ` [PATCH v7 05/14] usb: otg-fsm: move host controller operations into usb_otg->hcd_ops Roger Quadros
[not found] ` <1462191537-10314-6-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-11 6:10 ` Peter Chen
[not found] ` <20160511061001.GA16910-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-05-11 11:02 ` Roger Quadros
[not found] ` <5733113D.2030009-l0cyMroinI0@public.gmane.org>
2016-05-11 12:32 ` Roger Quadros
[not found] ` <5733265E.2040105-l0cyMroinI0@public.gmane.org>
2016-05-12 8:18 ` Peter Chen
[not found] ` <20160512081843.GA23083-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-05-12 8:29 ` Roger Quadros
2016-05-02 12:18 ` [PATCH v7 06/14] usb: gadget.h: Add OTG to gadget interface Roger Quadros
2016-05-02 12:18 ` [PATCH v7 07/14] usb: otg: get rid of CONFIG_USB_OTG_FSM in favour of CONFIG_USB_OTG Roger Quadros
[not found] ` <1462191537-10314-8-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-11 8:21 ` Peter Chen
2016-05-02 12:18 ` [PATCH v7 08/14] usb: otg: add OTG/dual-role core Roger Quadros
2016-05-11 8:34 ` Peter Chen
2016-05-11 11:03 ` Roger Quadros
2016-05-02 12:18 ` [PATCH v7 09/14] usb: of: add an API to get OTG device from USB controller node Roger Quadros
[not found] ` <1462191537-10314-10-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-04 13:15 ` Rob Herring
2016-05-11 8:40 ` Peter Chen
2016-05-11 11:04 ` Roger Quadros [this message]
2016-05-02 12:18 ` [PATCH v7 10/14] usb: otg: add hcd companion support Roger Quadros
[not found] ` <1462191537-10314-11-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-04 13:17 ` Rob Herring
2016-05-04 13:47 ` Roger Quadros
2016-05-11 13:54 ` Rob Herring
2016-05-11 14:13 ` Roger Quadros
[not found] ` <57333DFF.3090609-l0cyMroinI0@public.gmane.org>
2016-05-11 14:47 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1605111043030.1882-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2016-05-12 4:00 ` Yoshihiro Shimoda
[not found] ` <SG2PR06MB09194AB523C3ABDB425285C7D8730-ESzmfEwOt/zNQ8RBPPB5A20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-05-12 8:34 ` Roger Quadros
[not found] ` <57343FFC.9090105-l0cyMroinI0@public.gmane.org>
2016-05-12 9:31 ` Roger Quadros
[not found] ` <57344D7B.3050005-l0cyMroinI0@public.gmane.org>
2016-05-12 10:31 ` Yoshihiro Shimoda
[not found] ` <SG2PR06MB091923EEBAA67EC1D1E48B6DD8730-ESzmfEwOt/zNQ8RBPPB5A20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-05-12 12:13 ` Roger Quadros
2016-05-16 2:13 ` Peter Chen
[not found] ` <20160516021350.GA24609-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-05-16 8:01 ` Roger Quadros
[not found] ` <57397E57.8060903-l0cyMroinI0@public.gmane.org>
2016-05-16 8:13 ` Peter Chen
[not found] ` <20160516081326.GC24609-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-05-16 8:35 ` Roger Quadros
2016-05-12 18:16 ` Alan Stern
2016-05-11 8:43 ` Peter Chen
2016-05-02 12:18 ` [PATCH v7 11/14] usb: otg: use dev_dbg() instead of VDBG() Roger Quadros
[not found] ` <1462191537-10314-12-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-06 9:04 ` Peter Chen
[not found] ` <20160506090425.GD32359-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-05-09 9:48 ` Roger Quadros
2016-05-11 8:43 ` Peter Chen
2016-05-02 12:18 ` [PATCH v7 13/14] usb: gadget: udc: adapt to OTG core Roger Quadros
2016-05-11 8:36 ` [PATCH v7 00/14] USB OTG/dual-role framework Peter Chen
[not found] ` <20160511083619.GF16910-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-05-11 11:05 ` Roger Quadros
2016-05-02 12:18 ` [PATCH v7 12/14] usb: hcd: Adapt to OTG core Roger Quadros
[not found] ` <1462191537-10314-13-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-05-11 8:57 ` Peter Chen
2016-05-02 12:18 ` [PATCH v7 14/14] usb: host: xhci-plat: Add otg device to platform data Roger Quadros
2016-05-11 9:00 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573311AC.8040800@ti.com \
--to=rogerq@ti.com \
--cc=Joao.Pinto@synopsys.com \
--cc=abrestic@chromium.org \
--cc=balbi@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hzpeterchen@gmail.com \
--cc=jun.li@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=peter.chen@freescale.com \
--cc=stern@rowland.harvard.edu \
--cc=tony@atomide.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).