From: Mark Brown <broonie@kernel.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
robh@kernel.org, linux-samsung-soc@vger.kernel.org,
ideal.song@samsung.com, beomho.seo@samsung.com,
inki.dae@samsung.com, k.kozlowski@samsung.com,
b.zolnierkie@samsung.com
Subject: Re: [PATCH RFC 3/6] ASoC: max98504: Add max98504 speaker amplifier driver
Date: Wed, 15 Jun 2016 10:25:27 +0100 [thread overview]
Message-ID: <20160615092527.GU2282@sirena.org.uk> (raw)
In-Reply-To: <57601A1F.5030906@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
On Tue, Jun 14, 2016 at 04:52:15PM +0200, Sylwester Nawrocki wrote:
> On 06/13/2016 05:14 PM, Mark Brown wrote:
> > Removed the regulator handling code? Why?
> Because it was effectively a dead code (disabled by a DT flag property)
> and didn't make any sense on our test board. It was setting regulator's
> load and voltage on a shared fixed voltage regulator. Even if calls like
> regulator_set_optimum_mode() were added that wouldn't make any difference,
> since the corresponding PMIC driver ops were not implemented.
> I started more or less with something like this [1].
The mode and voltage setting code there are just obviously broken but
having the get and enable is useful, even if it doesn't do anything on
your board it's nice to have them there already to avoid any transition
issues adding them later and help get more complete and accurate DTs in
from the get go.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-15 9:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 10:52 [PATCH RFC 0/6] Sound support for Exynos5433 TM2(E) boards Sylwester Nawrocki
2016-06-13 10:52 ` [PATCH RFC 1/6] ASoC: samsung: Add Samsung Low Power Audio Subsystem driver Sylwester Nawrocki
2016-06-16 11:28 ` Krzysztof Kozlowski
2016-06-13 10:52 ` [PATCH RFC 2/6] ASoC: samsung: Add DT bindings documentation for LPASS Sylwester Nawrocki
2016-06-14 23:28 ` Rob Herring
2016-06-16 16:13 ` Sylwester Nawrocki
2016-06-16 11:28 ` Krzysztof Kozlowski
2016-06-13 10:52 ` [PATCH RFC 3/6] ASoC: max98504: Add max98504 speaker amplifier driver Sylwester Nawrocki
2016-06-13 15:14 ` Mark Brown
2016-06-14 14:52 ` Sylwester Nawrocki
2016-06-15 9:25 ` Mark Brown [this message]
2016-06-16 16:17 ` Sylwester Nawrocki
2016-06-13 10:52 ` [PATCH RFC 4/6] ASoC: Add DT bindings documentation for max98504 amplifier Sylwester Nawrocki
2016-06-13 15:32 ` Mark Brown
2016-06-14 15:14 ` Sylwester Nawrocki
2016-06-15 9:25 ` Mark Brown
2016-06-16 11:31 ` Krzysztof Kozlowski
2016-06-13 10:52 ` [PATCH RFC 5/6] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board Sylwester Nawrocki
2016-06-13 10:52 ` [PATCH RFC 6/6] ASoC: samsung: Add DT bindings documentation for TM2 sound subsystem Sylwester Nawrocki
2016-06-14 23:32 ` Rob Herring
2016-06-15 9:47 ` Mark Brown
2016-06-20 17:49 ` Rob Herring
2016-06-21 9:48 ` Sylwester Nawrocki
2016-06-15 9:40 ` Lars-Peter Clausen
2016-06-16 16:39 ` [alsa-devel] " Sylwester Nawrocki
2016-06-16 16:45 ` Lars-Peter Clausen
2016-06-17 11:08 ` [alsa-devel] " Sylwester Nawrocki
2016-06-16 11:33 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615092527.GU2282@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=b.zolnierkie@samsung.com \
--cc=beomho.seo@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=ideal.song@samsung.com \
--cc=inki.dae@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).