From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
broonie@kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org
Cc: robh@kernel.org, k.kozlowski@samsung.com,
linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com,
inki.dae@samsung.com, beomho.seo@samsung.com,
ideal.song@samsung.com
Subject: Re: [alsa-devel] [PATCH RFC 6/6] ASoC: samsung: Add DT bindings documentation for TM2 sound subsystem
Date: Thu, 16 Jun 2016 18:39:46 +0200 [thread overview]
Message-ID: <5762D652.5030507@samsung.com> (raw)
In-Reply-To: <57612295.7070203@metafoo.de>
On 06/15/2016 11:40 AM, Lars-Peter Clausen wrote:
> On 06/13/2016 12:52 PM, Sylwester Nawrocki wrote:
> [...]
>> > + - compatible : "samsung,tm2-audio"
>> > + - samsung,model : the user-visible name of this sound complex
>> > + - clocks : must contain an entry for each entry in clock-names,
>> > + see ../clocks/clock-bindings.txt for details
>> > + - clock-names : must include the following entries:
>> > + "mclk1", "mclk2"
>
> If these are the MCLKs that go to the CODEC they should be properties of the
> CODEC node.
Yes, these are both CODEC clocks. I couldn't find any related clk code in
the wm5110 arizona codec driver and indeed the clocks stay disabled when
I specify them in the wm5110 DT node. AFAICS from other thread in this
mailing list it is going to take some time until the CODEC drivers are
updated. How about minimizing the requirement of those clocks, making them
optional and then when the CODEC driver gets updated specifying the clocks
in the codec node instead of the sound card one?
The MCLK1 rate could be just hard coded instead of using clk_get_rate(),
but without clk enable calls nothing works.
next prev parent reply other threads:[~2016-06-16 16:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 10:52 [PATCH RFC 0/6] Sound support for Exynos5433 TM2(E) boards Sylwester Nawrocki
2016-06-13 10:52 ` [PATCH RFC 1/6] ASoC: samsung: Add Samsung Low Power Audio Subsystem driver Sylwester Nawrocki
2016-06-16 11:28 ` Krzysztof Kozlowski
2016-06-13 10:52 ` [PATCH RFC 2/6] ASoC: samsung: Add DT bindings documentation for LPASS Sylwester Nawrocki
2016-06-14 23:28 ` Rob Herring
2016-06-16 16:13 ` Sylwester Nawrocki
2016-06-16 11:28 ` Krzysztof Kozlowski
2016-06-13 10:52 ` [PATCH RFC 3/6] ASoC: max98504: Add max98504 speaker amplifier driver Sylwester Nawrocki
2016-06-13 15:14 ` Mark Brown
2016-06-14 14:52 ` Sylwester Nawrocki
2016-06-15 9:25 ` Mark Brown
2016-06-16 16:17 ` Sylwester Nawrocki
2016-06-13 10:52 ` [PATCH RFC 4/6] ASoC: Add DT bindings documentation for max98504 amplifier Sylwester Nawrocki
2016-06-13 15:32 ` Mark Brown
2016-06-14 15:14 ` Sylwester Nawrocki
2016-06-15 9:25 ` Mark Brown
2016-06-16 11:31 ` Krzysztof Kozlowski
2016-06-13 10:52 ` [PATCH RFC 5/6] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board Sylwester Nawrocki
2016-06-13 10:52 ` [PATCH RFC 6/6] ASoC: samsung: Add DT bindings documentation for TM2 sound subsystem Sylwester Nawrocki
2016-06-14 23:32 ` Rob Herring
2016-06-15 9:47 ` Mark Brown
2016-06-20 17:49 ` Rob Herring
2016-06-21 9:48 ` Sylwester Nawrocki
2016-06-15 9:40 ` Lars-Peter Clausen
2016-06-16 16:39 ` Sylwester Nawrocki [this message]
2016-06-16 16:45 ` Lars-Peter Clausen
2016-06-17 11:08 ` [alsa-devel] " Sylwester Nawrocki
2016-06-16 11:33 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5762D652.5030507@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=b.zolnierkie@samsung.com \
--cc=beomho.seo@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ideal.song@samsung.com \
--cc=inki.dae@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).