* [PATCH 2/2] dt-bindings: phy: Add qcom,usb-hsic-phy bindings
[not found] <1466159119-20310-1-git-send-email-narmstrong@baylibre.com>
@ 2016-06-17 10:25 ` Neil Armstrong
[not found] ` <1466159119-20310-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Neil Armstrong @ 2016-06-17 10:25 UTC (permalink / raw)
To: balbi, gregkh; +Cc: Neil Armstrong, linux-kernel, linux-usb, devicetree
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
.../devicetree/bindings/phy/qcom,usb-hsic-phy.txt | 95 ++++++++++++++++++++++
1 file changed, 95 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt
diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt b/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt
new file mode 100644
index 0000000..79259a4
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt
@@ -0,0 +1,95 @@
+Qualcomm's MDM9615 USB HISC transceiver controller
+
+- compatible:
+ Usage: required
+ Value type: <string>
+ Definition: Should contain "qcom,usb-hsic-phy".
+
+- reg:
+ Usage: required
+ Value type: <prop-encoded-array>
+ Definition: USB PHY base address and length of the register map
+
+- clocks:
+ Usage: required
+ Value type: <prop-encoded-array>
+ Definition: See clock-bindings.txt section "consumers". List of
+ 5 clock specifiers for interface and core controller
+ clocks.
+
+- clock-names:
+ Usage: required
+ Value type: <string>
+ Definition: Must contain "core", "alt-core", "phy", "cal" and "iface" strings.
+
+- vddcx-supply:
+ Usage: required
+ Value type: <phandle>
+ Definition: phandle to the regulator VDCCX supply node.
+
+- resets:
+ Usage: required
+ Value type: <prop-encoded-array>
+ Definition: See reset.txt section "consumers". PHY reset specifier.
+
+- reset-names:
+ Usage: required
+ Value type: <string>
+ Definition: Must contain "link" string.
+
+- interrupts:
+ Usage: required
+ Value type: <prop-encoded-array>
+ Definition: Interrupt line definition for the PHY
+
+- dr_mode:
+ Usage: required
+ Value type: <prop-encoded-array>
+ Definition: Setup the PHY mode, either "host", "gadget" or "dual"
+
+- qcom,vdd-levels:
+ Usage: required for MDM9615
+ Value type: <prop-encoded-array>
+ Definition: Setup the valid vdd levers for the vddx-supply
+
+- phy_type:
+ Usage: required
+ Value type: <prop-encoded-array>
+ Definition: Shall be "hisc"
+
+- qcom,tlmm:
+ Usage: required for MDM961
+ Value type: <prop-encoded-array>
+ Definition: TLMM syscon phandle to setup the HSIC lines
+
+- qcom,tlmm-cfg:
+ Usage: required for MDM961
+ Value type: <prop-encoded-array>
+ Definition: Shall be two entries of offset, data of the HSIC lines setup
+
+Example:
+ usb_phy: phy@12540000 {
+ compatible = "qcom,usb-hsic-phy";
+ reg = <0x78d9000 0x400>;
+ interrupts = <GIC_SPI 232 IRQ_TYPE_NONE>;
+ dr_mode = "host";
+
+ vddcx-supply = <&pm8018_vdd_dig_corner>;
+
+ clocks = <&gcc USB_HSIC_SYSTEM_CLK>,
+ <&gcc USB_HSIC_XCVR_FS_CLK>,
+ <&gcc USB_HSIC_HSIC_CLK>,
+ <&gcc USB_HSIC_HSIO_CAL_CLK>,
+ <&gcc USB_HSIC_H_CLK>;
+ clock-names = "core", "alt-core", "phy", "cal", "iface";
+
+ resets = <&gcc USB_HSIC_RESET>;
+ reset-names = "link";
+ qcom,vdd-levels = <1 2 4>;
+ phy_type = "hsic";
+
+ qcom,tlmm = <&msmgpio>;
+ qcom,tlmm-cfg = <0x20CC 0x034A4E10
+ 0x20C8 0x034A4E10>;
+ };
+
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] dt-bindings: phy: Add qcom,usb-hsic-phy bindings
[not found] ` <1466159119-20310-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
@ 2016-06-20 16:26 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2016-06-20 16:26 UTC (permalink / raw)
To: Neil Armstrong
Cc: balbi-DgEjT+Ai2ygdnm+yROfE0A,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA
On Fri, Jun 17, 2016 at 12:25:19PM +0200, Neil Armstrong wrote:
> Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> ---
> .../devicetree/bindings/phy/qcom,usb-hsic-phy.txt | 95 ++++++++++++++++++++++
> 1 file changed, 95 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt b/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt
> new file mode 100644
> index 0000000..79259a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt
> @@ -0,0 +1,95 @@
> +Qualcomm's MDM9615 USB HISC transceiver controller
> +
> +- compatible:
> + Usage: required
> + Value type: <string>
> + Definition: Should contain "qcom,usb-hsic-phy".
SoC specific compatible string please.
> +
> +- reg:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: USB PHY base address and length of the register map
> +
> +- clocks:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: See clock-bindings.txt section "consumers". List of
> + 5 clock specifiers for interface and core controller
> + clocks.
> +
> +- clock-names:
> + Usage: required
> + Value type: <string>
> + Definition: Must contain "core", "alt-core", "phy", "cal" and "iface" strings.
> +
> +- vddcx-supply:
> + Usage: required
> + Value type: <phandle>
> + Definition: phandle to the regulator VDCCX supply node.
> +
> +- resets:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: See reset.txt section "consumers". PHY reset specifier.
> +
> +- reset-names:
> + Usage: required
> + Value type: <string>
> + Definition: Must contain "link" string.
> +
> +- interrupts:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: Interrupt line definition for the PHY
> +
> +- dr_mode:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: Setup the PHY mode, either "host", "gadget" or "dual"
> +
> +- qcom,vdd-levels:
> + Usage: required for MDM9615
> + Value type: <prop-encoded-array>
> + Definition: Setup the valid vdd levers for the vddx-supply
s/levers/levels/
There's not a common regulator property for this?
> +
> +- phy_type:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: Shall be "hisc"
typo
> +
> +- qcom,tlmm:
> + Usage: required for MDM961
s/MDM961/MDM9615/
or drop because this binding is only for MDM9615.
> + Value type: <prop-encoded-array>
> + Definition: TLMM syscon phandle to setup the HSIC lines
> +
> +- qcom,tlmm-cfg:
> + Usage: required for MDM961
s/MDM961/MDM9615/
> + Value type: <prop-encoded-array>
> + Definition: Shall be two entries of offset, data of the HSIC lines setup
This property is somewhat questionable with just magic register address
and value to write...
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-20 16:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1466159119-20310-1-git-send-email-narmstrong@baylibre.com>
2016-06-17 10:25 ` [PATCH 2/2] dt-bindings: phy: Add qcom,usb-hsic-phy bindings Neil Armstrong
[not found] ` <1466159119-20310-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-06-20 16:26 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).