From: Florian Fainelli <f.fainelli@gmail.com>
To: linux-gpio@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
ckeepax@opensource.cirrus.com, tony@atomide.com,
ckeepax@opensource.wolfsonmicro.com, swarren@nvidia.com,
andy.shevchenko@gmail.com, alcooperx@gmail.com,
bcm-kernel-feedback-list@broadcom.com
Subject: [PATCH v2 1/2] pinctrl: Allow a device to indicate when to force a state
Date: Thu, 2 Nov 2017 16:15:50 -0700 [thread overview]
Message-ID: <20171102231551.16220-2-f.fainelli@gmail.com> (raw)
In-Reply-To: <20171102231551.16220-1-f.fainelli@gmail.com>
It may happen that a device needs to force applying a state, e.g:
because it only defines one state of pin states (default) but loses
power/register contents when entering low power modes. Add a
pinctrl_dev::flags bitmask to help describe future quirks and define
PINCTRL_FLG_FORCE_STATE as such a settable flag.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/pinctrl/core.c | 14 +++++++++++++-
drivers/pinctrl/core.h | 4 ++++
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 4c8d5b23e4d0..c91359d48aa1 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -1197,9 +1197,21 @@ int pinctrl_select_state(struct pinctrl *p, struct pinctrl_state *state)
{
struct pinctrl_setting *setting, *setting2;
struct pinctrl_state *old_state = p->state;
+ bool force = false;
int ret;
- if (p->state == state)
+ if (p->state) {
+ list_for_each_entry(setting, &p->state->settings, node) {
+ if (setting->pctldev->flags & PINCTRL_FLG_FORCE_STATE)
+ force = true;
+ }
+ }
+
+ /* Some controllers may want to force this operation when they define
+ * only one set of functions and lose power state, e.g: pinctrl-single
+ * with its pinctrl-single,low-power-state-loss property.
+ */
+ if (p->state == state && !force)
return 0;
if (p->state) {
diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h
index 8cf2eba17c8c..8f900e152295 100644
--- a/drivers/pinctrl/core.h
+++ b/drivers/pinctrl/core.h
@@ -39,6 +39,7 @@ struct pinctrl_gpio_range;
* @hog_sleep: sleep state for pins hogged by this device
* @mutex: mutex taken on each pin controller specific action
* @device_root: debugfs root for this device
+ * @flags: feature/quirk flags
*/
struct pinctrl_dev {
struct list_head node;
@@ -63,8 +64,11 @@ struct pinctrl_dev {
#ifdef CONFIG_DEBUG_FS
struct dentry *device_root;
#endif
+ unsigned long flags;
};
+#define PINCTRL_FLG_FORCE_STATE (1 << 0)
+
/**
* struct pinctrl - per-device pin control state holder
* @node: global list node
--
2.9.3
next prev parent reply other threads:[~2017-11-02 23:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 23:15 [PATCH v2 0/2] pinctrl: Allow indicating loss of state across suspend/resume Florian Fainelli
2017-11-02 23:15 ` Florian Fainelli [this message]
[not found] ` <20171102231551.16220-2-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-29 13:06 ` [PATCH v2 1/2] pinctrl: Allow a device to indicate when to force a state Linus Walleij
2017-11-29 17:01 ` Tony Lindgren
2017-11-29 17:35 ` Florian Fainelli
2017-11-29 17:45 ` Tony Lindgren
2017-11-29 18:15 ` Florian Fainelli
2017-11-29 18:27 ` Tony Lindgren
2017-11-02 23:15 ` [PATCH v2 2/2] pinctrl: Allow indicating loss of pin states during low-power Florian Fainelli
2017-11-29 13:01 ` Linus Walleij
[not found] ` <CACRpkdZtFRB_iy1bDPZ0wkK0jf7pkTGtbZG4gQUJVR+eiO+dhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-29 17:02 ` Tony Lindgren
[not found] ` <20171129170247.GI28152-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-11-29 17:37 ` Florian Fainelli
[not found] ` <96cf5d74-3acf-07b9-9ad8-1011cd99a860-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-02 12:48 ` Linus Walleij
2017-12-10 23:38 ` Florian Fainelli
[not found] ` <908c66f9-f9bd-a4df-e241-75595a3a3e27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-20 7:24 ` Linus Walleij
2017-12-30 19:31 ` Florian Fainelli
[not found] ` <20171102231551.16220-1-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-03 10:37 ` [PATCH v2 0/2] pinctrl: Allow indicating loss of state across suspend/resume Charles Keepax
2017-11-03 16:11 ` Tony Lindgren
2017-11-03 17:02 ` Florian Fainelli
2017-11-03 17:33 ` Tony Lindgren
2017-11-04 8:37 ` Charles Keepax
[not found] ` <20171104083707.gtmnhbrzlqjulwe4-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-11-07 16:00 ` Tony Lindgren
[not found] ` <20171103173353.GJ28152-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-11-04 12:25 ` Rafael J. Wysocki
2017-11-04 17:19 ` Florian Fainelli
2017-11-07 16:00 ` Tony Lindgren
2017-11-08 0:23 ` Rafael J. Wysocki
2017-11-08 0:28 ` Florian Fainelli
2017-11-08 0:45 ` Rafael J. Wysocki
2017-11-08 1:04 ` Tony Lindgren
2017-11-08 1:02 ` Tony Lindgren
[not found] ` <20171103103707.3e5wb3c7foxbuvvg-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-11-03 17:03 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102231551.16220-2-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alcooperx@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@nvidia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).