[PATCH v2 0/6] Updated lp8860 led driver

[PATCH v2 0/6] Updated lp8860 led driver

[Dan Murphy]

All

v2 - Added an initial patch to bring the DT binding up to standard prior to adding
the changes for the label and triggers.

v1 Cover letter repeat below

After creating a new LED driver for the LM3692x device I went back to the
LP8860 driver that I authored and found some updates that need to be applied.

First the way the LP8860 retrieved the label from the DT was incorrect as the
label should have been from a child node as opposed to the parent.  This is now
fixed with this series.

Second, since that device can be used to as either a backlight driver or as a
string agnostic driver a trigger to the backlight needed to be added.

Finally there are changes to the driver that need to be made as either
unnoticed bugs or updates to the driver to align with the current LED
framework.  For instance moving to the devm LED class registration, destroying
the mutex upon driver removal and removing the in driver dependency on CONFIG_OF
and moving it to the Kconfig.

With these changes this should at least bring the driver into a better shape.

There are additional changes coming for this driver but I wanted to get the
driver up to snuff before adding a feature to it.


Dan

Dan Murphy (6):
  dt: bindings: lp8860: Update bindings for lp8860
  dt: bindings: lp8860: Update DT label binding
  leds: lp8860: Update the dt parsing for LED labeling
  dt: bindings: lp8860: Add trigger binding to the lp8860
  leds: lp8860: Add DT parsing to retrieve the trigger node
  leds: lp8860: Various fixes to align with LED framework

 .../devicetree/bindings/leds/leds-lp8860.txt       | 39 ++++++++++++++-------
 drivers/leds/Kconfig                               |  2 +-
 drivers/leds/leds-lp8860.c                         | 40 ++++++++++++----------
 3 files changed, 49 insertions(+), 32 deletions(-)

-- 
2.15.0.124.g7668cbc60

[PATCH v2 1/6] dt: bindings: lp8860: Update bindings for lp8860

[Dan Murphy]

Update the lp8860 bindings to fix various issues
found.  Add address-cells and size-cells, rename
enable-gpio to enable-gpios, update the node name
to the device name and indent the node example.

Signed-off-by: Dan Murphy <dmurphy-l0cyMroinI0@public.gmane.org>
---

v2 - New patch

 .../devicetree/bindings/leds/leds-lp8860.txt       | 28 ++++++++++++----------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
index aad38dd94d4b..1b2fab05ec6a 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
+++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
@@ -6,24 +6,28 @@ current sinks that can be controlled by a PWM input
 signal, a SPI/I2C master, or both.
 
 Required properties:
-	- compatible:
+	- compatible :
 		"ti,lp8860"
-	- reg -  I2C slave address
-	- label - Used for naming LEDs
+	- reg : I2C slave address
+	- label : Used for naming LEDs
+	- #address-cells : 1
+	- #size-cells : 0
 
 Optional properties:
-	- enable-gpio - gpio pin to enable/disable the device.
-	- supply - "vled" - LED supply
+	- enable-gpios : gpio pin to enable/disable the device.
+	- supply : "vled" - LED supply
 
 Example:
 
-leds: leds@6 {
-	compatible = "ti,lp8860";
-	reg = <0x2d>;
-	label = "display_cluster";
-	enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
-	vled-supply = <&vbatt>;
-}
+	lp8860@2d {
+		compatible = "ti,lp8860";
+		#address-cells: 1
+		#size-cells: 0
+		reg = <0x2d>;
+		label = "display_cluster";
+		enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+		vled-supply = <&vbatt>;
+	}
 
 For more product information please see the link below:
 http://www.ti.com/product/lp8860-q1
-- 
2.15.0.124.g7668cbc60

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/6] dt: bindings: lp8860: Update DT label binding

[Dan Murphy]

Update the lp8860 label binding to the LED
standard as documented in

Documentation/devicetree/bindings/leds/common.txt

Signed-off-by: Dan Murphy <dmurphy-l0cyMroinI0@public.gmane.org>
---

v2 - Added reg to child node and made it required

 Documentation/devicetree/bindings/leds/leds-lp8860.txt | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
index 1b2fab05ec6a..22b594d95162 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
+++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
@@ -9,7 +9,6 @@ Required properties:
 	- compatible :
 		"ti,lp8860"
 	- reg : I2C slave address
-	- label : Used for naming LEDs
 	- #address-cells : 1
 	- #size-cells : 0
 
@@ -17,6 +16,12 @@ Optional properties:
 	- enable-gpios : gpio pin to enable/disable the device.
 	- supply : "vled" - LED supply
 
+Required child properties:
+	- reg : 0
+
+Optional child properties:
+	- label : see Documentation/devicetree/bindings/leds/common.txt
+
 Example:
 
 	lp8860@2d {
@@ -24,9 +29,12 @@ Example:
 		#address-cells: 1
 		#size-cells: 0
 		reg = <0x2d>;
-		label = "display_cluster";
 		enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
 		vled-supply = <&vbatt>;
+		display_cluster: display_cluster@0 {
+			reg=<0>;
+			label = "display_cluster";
+		};
 	}
 
 For more product information please see the link below:
-- 
2.15.0.124.g7668cbc60

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 3/6] leds: lp8860: Update the dt parsing for LED labeling

[Dan Murphy]

Update the DT parsing for the label node so that
the label is retrieved from the device child as
opposed to being part of the parent.

This will align this driver with the LED
binding documentation

Documentation/devicetree/bindings/leds/common.txt

Signed-off-by: Dan Murphy <dmurphy@ti.com>
---

v2 - no changes

 drivers/leds/leds-lp8860.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c
index 3e70775a2d54..13d6210cba85 100644
--- a/drivers/leds/leds-lp8860.c
+++ b/drivers/leds/leds-lp8860.c
@@ -22,6 +22,7 @@
 #include <linux/of_gpio.h>
 #include <linux/gpio/consumer.h>
 #include <linux/slab.h>
+#include <uapi/linux/uleds.h>
 
 #define LP8860_DISP_CL1_BRT_MSB		0x00
 #define LP8860_DISP_CL1_BRT_LSB		0x01
@@ -86,8 +87,6 @@
 
 #define LP8860_CLEAR_FAULTS		0x01
 
-#define LP8860_DISP_LED_NAME		"display_cluster"
-
 /**
  * struct lp8860_led -
  * @lock - Lock for reading/writing the device
@@ -107,7 +106,7 @@ struct lp8860_led {
 	struct regmap *eeprom_regmap;
 	struct gpio_desc *enable_gpio;
 	struct regulator *regulator;
-	const char *label;
+	char label[LED_MAX_NAME_SIZE];
 };
 
 struct lp8860_eeprom_reg {
@@ -365,19 +364,21 @@ static int lp8860_probe(struct i2c_client *client,
 	int ret;
 	struct lp8860_led *led;
 	struct device_node *np = client->dev.of_node;
+	struct device_node *child_node;
+	const char *name;
 
 	led = devm_kzalloc(&client->dev, sizeof(*led), GFP_KERNEL);
 	if (!led)
 		return -ENOMEM;
 
-	led->label = LP8860_DISP_LED_NAME;
-
-	if (client->dev.of_node) {
-		ret = of_property_read_string(np, "label", &led->label);
-		if (ret) {
-			dev_err(&client->dev, "Missing label in dt\n");
-			return -EINVAL;
-		}
+	for_each_available_child_of_node(np, child_node) {
+		ret = of_property_read_string(child_node, "label", &name);
+		if (!ret)
+		    snprintf(led->label, sizeof(led->label), "%s:%s",
+					np->name, name);
+		else
+		    snprintf(led->label, sizeof(led->label),
+			     "%s::display_cluster", np->name);
 	}
 
 	led->enable_gpio = devm_gpiod_get_optional(&client->dev,
-- 
2.15.0.124.g7668cbc60

[PATCH v2 4/6] dt: bindings: lp8860: Add trigger binding to the lp8860

[Dan Murphy]

Add a default trigger optional node to the child node.
This will allow the driver to set the trigger for a backlight.

Signed-off-by: Dan Murphy <dmurphy-l0cyMroinI0@public.gmane.org>
---

v2 - Moved binding changes to first patch in the series.

 Documentation/devicetree/bindings/leds/leds-lp8860.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
index 22b594d95162..3452c9c10499 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
+++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
@@ -21,6 +21,8 @@ Required child properties:
 
 Optional child properties:
 	- label : see Documentation/devicetree/bindings/leds/common.txt
+	- linux,default-trigger : (optional)
+	   see Documentation/devicetree/bindings/leds/common.txt
 
 Example:
 
@@ -34,6 +36,7 @@ Example:
 		display_cluster: display_cluster@0 {
 			reg=<0>;
 			label = "display_cluster";
+			linux,default-trigger = "backlight";
 		};
 	}
 
-- 
2.15.0.124.g7668cbc60

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 5/6] leds: lp8860: Add DT parsing to retrieve the trigger node

[Dan Murphy]

Add the ability to parse the DT and set the default
trigger mode for the LED.

Signed-off-by: Dan Murphy <dmurphy@ti.com>
---

v2 - no changes

 drivers/leds/leds-lp8860.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c
index 13d6210cba85..4fed603ee728 100644
--- a/drivers/leds/leds-lp8860.c
+++ b/drivers/leds/leds-lp8860.c
@@ -372,6 +372,10 @@ static int lp8860_probe(struct i2c_client *client,
 		return -ENOMEM;
 
 	for_each_available_child_of_node(np, child_node) {
+		led->led_dev.default_trigger = of_get_property(child_node,
+						    "linux,default-trigger",
+						    NULL);
+
 		ret = of_property_read_string(child_node, "label", &name);
 		if (!ret)
 		    snprintf(led->label, sizeof(led->label), "%s:%s",
-- 
2.15.0.124.g7668cbc60

[PATCH v2 6/6] leds: lp8860: Various fixes to align with LED framework

[Dan Murphy]

Update the driver to conform with the LED framework.
Use devm_led_classdev_register
Destroy mutex on exit
Remove dependency on CONFIG_OF in the driver and move
to the Kconfig
Update the MODULE_LICENSE to GPL v2
Remove setting of MAX brightness as the LED framework
does this.

Signed-off-by: Dan Murphy <dmurphy@ti.com>
---

v2 - no changes

 drivers/leds/Kconfig       |  2 +-
 drivers/leds/leds-lp8860.c | 13 +++++--------
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 318a28fd58fe..ac4d9d8bf96b 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -347,7 +347,7 @@ config LEDS_LP8788
 
 config LEDS_LP8860
 	tristate "LED support for the TI LP8860 4 channel LED driver"
-	depends on LEDS_CLASS && I2C
+	depends on LEDS_CLASS && I2C && OF
 	select REGMAP_I2C
 	help
 	  If you say yes here you get support for the TI LP8860 4 channel
diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c
index 4fed603ee728..e94041e0e693 100644
--- a/drivers/leds/leds-lp8860.c
+++ b/drivers/leds/leds-lp8860.c
@@ -399,7 +399,6 @@ static int lp8860_probe(struct i2c_client *client,
 
 	led->client = client;
 	led->led_dev.name = led->label;
-	led->led_dev.max_brightness = LED_FULL;
 	led->led_dev.brightness_set_blocking = lp8860_brightness_set;
 
 	mutex_init(&led->lock);
@@ -426,7 +425,7 @@ static int lp8860_probe(struct i2c_client *client,
 	if (ret)
 		return ret;
 
-	ret = led_classdev_register(&client->dev, &led->led_dev);
+	ret = devm_led_classdev_register(&client->dev, &led->led_dev);
 	if (ret) {
 		dev_err(&client->dev, "led register err: %d\n", ret);
 		return ret;
@@ -440,8 +439,6 @@ static int lp8860_remove(struct i2c_client *client)
 	struct lp8860_led *led = i2c_get_clientdata(client);
 	int ret;
 
-	led_classdev_unregister(&led->led_dev);
-
 	if (led->enable_gpio)
 		gpiod_direction_output(led->enable_gpio, 0);
 
@@ -452,6 +449,8 @@ static int lp8860_remove(struct i2c_client *client)
 				"Failed to disable regulator\n");
 	}
 
+	mutex_destroy(&led->lock);
+
 	return 0;
 }
 
@@ -461,18 +460,16 @@ static const struct i2c_device_id lp8860_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, lp8860_id);
 
-#ifdef CONFIG_OF
 static const struct of_device_id of_lp8860_leds_match[] = {
 	{ .compatible = "ti,lp8860", },
 	{},
 };
 MODULE_DEVICE_TABLE(of, of_lp8860_leds_match);
-#endif
 
 static struct i2c_driver lp8860_driver = {
 	.driver = {
 		.name	= "lp8860",
-		.of_match_table = of_match_ptr(of_lp8860_leds_match),
+		.of_match_table = of_lp8860_leds_match,
 	},
 	.probe		= lp8860_probe,
 	.remove		= lp8860_remove,
@@ -482,4 +479,4 @@ module_i2c_driver(lp8860_driver);
 
 MODULE_DESCRIPTION("Texas Instruments LP8860 LED driver");
 MODULE_AUTHOR("Dan Murphy <dmurphy@ti.com>");
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");
-- 
2.15.0.124.g7668cbc60

Re: [PATCH v2 1/6] dt: bindings: lp8860: Update bindings for lp8860

[Rob Herring]

gOn Tue, Dec 05, 2017 at 02:43:22PM -0600, Dan Murphy wrote:
> Update the lp8860 bindings to fix various issues
> found.  Add address-cells and size-cells, rename
> enable-gpio to enable-gpios, update the node name
> to the device name and indent the node example.
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> 
> v2 - New patch
> 
>  .../devicetree/bindings/leds/leds-lp8860.txt       | 28 ++++++++++++----------
>  1 file changed, 16 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> index aad38dd94d4b..1b2fab05ec6a 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> @@ -6,24 +6,28 @@ current sinks that can be controlled by a PWM input
>  signal, a SPI/I2C master, or both.
>  
>  Required properties:
> -	- compatible:
> +	- compatible :
>  		"ti,lp8860"
> -	- reg -  I2C slave address
> -	- label - Used for naming LEDs
> +	- reg : I2C slave address
> +	- label : Used for naming LEDs
> +	- #address-cells : 1
> +	- #size-cells : 0
>  
>  Optional properties:
> -	- enable-gpio - gpio pin to enable/disable the device.
> -	- supply - "vled" - LED supply
> +	- enable-gpios : gpio pin to enable/disable the device.

Needs to state active high or low.

> +	- supply : "vled" - LED supply

"vled-supply : ..."

>  
>  Example:
>  
> -leds: leds@6 {
> -	compatible = "ti,lp8860";
> -	reg = <0x2d>;
> -	label = "display_cluster";
> -	enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> -	vled-supply = <&vbatt>;
> -}
> +	lp8860@2d {

leds@2d

There's not really any point in adding the indentation.

> +		compatible = "ti,lp8860";

> +		#address-cells: 1
> +		#size-cells: 0

s/:/=/

Though, these aren't necessary without any child nodes. Is there more 
than 1 LED channel/driver?

> +		reg = <0x2d>;
> +		label = "display_cluster";
> +		enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> +		vled-supply = <&vbatt>;
> +	}
>  
>  For more product information please see the link below:
>  http://www.ti.com/product/lp8860-q1
> -- 
> 2.15.0.124.g7668cbc60
> 

Re: [PATCH v2 1/6] dt: bindings: lp8860: Update bindings for lp8860

[Rob Herring]

On Tue, Dec 05, 2017 at 02:43:22PM -0600, Dan Murphy wrote:
> Update the lp8860 bindings to fix various issues
> found.  Add address-cells and size-cells, rename
> enable-gpio to enable-gpios, update the node name
> to the device name and indent the node example.
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> 
> v2 - New patch
> 
>  .../devicetree/bindings/leds/leds-lp8860.txt       | 28 ++++++++++++----------
>  1 file changed, 16 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> index aad38dd94d4b..1b2fab05ec6a 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> @@ -6,24 +6,28 @@ current sinks that can be controlled by a PWM input
>  signal, a SPI/I2C master, or both.
>  
>  Required properties:
> -	- compatible:
> +	- compatible :
>  		"ti,lp8860"
> -	- reg -  I2C slave address
> -	- label - Used for naming LEDs
> +	- reg : I2C slave address
> +	- label : Used for naming LEDs
> +	- #address-cells : 1
> +	- #size-cells : 0

This should be added in the next patch when you have child nodes.

Rob

Re: [PATCH v2 2/6] dt: bindings: lp8860: Update DT label binding

[Rob Herring]

On Tue, Dec 05, 2017 at 02:43:23PM -0600, Dan Murphy wrote:
> Update the lp8860 label binding to the LED
> standard as documented in
> 
> Documentation/devicetree/bindings/leds/common.txt
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> 
> v2 - Added reg to child node and made it required
> 
>  Documentation/devicetree/bindings/leds/leds-lp8860.txt | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> index 1b2fab05ec6a..22b594d95162 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> @@ -9,7 +9,6 @@ Required properties:
>  	- compatible :
>  		"ti,lp8860"
>  	- reg : I2C slave address
> -	- label : Used for naming LEDs
>  	- #address-cells : 1
>  	- #size-cells : 0
>  
> @@ -17,6 +16,12 @@ Optional properties:
>  	- enable-gpios : gpio pin to enable/disable the device.
>  	- supply : "vled" - LED supply
>  
> +Required child properties:
> +	- reg : 0
> +
> +Optional child properties:
> +	- label : see Documentation/devicetree/bindings/leds/common.txt
> +
>  Example:
>  
>  	lp8860@2d {
> @@ -24,9 +29,12 @@ Example:
>  		#address-cells: 1
>  		#size-cells: 0
>  		reg = <0x2d>;
> -		label = "display_cluster";
>  		enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>  		vled-supply = <&vbatt>;
> +		display_cluster: display_cluster@0 {

led@0 {

Do you really need a (dts) label here?

> +			reg=<0>;

spaces around the '='.

> +			label = "display_cluster";
> +		};
>  	}
>  
>  For more product information please see the link below:
> -- 
> 2.15.0.124.g7668cbc60
> 

Re: [PATCH v2 4/6] dt: bindings: lp8860: Add trigger binding to the lp8860

[Rob Herring]

On Tue, Dec 05, 2017 at 02:43:25PM -0600, Dan Murphy wrote:
> Add a default trigger optional node to the child node.
> This will allow the driver to set the trigger for a backlight.
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> 
> v2 - Moved binding changes to first patch in the series.
> 
>  Documentation/devicetree/bindings/leds/leds-lp8860.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> index 22b594d95162..3452c9c10499 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> @@ -21,6 +21,8 @@ Required child properties:
>  
>  Optional child properties:
>  	- label : see Documentation/devicetree/bindings/leds/common.txt
> +	- linux,default-trigger : (optional)

You already said this is optional.

> +	   see Documentation/devicetree/bindings/leds/common.txt
>  
>  Example:
>  
> @@ -34,6 +36,7 @@ Example:
>  		display_cluster: display_cluster@0 {
>  			reg=<0>;
>  			label = "display_cluster";
> +			linux,default-trigger = "backlight";
>  		};
>  	}
>  
> -- 
> 2.15.0.124.g7668cbc60
> 

Re: [PATCH v2 1/6] dt: bindings: lp8860: Update bindings for lp8860

[Dan Murphy]

Rob

Thanks

On 12/07/2017 04:42 PM, Rob Herring wrote:
> gOn Tue, Dec 05, 2017 at 02:43:22PM -0600, Dan Murphy wrote:
>> Update the lp8860 bindings to fix various issues
>> found.  Add address-cells and size-cells, rename
>> enable-gpio to enable-gpios, update the node name
>> to the device name and indent the node example.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>
>> v2 - New patch
>>
>>  .../devicetree/bindings/leds/leds-lp8860.txt       | 28 ++++++++++++----------
>>  1 file changed, 16 insertions(+), 12 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> index aad38dd94d4b..1b2fab05ec6a 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> @@ -6,24 +6,28 @@ current sinks that can be controlled by a PWM input
>>  signal, a SPI/I2C master, or both.
>>  
>>  Required properties:
>> -	- compatible:
>> +	- compatible :
>>  		"ti,lp8860"
>> -	- reg -  I2C slave address
>> -	- label - Used for naming LEDs
>> +	- reg : I2C slave address
>> +	- label : Used for naming LEDs
>> +	- #address-cells : 1
>> +	- #size-cells : 0
>>  
>>  Optional properties:
>> -	- enable-gpio - gpio pin to enable/disable the device.
>> -	- supply - "vled" - LED supply
>> +	- enable-gpios : gpio pin to enable/disable the device.
> 
> Needs to state active high or low.

Ack

> 
>> +	- supply : "vled" - LED supply
> 
> "vled-supply : ..."
> 

Ack

>>  
>>  Example:
>>  
>> -leds: leds@6 {
>> -	compatible = "ti,lp8860";
>> -	reg = <0x2d>;
>> -	label = "display_cluster";
>> -	enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>> -	vled-supply = <&vbatt>;
>> -}
>> +	lp8860@2d {
> 
> leds@2d
> 
> There's not really any point in adding the indentation.

OK I was just following convention of other child node LED bindings

I can remove the indents.

> 
>> +		compatible = "ti,lp8860";
> 
>> +		#address-cells: 1
>> +		#size-cells: 0
> 
> s/:/=/
> 
> Though, these aren't necessary without any child nodes. Is there more 
> than 1 LED channel/driver?
> 

Yes this device can be used to drive at least 4 different LED strings as well
I will be adding this feature once I get this driver and binding cleaned up.

Dan

>> +		reg = <0x2d>;
>> +		label = "display_cluster";
>> +		enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>> +		vled-supply = <&vbatt>;
>> +	}
>>  
>>  For more product information please see the link below:
>>  http://www.ti.com/product/lp8860-q1
>> -- 
>> 2.15.0.124.g7668cbc60
>>


-- 
------------------
Dan Murphy

Re: [PATCH v2 1/6] dt: bindings: lp8860: Update bindings for lp8860

[Dan Murphy]

Rob
On 12/07/2017 04:43 PM, Rob Herring wrote:
> On Tue, Dec 05, 2017 at 02:43:22PM -0600, Dan Murphy wrote:
>> Update the lp8860 bindings to fix various issues
>> found.  Add address-cells and size-cells, rename
>> enable-gpio to enable-gpios, update the node name
>> to the device name and indent the node example.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>
>> v2 - New patch
>>
>>  .../devicetree/bindings/leds/leds-lp8860.txt       | 28 ++++++++++++----------
>>  1 file changed, 16 insertions(+), 12 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> index aad38dd94d4b..1b2fab05ec6a 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> @@ -6,24 +6,28 @@ current sinks that can be controlled by a PWM input
>>  signal, a SPI/I2C master, or both.
>>  
>>  Required properties:
>> -	- compatible:
>> +	- compatible :
>>  		"ti,lp8860"
>> -	- reg -  I2C slave address
>> -	- label - Used for naming LEDs
>> +	- reg : I2C slave address
>> +	- label : Used for naming LEDs
>> +	- #address-cells : 1
>> +	- #size-cells : 0
> 
> This should be added in the next patch when you have child nodes.
> 

Ack

> Rob
> 


-- 
------------------
Dan Murphy

Re: [PATCH v2 2/6] dt: bindings: lp8860: Update DT label binding

[Dan Murphy]

Rob

On 12/07/2017 04:45 PM, Rob Herring wrote:
> On Tue, Dec 05, 2017 at 02:43:23PM -0600, Dan Murphy wrote:
>> Update the lp8860 label binding to the LED
>> standard as documented in
>>
>> Documentation/devicetree/bindings/leds/common.txt
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>
>> v2 - Added reg to child node and made it required
>>
>>  Documentation/devicetree/bindings/leds/leds-lp8860.txt | 12 ++++++++++--
>>  1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> index 1b2fab05ec6a..22b594d95162 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> @@ -9,7 +9,6 @@ Required properties:
>>  	- compatible :
>>  		"ti,lp8860"
>>  	- reg : I2C slave address
>> -	- label : Used for naming LEDs
>>  	- #address-cells : 1
>>  	- #size-cells : 0
>>  
>> @@ -17,6 +16,12 @@ Optional properties:
>>  	- enable-gpios : gpio pin to enable/disable the device.
>>  	- supply : "vled" - LED supply
>>  
>> +Required child properties:
>> +	- reg : 0
>> +
>> +Optional child properties:
>> +	- label : see Documentation/devicetree/bindings/leds/common.txt
>> +
>>  Example:
>>  
>>  	lp8860@2d {
>> @@ -24,9 +29,12 @@ Example:
>>  		#address-cells: 1
>>  		#size-cells: 0
>>  		reg = <0x2d>;
>> -		label = "display_cluster";
>>  		enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>>  		vled-supply = <&vbatt>;
>> +		display_cluster: display_cluster@0 {
> 
> led@0 {
> 
> Do you really need a (dts) label here?

We will when I add LED string support.

> 
>> +			reg=<0>;
> 
> spaces around the '='.

Ack

> 
>> +			label = "display_cluster";
>> +		};
>>  	}
>>  
>>  For more product information please see the link below:
>> -- 
>> 2.15.0.124.g7668cbc60
>>


-- 
------------------
Dan Murphy