* [PATCH] arm64: allwinner: a64: a64-olinuxino: add usb otg @ 2017-12-12 5:56 Jagan Teki [not found] ` <1513058169-25516-1-git-send-email-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Jagan Teki @ 2017-12-12 5:56 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Icenowy Zheng, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Michael Trimarchi, linux-arm-kernel, devicetree, linux-kernel, linux-sunxi, Jagan Teki Add usb otg support for a64-olinuxino board, - USB0-ID connected with PH9 - USB0-VBUSDET connected with PH6 - USB-DRVVBUS controlled by N_VBUSEN pin from PMIC Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- .../boot/dts/allwinner/sun50i-a64-olinuxino.dts | 26 ++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts index 338e7861..f9bc6c3 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts @@ -59,6 +59,10 @@ }; }; +&ehci0 { + status = "okay"; +}; + &mmc0 { pinctrl-names = "default"; pinctrl-0 = <&mmc0_pins>; @@ -70,6 +74,10 @@ status = "okay"; }; +&ohci0 { + status = "okay"; +}; + &r_rsb { status = "okay"; @@ -78,6 +86,7 @@ reg = <0x3a3>; interrupt-parent = <&r_intc>; interrupts = <0 IRQ_TYPE_LEVEL_LOW>; + x-powers,drive-vbus-en; /* set N_VBUSEN as output pin */ }; }; @@ -192,8 +201,25 @@ regulator-name = "vcc-rtc"; }; +®_drivevbus { + regulator-name = "usb0-vbus"; + status = "okay"; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pins_a>; status = "okay"; }; + +&usb_otg { + dr_mode = "otg"; + status = "okay"; +}; + +&usbphy { + usb0_id_det-gpios = <&pio 7 9 GPIO_ACTIVE_HIGH>; /* PH9 */ + usb0_vbus_det-gpio = <&pio 7 6 GPIO_ACTIVE_HIGH>; /* PH6 */ + usb0_vbus-supply = <®_drivevbus>; + status = "okay"; +}; -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
[parent not found: <1513058169-25516-1-git-send-email-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>]
* Re: [PATCH] arm64: allwinner: a64: a64-olinuxino: add usb otg [not found] ` <1513058169-25516-1-git-send-email-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> @ 2017-12-12 8:13 ` Maxime Ripard 2017-12-12 9:27 ` Jagan Teki 2017-12-15 3:56 ` kbuild test robot 1 sibling, 1 reply; 5+ messages in thread From: Maxime Ripard @ 2017-12-12 8:13 UTC (permalink / raw) To: Jagan Teki Cc: Chen-Yu Tsai, Icenowy Zheng, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Michael Trimarchi, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw [-- Attachment #1: Type: text/plain, Size: 505 bytes --] Hi, On Tue, Dec 12, 2017 at 11:26:09AM +0530, Jagan Teki wrote: > Add usb otg support for a64-olinuxino board, > - USB0-ID connected with PH9 > - USB0-VBUSDET connected with PH6 > - USB-DRVVBUS controlled by N_VBUSEN pin from PMIC > > Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> How was this tested? Did you test the OTG part, or only the peripheral part? Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: allwinner: a64: a64-olinuxino: add usb otg 2017-12-12 8:13 ` Maxime Ripard @ 2017-12-12 9:27 ` Jagan Teki [not found] ` <CAMty3ZDEhXjHTE4WsJK8=yAayuR=qvJQaZEjGq=LDS6Y4V7RFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Jagan Teki @ 2017-12-12 9:27 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Icenowy Zheng, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Michael Trimarchi, linux-arm-kernel, devicetree, linux-kernel, linux-sunxi On Tue, Dec 12, 2017 at 1:43 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Tue, Dec 12, 2017 at 11:26:09AM +0530, Jagan Teki wrote: >> Add usb otg support for a64-olinuxino board, >> - USB0-ID connected with PH9 >> - USB0-VBUSDET connected with PH6 >> - USB-DRVVBUS controlled by N_VBUSEN pin from PMIC >> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > How was this tested? Did you test the OTG part, or only the peripheral > part? Yes peripheral. ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CAMty3ZDEhXjHTE4WsJK8=yAayuR=qvJQaZEjGq=LDS6Y4V7RFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] arm64: allwinner: a64: a64-olinuxino: add usb otg [not found] ` <CAMty3ZDEhXjHTE4WsJK8=yAayuR=qvJQaZEjGq=LDS6Y4V7RFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2017-12-13 10:42 ` Maxime Ripard 0 siblings, 0 replies; 5+ messages in thread From: Maxime Ripard @ 2017-12-13 10:42 UTC (permalink / raw) To: Jagan Teki Cc: Chen-Yu Tsai, Icenowy Zheng, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Michael Trimarchi, linux-arm-kernel, devicetree, linux-kernel, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 869 bytes --] On Tue, Dec 12, 2017 at 02:57:01PM +0530, Jagan Teki wrote: > On Tue, Dec 12, 2017 at 1:43 PM, Maxime Ripard > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > > Hi, > > > > On Tue, Dec 12, 2017 at 11:26:09AM +0530, Jagan Teki wrote: > >> Add usb otg support for a64-olinuxino board, > >> - USB0-ID connected with PH9 > >> - USB0-VBUSDET connected with PH6 > >> - USB-DRVVBUS controlled by N_VBUSEN pin from PMIC > >> > >> Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> > > > > How was this tested? Did you test the OTG part, or only the peripheral > > part? > > Yes peripheral. Please test the switching between host and peripheral then, and the same comment applies to your bananapi-m64. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: allwinner: a64: a64-olinuxino: add usb otg [not found] ` <1513058169-25516-1-git-send-email-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2017-12-12 8:13 ` Maxime Ripard @ 2017-12-15 3:56 ` kbuild test robot 1 sibling, 0 replies; 5+ messages in thread From: kbuild test robot @ 2017-12-15 3:56 UTC (permalink / raw) Cc: kbuild-all-JC7UmRfGjtg, Maxime Ripard, Chen-Yu Tsai, Icenowy Zheng, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Michael Trimarchi, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Jagan Teki [-- Attachment #1: Type: text/plain, Size: 1176 bytes --] Hi Jagan, Thank you for the patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on v4.15-rc3] [cannot apply to next-20171214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jagan-Teki/arm64-allwinner-a64-a64-olinuxino-add-usb-otg/20171215-084728 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: arm64-defconfig (attached as .config) compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm64 All errors (new ones prefixed by >>): >> Error: arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts:204.1-15 Label or path reg_drivevbus not found >> FATAL ERROR: Syntax error parsing input tree --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 37312 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-15 3:56 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-12-12 5:56 [PATCH] arm64: allwinner: a64: a64-olinuxino: add usb otg Jagan Teki [not found] ` <1513058169-25516-1-git-send-email-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2017-12-12 8:13 ` Maxime Ripard 2017-12-12 9:27 ` Jagan Teki [not found] ` <CAMty3ZDEhXjHTE4WsJK8=yAayuR=qvJQaZEjGq=LDS6Y4V7RFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-12-13 10:42 ` Maxime Ripard 2017-12-15 3:56 ` kbuild test robot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).