From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Chris Lew <clew@codeaurora.org>,
andy.gross@linaro.org, david.brown@linaro.org,
aneela@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings
Date: Wed, 20 Dec 2017 17:35:57 -0800 [thread overview]
Message-ID: <20171221013557.GE12655@minitux> (raw)
In-Reply-To: <20171220183000.rhxgyikfqzxmqkjo@rob-hp-laptop>
On Wed 20 Dec 10:30 PST 2017, Rob Herring wrote:
> On Mon, Dec 18, 2017 at 02:02:09PM -0800, Chris Lew wrote:
> > Add a label property to identify the edge this node represents.
>
> Why does a user need to know this?
>
We have multiple remoteproc instances, each one having one or more
associated SMD or GLINK links (this node), exposing logical
communication channels. Some of these logical channels are exposed to
user space and we need a way to distinguish them there.
In the current implementation of SMD this value goes straight into an
sysfs attribute that we can use when writing udev rules and for the DIAG
implementation to pair up channels related to the same remoteproc. This
adds the equivalent information for glink-backed channels.
I'm therefor in favor of picking this patch.
Regards,
Bjorn
> >
> > Signed-off-by: Chris Lew <clew@codeaurora.org>
> > ---
> > Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt
> > index 9663cab52246..0b8cc533ca83 100644
> > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt
> > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt
> > @@ -10,6 +10,11 @@ edge.
> > Value type: <stringlist>
> > Definition: must be "qcom,glink-rpm"
> >
> > +- label:
> > + Usage: optional
> > + Value type: <string>
> > + Definition: should specify the subsystem name this edge corresponds to.
> > +
> > - interrupts:
> > Usage: required
> > Value type: <prop-encoded-array>
> > --
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> >
next prev parent reply other threads:[~2017-12-21 1:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 22:02 [PATCH 0/6] Add chrdev and name query support for GLINK Chris Lew
2017-12-18 22:02 ` [PATCH 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings Chris Lew
2017-12-20 18:30 ` Rob Herring
2017-12-21 1:35 ` Bjorn Andersson [this message]
2017-12-21 19:36 ` Stephen Boyd
2018-01-09 19:11 ` Chris Lew
2017-12-21 22:39 ` Rob Herring
2017-12-22 22:28 ` Bjorn Andersson
2017-12-18 22:02 ` [PATCH 2/6] rpmsg: glink: Store edge name for glink device Chris Lew
2017-12-19 17:52 ` Bjorn Andersson
2017-12-18 22:02 ` [PATCH 3/6] rpmsg: glink: Add support for rpmsg glink chrdev Chris Lew
[not found] ` <1513634534-22861-4-git-send-email-clew-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-15 18:28 ` Bjorn Andersson
2017-12-18 22:02 ` [PATCH 4/6] rpmsg: glink: Expose rpmsg name attr for glink Chris Lew
[not found] ` <1513634534-22861-5-git-send-email-clew-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-12-18 22:48 ` Stephen Boyd
[not found] ` <1d29f603-b113-9931-d7b6-980c959b8b6b-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-01-09 18:44 ` Chris Lew
[not found] ` <1513634534-22861-1-git-send-email-clew-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-12-18 22:02 ` [PATCH 5/6] rpmsg: Introduce rpmsg_get_rproc_name Chris Lew
2017-12-19 17:52 ` Bjorn Andersson
2018-01-09 19:08 ` Chris Lew
2017-12-18 22:02 ` [PATCH 6/6] rpmsg: glink: Add get_rproc_name device op Chris Lew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221013557.GE12655@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=aneela@codeaurora.org \
--cc=clew@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).