devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Chris Lew <clew@codeaurora.org>,
	andy.gross@linaro.org, david.brown@linaro.org,
	aneela@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org, linux-soc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings
Date: Fri, 22 Dec 2017 14:28:31 -0800	[thread overview]
Message-ID: <20171222222831.GF478@tuxbook> (raw)
In-Reply-To: <20171220183000.rhxgyikfqzxmqkjo@rob-hp-laptop>

On Wed 20 Dec 10:30 PST 2017, Rob Herring wrote:

> On Mon, Dec 18, 2017 at 02:02:09PM -0800, Chris Lew wrote:
> > Add a label property to identify the edge this node represents.
> 
> Why does a user need to know this?
> 

Each SMD or GLINK edge will expose a dev node as /dev/rpmsg_ctrlX that
can be used create dev nodes for channels that user space wants to
access directly (without a specific kernel driver).

The problem is that there's currently nothing in the device hierarchy
that identifies which edge, and hence remoteproc, these channels are
associated with.

So for SMD I added the ability to specify a "label" on the SMD edge,
which is propagated in sysfs and allows me to write udev rules creating
symlinks based on the edge name (e.g. /dev/modem/DIAG vs /dev/rpmsg4)
and it also allows user space tools to figure out which channels comes
from the same edge/remoteproc (e.g. which DIAG control channel is
related to which DIAG data channel).

This patch attempts to add the equivalent property on GLINK edges.


As SMD and GLINK edges can exist without a parent remoteproc (e.g. for
the always-on subsystems) and it's possible for a single remoteproc to
have multiple edges, it's inadequate to put this label on the
remoteproc.


PS. Downstream solutions of remoteproc + virtio-rpmsg has "solved" this
problem by using aliases for remoteprocs and then only allow one
virtio-rpmsg node per remoteproc, to get deterministic identification of
channels.

Regards,
Bjorn

  parent reply	other threads:[~2017-12-22 22:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-18 22:02 [PATCH 0/6] Add chrdev and name query support for GLINK Chris Lew
2017-12-18 22:02 ` [PATCH 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings Chris Lew
2017-12-20 18:30   ` Rob Herring
2017-12-21  1:35     ` Bjorn Andersson
2017-12-21 19:36       ` Stephen Boyd
2018-01-09 19:11         ` Chris Lew
2017-12-21 22:39       ` Rob Herring
2017-12-22 22:28     ` Bjorn Andersson [this message]
2017-12-18 22:02 ` [PATCH 2/6] rpmsg: glink: Store edge name for glink device Chris Lew
2017-12-19 17:52   ` Bjorn Andersson
2017-12-18 22:02 ` [PATCH 3/6] rpmsg: glink: Add support for rpmsg glink chrdev Chris Lew
     [not found]   ` <1513634534-22861-4-git-send-email-clew-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-15 18:28     ` Bjorn Andersson
2017-12-18 22:02 ` [PATCH 4/6] rpmsg: glink: Expose rpmsg name attr for glink Chris Lew
     [not found]   ` <1513634534-22861-5-git-send-email-clew-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-12-18 22:48     ` Stephen Boyd
     [not found]       ` <1d29f603-b113-9931-d7b6-980c959b8b6b-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-01-09 18:44         ` Chris Lew
     [not found] ` <1513634534-22861-1-git-send-email-clew-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-12-18 22:02   ` [PATCH 5/6] rpmsg: Introduce rpmsg_get_rproc_name Chris Lew
2017-12-19 17:52     ` Bjorn Andersson
2018-01-09 19:08       ` Chris Lew
2017-12-18 22:02   ` [PATCH 6/6] rpmsg: glink: Add get_rproc_name device op Chris Lew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171222222831.GF478@tuxbook \
    --to=bjorn.andersson@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=aneela@codeaurora.org \
    --cc=clew@codeaurora.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).