* [PATCH v1 3/4] ARM: dts: add pwm pins for r40.
@ 2018-01-11 11:33 hao_zhang
2018-01-11 12:47 ` Maxime Ripard
0 siblings, 1 reply; 4+ messages in thread
From: hao_zhang @ 2018-01-11 11:33 UTC (permalink / raw)
To: thierry.reding, robh+dt, mark.rutland, linux, wens,
linus.walleij, maxime.ripard
Cc: linux-gpio, linux-kernel, devicetree, linux-arm-kernel,
linux-pwm, hao5781286
This patch add pwm pins for r40.
Signed-off-by: hao_zhang <hao5781286@gmail.com>
---
arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
index 8c5efe2..6cf6273 100644
--- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
+++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
@@ -196,6 +196,12 @@
status = "okay";
};
+&pwm {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pwm_pins>;
+ status = "okay";
+};
+
&uart0 {
pinctrl-names = "default";
pinctrl-0 = <&uart0_pb_pins>;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 3/4] ARM: dts: add pwm pins for r40.
2018-01-11 11:33 [PATCH v1 3/4] ARM: dts: add pwm pins for r40 hao_zhang
@ 2018-01-11 12:47 ` Maxime Ripard
2018-01-14 7:07 ` Hao Zhang
0 siblings, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2018-01-11 12:47 UTC (permalink / raw)
To: hao_zhang
Cc: thierry.reding, robh+dt, mark.rutland, linux, wens,
linus.walleij, linux-gpio, linux-kernel, devicetree,
linux-arm-kernel, linux-pwm
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
Hi,
On Thu, Jan 11, 2018 at 07:33:23PM +0800, hao_zhang wrote:
> This patch add pwm pins for r40.
>
> Signed-off-by: hao_zhang <hao5781286@gmail.com>
You should order your patches differently. We try to be as bisectable
as possible, and if we just apply this patch the DT will not compile
anymore.
Your patch 4 should come before this one.
Your commit title and log doesn't seem to match the content of the
patch either.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 3/4] ARM: dts: add pwm pins for r40.
2018-01-11 12:47 ` Maxime Ripard
@ 2018-01-14 7:07 ` Hao Zhang
2018-01-15 8:39 ` Maxime Ripard
0 siblings, 1 reply; 4+ messages in thread
From: Hao Zhang @ 2018-01-14 7:07 UTC (permalink / raw)
To: Maxime Ripard
Cc: Thierry Reding, robh+dt, Mark Rutland, linux, Chen-Yu Tsai,
Linus Walleij, linux-gpio, open list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Allwinner sunXi SoC support, linux-pwm
2018-01-11 20:47 GMT+08:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
> Hi,
>
> On Thu, Jan 11, 2018 at 07:33:23PM +0800, hao_zhang wrote:
>> This patch add pwm pins for r40.
>>
>> Signed-off-by: hao_zhang <hao5781286@gmail.com>
>
> You should order your patches differently. We try to be as bisectable
> as possible, and if we just apply this patch the DT will not compile
> anymore.
>
> Your patch 4 should come before this one.
>
Do you mean that the order of patch be applied is from the first to
the last in the patch set ?
because you apply the last patch first also break the DT compile...
Thinks :)
Hao Zhang
> Your commit title and log doesn't seem to match the content of the
> patch either.
>
> Thanks!
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 3/4] ARM: dts: add pwm pins for r40.
2018-01-14 7:07 ` Hao Zhang
@ 2018-01-15 8:39 ` Maxime Ripard
0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2018-01-15 8:39 UTC (permalink / raw)
To: Hao Zhang
Cc: Thierry Reding, robh+dt, Mark Rutland, linux, Chen-Yu Tsai,
Linus Walleij, linux-gpio, open list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Allwinner sunXi SoC support, linux-pwm
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
On Sun, Jan 14, 2018 at 03:07:46PM +0800, Hao Zhang wrote:
> 2018-01-11 20:47 GMT+08:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
> > Hi,
> >
> > On Thu, Jan 11, 2018 at 07:33:23PM +0800, hao_zhang wrote:
> >> This patch add pwm pins for r40.
> >>
> >> Signed-off-by: hao_zhang <hao5781286@gmail.com>
> >
> > You should order your patches differently. We try to be as bisectable
> > as possible, and if we just apply this patch the DT will not compile
> > anymore.
> >
> > Your patch 4 should come before this one.
> >
>
> Do you mean that the order of patch be applied is from the first to
> the last in the patch set ?
Yes and each steps should compile and not introduce any regressions
(ideally :)).
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-15 8:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-11 11:33 [PATCH v1 3/4] ARM: dts: add pwm pins for r40 hao_zhang
2018-01-11 12:47 ` Maxime Ripard
2018-01-14 7:07 ` Hao Zhang
2018-01-15 8:39 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).