From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Wen He <wen.he_1-3arQi8VN3Tc@public.gmane.org>
Cc: vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
leoyang.li-3arQi8VN3Tc@public.gmane.org,
jiafei.pan-3arQi8VN3Tc@public.gmane.org,
jiaheng.fan-3arQi8VN3Tc@public.gmane.org
Subject: Re: [v3 3/6] dt-bindings: fsl-qdma: add device tree for qDMA driver
Date: Fri, 19 Jan 2018 15:21:05 -0600 [thread overview]
Message-ID: <20180119212105.yvtreutv3b6oxitd@rob-hp-laptop> (raw)
In-Reply-To: <20180111093215.12636-3-wen.he_1-3arQi8VN3Tc@public.gmane.org>
On Thu, Jan 11, 2018 at 05:32:12PM +0800, Wen He wrote:
> add NXP Layerscape queue direct memory access controller(qDMA) support.
> This module can be found on NXP QorIQ Layerscape Socs.
>
> Signed-off-by: Wen He <wen.he_1-3arQi8VN3Tc@public.gmane.org>
> ---
> change in v3:
> - no change
>
> change in v2:
> - Remove indentation
> - Add "Should be" before 'fsl,ls1021a-qdma'
> - Replace 'channels' by 'dma-channels'
> - Replace 'qdma@8390000' by 'dma-controller@8390000'
>
> Documentation/devicetree/bindings/dma/fsl-qdma.txt | 40 ++++++++++++++++++++
> 1 files changed, 40 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/dma/fsl-qdma.txt
>
> diff --git a/Documentation/devicetree/bindings/dma/fsl-qdma.txt b/Documentation/devicetree/bindings/dma/fsl-qdma.txt
> new file mode 100644
> index 0000000..000472b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/fsl-qdma.txt
> @@ -0,0 +1,40 @@
> +* NXP Layerscape queue Direct Memory Access Controller(qDMA) Controller
> +
> +The qDMA controller transfers blocks of data between one source and one or more
> +destinations. The blocks of data transferred can be represented in memory as contiguous
> +or non-contiguous using scatter/gather table(s). Channel virtualization is supported
> +through enqueuing of DMA jobs to, or dequeuing DMA jobs from, different work
> +queues.
> +
> +* qDMA Controller
> +Required properties:
> +- compatible : Should be "fsl,ls1021a-qdma" or "fsl,ls1043a-qdma", "fsl,ls1021a-qdma"
Please format exactly as I showed in v1.
> +- reg : Specifies base physical address(s) and size of the qDMA registers.
> + The region is qDMA control register's address and size.
> +- interrupts : A list of interrupt-specifiers, one for each entry in
> + interrupt-names.
> +- interrupt-names : Should contain:
> + "qdma-error" - the error interrupt
> + "qdma-queue" - the queue interrupt
> +- dma-channels : Number of DMA channels supported by the controller
> +- queues : Number of queues supported by driver
> +
> +Optional properties:
> +- big-endian: If present registers and hardware scatter/gather descriptors
> + of the qDMA are implemented in big endian mode, otherwise in little
> + mode.
> +
> +
> +Examples:
> +
> + qdma: dma-controller@8390000 {
> + compatible = "fsl,ls1021a-qdma";
> + reg = <0x0 0x8398000 0x0 0x2000 /* Controller registers */
> + 0x0 0x839a000 0x0 0x2000>; /* Block registers */
> + interrupts = <GIC_SPI 185 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "qdma-error", "qdma-queue";
> + dma-channels = <8>;
> + queues = <2>;
> + big-endian;
> + };
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-19 21:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 9:32 [v3 1/6] dmaengine: fsldma: Replace DMA_IN/OUT by FSL_DMA_IN/OUT Wen He
[not found] ` <20180111093215.12636-1-wen.he_1-3arQi8VN3Tc@public.gmane.org>
2018-01-11 9:32 ` [v3 2/6] dmaengine: fsl-qdma: add NXP Layerscape qDMA engine driver support Wen He
[not found] ` <20180111093215.12636-2-wen.he_1-3arQi8VN3Tc@public.gmane.org>
2018-01-23 9:08 ` Vinod Koul
2018-01-11 9:32 ` [v3 3/6] dt-bindings: fsl-qdma: add device tree for qDMA driver Wen He
[not found] ` <20180111093215.12636-3-wen.he_1-3arQi8VN3Tc@public.gmane.org>
2018-01-19 21:21 ` Rob Herring [this message]
2018-01-11 9:32 ` [v3 4/6] arm64: dts: ls1043a: add qdma device tree nodes Wen He
2018-01-11 9:32 ` [v3 5/6] arm64: dts: ls1046a: " Wen He
2018-01-11 9:32 ` [v3 6/6] arm: dts: ls1021a: " Wen He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119212105.yvtreutv3b6oxitd@rob-hp-laptop \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jiafei.pan-3arQi8VN3Tc@public.gmane.org \
--cc=jiaheng.fan-3arQi8VN3Tc@public.gmane.org \
--cc=leoyang.li-3arQi8VN3Tc@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=wen.he_1-3arQi8VN3Tc@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).