* [PATCH v2] dt-bindings: display: stm32: add pixel clock mandatory property
@ 2018-01-12 15:30 Philippe Cornu
2018-01-19 22:43 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Cornu @ 2018-01-12 15:30 UTC (permalink / raw)
To: Rob Herring, Arnd Bergmann, Russell King, Mark Rutland,
Archit Taneja, Andrzej Hajda, Laurent Pinchart, David Airlie,
Philippe Cornu, Philipp Zabel, Benjamin Gaignard, Bhumika Goyal,
devicetree, linux-arm-kernel, dri-devel, linux-kernel
Cc: Alexandre Torgue, Fabien Dessenne, Yannick Fertre,
Maxime Coquelin, Mickael Reulier, Vincent Abriou,
Gabriel Fernandez, Ludovic Barre
Add the DPI/RGB input pixel clock in mandatory properties
because it really offers a better preciseness for timing
computations.
Note: Fix also the DSI panel example where "ref" & "pclk"
clocks were swapped.
Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
---
Changes in v2: put new clock in last position (Rob Herring)
Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
index 029252253ad4..942b7237ae87 100644
--- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
+++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
@@ -29,6 +29,7 @@ Mandatory properties specific to STM32 DSI:
- compatible: "st,stm32-dsi".
- clock-names:
- phy pll reference clock string name, must be "ref".
+ - DPI/RGB input pixel clock string name, must be "px_clk".
- resets: see [5].
- reset-names: see [5].
@@ -97,8 +98,9 @@ Example 2: DSI panel
#size-cells = <0>;
compatible = "st,stm32-dsi";
reg = <0x40016c00 0x800>;
- clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
- clock-names = "ref", "pclk";
+ clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>,
+ <&rcc 1 CLK_LCD>;
+ clock-names = "pclk", "ref", "px_clk";
resets = <&rcc STM32F4_APB2_RESET(DSI)>;
reset-names = "apb";
--
2.15.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: display: stm32: add pixel clock mandatory property
2018-01-12 15:30 [PATCH v2] dt-bindings: display: stm32: add pixel clock mandatory property Philippe Cornu
@ 2018-01-19 22:43 ` Rob Herring
2018-01-21 21:15 ` Philippe CORNU
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2018-01-19 22:43 UTC (permalink / raw)
To: Philippe Cornu
Cc: Mark Rutland, David Airlie, dri-devel, Laurent Pinchart,
Mickael Reulier, Russell King, Fabien Dessenne, linux-arm-kernel,
devicetree, Alexandre Torgue, Arnd Bergmann, Vincent Abriou,
Ludovic Barre, linux-kernel, Yannick Fertre, Maxime Coquelin,
Gabriel Fernandez, Bhumika Goyal
On Fri, Jan 12, 2018 at 04:30:34PM +0100, Philippe Cornu wrote:
> Add the DPI/RGB input pixel clock in mandatory properties
> because it really offers a better preciseness for timing
> computations.
> Note: Fix also the DSI panel example where "ref" & "pclk"
> clocks were swapped.
>
> Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
> ---
> Changes in v2: put new clock in last position (Rob Herring)
>
> Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> index 029252253ad4..942b7237ae87 100644
> --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> @@ -29,6 +29,7 @@ Mandatory properties specific to STM32 DSI:
> - compatible: "st,stm32-dsi".
> - clock-names:
> - phy pll reference clock string name, must be "ref".
> + - DPI/RGB input pixel clock string name, must be "px_clk".
> - resets: see [5].
> - reset-names: see [5].
>
> @@ -97,8 +98,9 @@ Example 2: DSI panel
> #size-cells = <0>;
> compatible = "st,stm32-dsi";
> reg = <0x40016c00 0x800>;
> - clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
> - clock-names = "ref", "pclk";
> + clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>,
> + <&rcc 1 CLK_LCD>;
> + clock-names = "pclk", "ref", "px_clk";
You have the existing names reversed here.
> resets = <&rcc STM32F4_APB2_RESET(DSI)>;
> reset-names = "apb";
>
> --
> 2.15.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: display: stm32: add pixel clock mandatory property
2018-01-19 22:43 ` Rob Herring
@ 2018-01-21 21:15 ` Philippe CORNU
0 siblings, 0 replies; 3+ messages in thread
From: Philippe CORNU @ 2018-01-21 21:15 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, David Airlie, dri-devel, Laurent Pinchart,
Mickael REULIER, Russell King, Fabien DESSENNE, linux-arm-kernel,
devicetree, Alexandre TORGUE, Arnd Bergmann, Vincent ABRIOU,
Ludovic BARRE, linux-kernel, Yannick FERTRE, Maxime Coquelin
Hi Rob,
On 01/19/2018 11:43 PM, Rob Herring wrote:
> On Fri, Jan 12, 2018 at 04:30:34PM +0100, Philippe Cornu wrote:
>> Add the DPI/RGB input pixel clock in mandatory properties
>> because it really offers a better preciseness for timing
>> computations.
>> Note: Fix also the DSI panel example where "ref" & "pclk"
>> clocks were swapped.
>>
>> Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
>> ---
>> Changes in v2: put new clock in last position (Rob Herring)
>>
>> Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
>> index 029252253ad4..942b7237ae87 100644
>> --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
>> +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
>> @@ -29,6 +29,7 @@ Mandatory properties specific to STM32 DSI:
>> - compatible: "st,stm32-dsi".
>> - clock-names:
>> - phy pll reference clock string name, must be "ref".
>> + - DPI/RGB input pixel clock string name, must be "px_clk".
>> - resets: see [5].
>> - reset-names: see [5].
>>
>> @@ -97,8 +98,9 @@ Example 2: DSI panel
>> #size-cells = <0>;
>> compatible = "st,stm32-dsi";
>> reg = <0x40016c00 0x800>;
>> - clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
>> - clock-names = "ref", "pclk";
>> + clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>,
>> + <&rcc 1 CLK_LCD>;
>> + clock-names = "pclk", "ref", "px_clk";
>
> You have the existing names reversed here.
And many thanks for your review.
Names are "reversed" as explained in the note in the commit message.
Well, maybe the note is not clear enough... So I have just sent 2
separate patches that I hope will be better to understand.
Many thanks,
Philippe : )
>
>> resets = <&rcc STM32F4_APB2_RESET(DSI)>;
>> reset-names = "apb";
>>
>> --
>> 2.15.1
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-21 21:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-12 15:30 [PATCH v2] dt-bindings: display: stm32: add pixel clock mandatory property Philippe Cornu
2018-01-19 22:43 ` Rob Herring
2018-01-21 21:15 ` Philippe CORNU
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).