devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb
@ 2018-01-24 21:39 Bartosz Golaszewski
  2018-02-05 18:38 ` Alexey Brodkin
  0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2018-01-24 21:39 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Russell King, Alexey Brodkin, Vineet Gupta
  Cc: devicetree, linux-kernel, linux-snps-arc, Bartosz Golaszewski

Using compatible strings without the <manufacturer> part for at24 is
now deprecated. Use a correct 'atmel,<model>' value.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
 arch/arc/boot/dts/axs10x_mb.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
index 74d070cd3c13..47b74fbc403c 100644
--- a/arch/arc/boot/dts/axs10x_mb.dtsi
+++ b/arch/arc/boot/dts/axs10x_mb.dtsi
@@ -214,13 +214,13 @@
 			};
 
 			eeprom@0x54{
-				compatible = "24c01";
+				compatible = "atmel,24c01";
 				reg = <0x54>;
 				pagesize = <0x8>;
 			};
 
 			eeprom@0x57{
-				compatible = "24c04";
+				compatible = "atmel,24c04";
 				reg = <0x57>;
 				pagesize = <0x8>;
 			};
-- 
2.16.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb
  2018-01-24 21:39 [PATCH] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb Bartosz Golaszewski
@ 2018-02-05 18:38 ` Alexey Brodkin
  0 siblings, 0 replies; 2+ messages in thread
From: Alexey Brodkin @ 2018-02-05 18:38 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: Mark Rutland, devicetree, Vineet Gupta, linux-kernel,
	Russell King, Rob Herring, linux-snps-arc

Hi Bartosz, all,

> -----Original Message-----
> From: Bartosz Golaszewski [mailto:brgl@bgdev.pl]
> Sent: Thursday, January 25, 2018 12:40 AM
> To: Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Russell King <linux@armlinux.org.uk>; Alexey
> Brodkin <Alexey.Brodkin@synopsys.com>; Vineet Gupta <Vineet.Gupta1@synopsys.com>
> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-snps-arc@lists.infradead.org; Bartosz Golaszewski
> <brgl@bgdev.pl>
> Subject: [PATCH] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb
> 
> Using compatible strings without the <manufacturer> part for at24 is
> now deprecated. Use a correct 'atmel,<model>' value.

Even though I agree with this change itself I think it may worth
mentioning an explicit commit that deprecated manufacturer'less parts.

-Alexey

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-05 18:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-24 21:39 [PATCH] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb Bartosz Golaszewski
2018-02-05 18:38 ` Alexey Brodkin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).