* [PATCH V4 1/2] clk: imx: imx7d: add the snvs clock
@ 2018-01-09 9:52 Anson Huang
2018-01-09 9:52 ` [PATCH V4 2/2] ARM: dts: imx7s: add snvs rtc clock Anson Huang
2018-01-11 22:10 ` [PATCH V4 1/2] clk: imx: imx7d: add the snvs clock Rob Herring
0 siblings, 2 replies; 7+ messages in thread
From: Anson Huang @ 2018-01-09 9:52 UTC (permalink / raw)
To: horia.geanta, aymen.sghaier, herbert, davem, robh+dt,
mark.rutland, shawnguo, kernel, fabio.estevam, linux, mturquette,
sboyd, adriana.reus, stefan, dongas86
Cc: devicetree, linux-clk, linux-crypto, linux-arm-kernel, linux-kernel
According to the i.MX7D Reference Manual,
SNVS block has a clock gate, accessing SNVS block
would need this clock gate to be enabled, add it
into clock tree so that SNVS module driver can
operate this clock gate.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/clk/imx/clk-imx7d.c | 1 +
include/dt-bindings/clock/imx7d-clock.h | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c
index 80dc211..f34f1ec 100644
--- a/drivers/clk/imx/clk-imx7d.c
+++ b/drivers/clk/imx/clk-imx7d.c
@@ -795,6 +795,7 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node)
clks[IMX7D_DRAM_PHYM_ALT_ROOT_CLK] = imx_clk_gate4("dram_phym_alt_root_clk", "dram_phym_alt_post_div", base + 0x4130, 0);
clks[IMX7D_DRAM_ALT_ROOT_CLK] = imx_clk_gate4("dram_alt_root_clk", "dram_alt_post_div", base + 0x4130, 0);
clks[IMX7D_OCOTP_CLK] = imx_clk_gate4("ocotp_clk", "ipg_root_clk", base + 0x4230, 0);
+ clks[IMX7D_SNVS_CLK] = imx_clk_gate4("snvs_clk", "ipg_root_clk", base + 0x4250, 0);
clks[IMX7D_USB_HSIC_ROOT_CLK] = imx_clk_gate4("usb_hsic_root_clk", "usb_hsic_post_div", base + 0x4420, 0);
clks[IMX7D_SDMA_CORE_CLK] = imx_clk_gate4("sdma_root_clk", "ahb_root_clk", base + 0x4480, 0);
clks[IMX7D_PCIE_CTRL_ROOT_CLK] = imx_clk_gate4("pcie_ctrl_root_clk", "pcie_ctrl_post_div", base + 0x4600, 0);
diff --git a/include/dt-bindings/clock/imx7d-clock.h b/include/dt-bindings/clock/imx7d-clock.h
index e2f99ae..dc51904 100644
--- a/include/dt-bindings/clock/imx7d-clock.h
+++ b/include/dt-bindings/clock/imx7d-clock.h
@@ -452,5 +452,6 @@
#define IMX7D_OCOTP_CLK 439
#define IMX7D_NAND_RAWNAND_CLK 440
#define IMX7D_NAND_USDHC_BUS_RAWNAND_CLK 441
-#define IMX7D_CLK_END 442
+#define IMX7D_SNVS_CLK 442
+#define IMX7D_CLK_END 443
#endif /* __DT_BINDINGS_CLOCK_IMX7D_H */
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH V4 2/2] ARM: dts: imx7s: add snvs rtc clock
2018-01-09 9:52 [PATCH V4 1/2] clk: imx: imx7d: add the snvs clock Anson Huang
@ 2018-01-09 9:52 ` Anson Huang
2018-01-09 10:26 ` Dong Aisheng
` (2 more replies)
2018-01-11 22:10 ` [PATCH V4 1/2] clk: imx: imx7d: add the snvs clock Rob Herring
1 sibling, 3 replies; 7+ messages in thread
From: Anson Huang @ 2018-01-09 9:52 UTC (permalink / raw)
To: horia.geanta, aymen.sghaier, herbert, davem, robh+dt,
mark.rutland, shawnguo, kernel, fabio.estevam, linux, mturquette,
sboyd, adriana.reus, stefan, dongas86
Cc: linux-crypto, devicetree, linux-kernel, linux-arm-kernel, linux-clk
Add i.MX7 SNVS RTC clock.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
change since v3:
add optional for clocks in binding doc statement.
Documentation/devicetree/bindings/crypto/fsl-sec4.txt | 17 +++++++++++++++++
arch/arm/boot/dts/imx7s.dtsi | 2 ++
2 files changed, 19 insertions(+)
diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
index 76aec8a..3c1f3a2 100644
--- a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
+++ b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
@@ -415,12 +415,27 @@ Secure Non-Volatile Storage (SNVS) Low Power (LP) RTC Node
value type: <u32>
Definition: LP register offset. default it is 0x34.
+ - clocks
+ Usage: optional, required if SNVS LP RTC requires explicit
+ enablement of clocks
+ Value type: <prop_encoded-array>
+ Definition: a clock specifier describing the clock required for
+ enabling and disabling SNVS LP RTC.
+
+ - clock-names
+ Usage: optional, required if SNVS LP RTC requires explicit
+ enablement of clocks
+ Value type: <string>
+ Definition: clock name string should be "snvs-rtc".
+
EXAMPLE
sec_mon_rtc_lp@1 {
compatible = "fsl,sec-v4.0-mon-rtc-lp";
interrupts = <93 2>;
regmap = <&snvs>;
offset = <0x34>;
+ clocks = <&clks IMX7D_SNVS_CLK>;
+ clock-names = "snvs-rtc";
};
=====================================================================
@@ -543,6 +558,8 @@ FULL EXAMPLE
regmap = <&sec_mon>;
offset = <0x34>;
interrupts = <93 2>;
+ clocks = <&clks IMX7D_SNVS_CLK>;
+ clock-names = "snvs-rtc";
};
snvs-pwrkey@020cc000 {
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 9aa2bb9..02baf42 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -551,6 +551,8 @@
offset = <0x34>;
interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks IMX7D_SNVS_CLK>;
+ clock-names = "snvs-rtc";
};
snvs_poweroff: snvs-poweroff {
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH V4 2/2] ARM: dts: imx7s: add snvs rtc clock
2018-01-09 9:52 ` [PATCH V4 2/2] ARM: dts: imx7s: add snvs rtc clock Anson Huang
@ 2018-01-09 10:26 ` Dong Aisheng
2018-01-11 22:11 ` Rob Herring
2018-02-02 3:44 ` Shawn Guo
2 siblings, 0 replies; 7+ messages in thread
From: Dong Aisheng @ 2018-01-09 10:26 UTC (permalink / raw)
To: Anson Huang
Cc: mark.rutland, devicetree, aymen.sghaier, herbert, horia.geanta,
mturquette, sboyd, linux, stefan, linux-kernel, linux-clk,
adriana.reus, robh+dt, linux-crypto, kernel, fabio.estevam,
shawnguo, davem, linux-arm-kernel, linux-imx
On Tue, Jan 09, 2018 at 05:52:06PM +0800, Anson Huang wrote:
> Add i.MX7 SNVS RTC clock.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Dong Aisheng
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V4 2/2] ARM: dts: imx7s: add snvs rtc clock
2018-01-09 9:52 ` [PATCH V4 2/2] ARM: dts: imx7s: add snvs rtc clock Anson Huang
2018-01-09 10:26 ` Dong Aisheng
@ 2018-01-11 22:11 ` Rob Herring
2018-02-02 3:44 ` Shawn Guo
2 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2018-01-11 22:11 UTC (permalink / raw)
To: Anson Huang
Cc: horia.geanta, aymen.sghaier, herbert, davem, mark.rutland,
shawnguo, kernel, fabio.estevam, linux, mturquette, sboyd,
adriana.reus, stefan, dongas86, linux-crypto, devicetree,
linux-kernel, linux-arm-kernel, linux-clk
On Tue, Jan 09, 2018 at 05:52:06PM +0800, Anson Huang wrote:
> Add i.MX7 SNVS RTC clock.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> change since v3:
> add optional for clocks in binding doc statement.
> Documentation/devicetree/bindings/crypto/fsl-sec4.txt | 17 +++++++++++++++++
> arch/arm/boot/dts/imx7s.dtsi | 2 ++
> 2 files changed, 19 insertions(+)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V4 2/2] ARM: dts: imx7s: add snvs rtc clock
2018-01-09 9:52 ` [PATCH V4 2/2] ARM: dts: imx7s: add snvs rtc clock Anson Huang
2018-01-09 10:26 ` Dong Aisheng
2018-01-11 22:11 ` Rob Herring
@ 2018-02-02 3:44 ` Shawn Guo
2018-02-22 5:19 ` Shawn Guo
2 siblings, 1 reply; 7+ messages in thread
From: Shawn Guo @ 2018-02-02 3:44 UTC (permalink / raw)
To: Anson Huang
Cc: horia.geanta, aymen.sghaier, herbert, davem, robh+dt,
mark.rutland, kernel, fabio.estevam, linux, mturquette, sboyd,
adriana.reus, stefan, dongas86, devicetree, linux-clk,
linux-crypto, linux-arm-kernel, linux-kernel
On Tue, Jan 09, 2018 at 05:52:06PM +0800, Anson Huang wrote:
> Add i.MX7 SNVS RTC clock.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Looks fine to me. Ping me when clk driver part lands mainline.
Shawn
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V4 2/2] ARM: dts: imx7s: add snvs rtc clock
2018-02-02 3:44 ` Shawn Guo
@ 2018-02-22 5:19 ` Shawn Guo
0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2018-02-22 5:19 UTC (permalink / raw)
To: Anson Huang
Cc: mark.rutland, devicetree, aymen.sghaier, herbert, horia.geanta,
davem, mturquette, sboyd, linux-kernel, stefan, linux,
fabio.estevam, robh+dt, linux-crypto, kernel, adriana.reus,
linux-clk, linux-arm-kernel, dongas86
On Fri, Feb 02, 2018 at 11:44:59AM +0800, Shawn Guo wrote:
> On Tue, Jan 09, 2018 at 05:52:06PM +0800, Anson Huang wrote:
> > Add i.MX7 SNVS RTC clock.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>
> Looks fine to me. Ping me when clk driver part lands mainline.
I'm collecting i.MX clock patches and later will send them to clk
maintainers in form of pull request. So applied both.
Shawn
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V4 1/2] clk: imx: imx7d: add the snvs clock
2018-01-09 9:52 [PATCH V4 1/2] clk: imx: imx7d: add the snvs clock Anson Huang
2018-01-09 9:52 ` [PATCH V4 2/2] ARM: dts: imx7s: add snvs rtc clock Anson Huang
@ 2018-01-11 22:10 ` Rob Herring
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2018-01-11 22:10 UTC (permalink / raw)
To: Anson Huang
Cc: horia.geanta, aymen.sghaier, herbert, davem, mark.rutland,
shawnguo, kernel, fabio.estevam, linux, mturquette, sboyd,
adriana.reus, stefan, dongas86, linux-crypto, devicetree,
linux-kernel, linux-arm-kernel, linux-clk
On Tue, Jan 09, 2018 at 05:52:05PM +0800, Anson Huang wrote:
> According to the i.MX7D Reference Manual,
> SNVS block has a clock gate, accessing SNVS block
> would need this clock gate to be enabled, add it
> into clock tree so that SNVS module driver can
> operate this clock gate.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/clk/imx/clk-imx7d.c | 1 +
> include/dt-bindings/clock/imx7d-clock.h | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-02-22 5:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-09 9:52 [PATCH V4 1/2] clk: imx: imx7d: add the snvs clock Anson Huang
2018-01-09 9:52 ` [PATCH V4 2/2] ARM: dts: imx7s: add snvs rtc clock Anson Huang
2018-01-09 10:26 ` Dong Aisheng
2018-01-11 22:11 ` Rob Herring
2018-02-02 3:44 ` Shawn Guo
2018-02-22 5:19 ` Shawn Guo
2018-01-11 22:10 ` [PATCH V4 1/2] clk: imx: imx7d: add the snvs clock Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).