devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: ls1021a: add quadspi node
@ 2018-01-26 14:20 Rasmus Villemoes
       [not found] ` <20180126142014.13819-1-rasmus.villemoes-rjjw5hvvQKZaa/9Udqfwiw@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Rasmus Villemoes @ 2018-01-26 14:20 UTC (permalink / raw)
  To: Shawn Guo, Rob Herring, Mark Rutland, Russell King
  Cc: Rasmus Villemoes, devicetree, linux-arm-kernel, linux-kernel

Add a node to device tree repesenting the QuadSPI controller present on
LS1021a. Driver support has been present since e8c034b2fbe5 (mtd:
spi-nor: fsl-quadspi: add support for ls1021a).

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
 arch/arm/boot/dts/ls1021a.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index d82d8fa7afbb..5e5c84db3946 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -162,6 +162,20 @@
 			big-endian;
 		};
 
+		qspi: quadspi@1550000 {
+			compatible = "fsl,ls1021a-qspi";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x0 0x1550000 0x0 0x10000>,
+				<0x0 0x40000000 0x0 0x4000000>;
+			reg-names = "QuadSPI", "QuadSPI-memory";
+			interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
+			clock-names = "qspi_en", "qspi";
+			clocks = <&clockgen 4 1>, <&clockgen 4 1>;
+			big-endian;
+			status = "disabled";
+		};
+
 		esdhc: esdhc@1560000 {
 			compatible = "fsl,esdhc";
 			reg = <0x0 0x1560000 0x0 0x10000>;
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: ls1021a: add quadspi node
       [not found] ` <20180126142014.13819-1-rasmus.villemoes-rjjw5hvvQKZaa/9Udqfwiw@public.gmane.org>
@ 2018-02-05  8:03   ` Shawn Guo
  2018-02-08 14:24     ` Rasmus Villemoes
  0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2018-02-05  8:03 UTC (permalink / raw)
  To: Rasmus Villemoes
  Cc: Rob Herring, Mark Rutland, Russell King,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On Fri, Jan 26, 2018 at 03:20:14PM +0100, Rasmus Villemoes wrote:
> Add a node to device tree repesenting the QuadSPI controller present on
> LS1021a. Driver support has been present since e8c034b2fbe5 (mtd:
> spi-nor: fsl-quadspi: add support for ls1021a).
> 
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes-rjjw5hvvQKZaa/9Udqfwiw@public.gmane.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: ls1021a: add quadspi node
  2018-02-05  8:03   ` Shawn Guo
@ 2018-02-08 14:24     ` Rasmus Villemoes
  2018-02-09  2:55       ` Shawn Guo
  0 siblings, 1 reply; 4+ messages in thread
From: Rasmus Villemoes @ 2018-02-08 14:24 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Rob Herring, Mark Rutland, Russell King,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On 2018-02-05 09:03, Shawn Guo wrote:
> On Fri, Jan 26, 2018 at 03:20:14PM +0100, Rasmus Villemoes wrote:
>> Add a node to device tree repesenting the QuadSPI controller present on
>> LS1021a. Driver support has been present since e8c034b2fbe5 (mtd:
>> spi-nor: fsl-quadspi: add support for ls1021a).
>>
>> Signed-off-by: Rasmus Villemoes <rasmus.villemoes-rjjw5hvvQKZaa/9Udqfwiw@public.gmane.org>
> 
> Applied, thanks.
> 

Sorry, I didn't know you already had a similar patch queued for 4.16
(85f8ee78ab ARM: dts: ls1021a: Add support for QSPI with ls1021a SoC),
so I have to ask you to unapply (or do you want me to send a revert?) -
the ls1021a.dtsi in your imx/dt branch now has two almost-identical
qspi: nodes.

Rasmus
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: ls1021a: add quadspi node
  2018-02-08 14:24     ` Rasmus Villemoes
@ 2018-02-09  2:55       ` Shawn Guo
  0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2018-02-09  2:55 UTC (permalink / raw)
  To: Rasmus Villemoes
  Cc: Rob Herring, Mark Rutland, Russell King, devicetree,
	linux-arm-kernel, linux-kernel

On Thu, Feb 08, 2018 at 03:24:40PM +0100, Rasmus Villemoes wrote:
> On 2018-02-05 09:03, Shawn Guo wrote:
> > On Fri, Jan 26, 2018 at 03:20:14PM +0100, Rasmus Villemoes wrote:
> >> Add a node to device tree repesenting the QuadSPI controller present on
> >> LS1021a. Driver support has been present since e8c034b2fbe5 (mtd:
> >> spi-nor: fsl-quadspi: add support for ls1021a).
> >>
> >> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> > 
> > Applied, thanks.
> > 
> 
> Sorry, I didn't know you already had a similar patch queued for 4.16
> (85f8ee78ab ARM: dts: ls1021a: Add support for QSPI with ls1021a SoC),
> so I have to ask you to unapply (or do you want me to send a revert?) -
> the ls1021a.dtsi in your imx/dt branch now has two almost-identical
> qspi: nodes.

Ah, I did not notice that either.  Patch dropped.


Shawn

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-02-09  2:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-26 14:20 [PATCH] ARM: dts: ls1021a: add quadspi node Rasmus Villemoes
     [not found] ` <20180126142014.13819-1-rasmus.villemoes-rjjw5hvvQKZaa/9Udqfwiw@public.gmane.org>
2018-02-05  8:03   ` Shawn Guo
2018-02-08 14:24     ` Rasmus Villemoes
2018-02-09  2:55       ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).