devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] arm64: dts: renesas: r8a77970/r8a77995: Remove non-existing STBE region
@ 2018-02-06 13:05 Geert Uytterhoeven
  2018-02-06 13:05 ` [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional Geert Uytterhoeven
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2018-02-06 13:05 UTC (permalink / raw)
  To: Sergei Shtylyov, Rob Herring, Mark Rutland, Simon Horman,
	Magnus Damm, David S . Miller, Yoshihiro Shimoda
  Cc: netdev, linux-renesas-soc, devicetree, Geert Uytterhoeven

	Hi all,

The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and
is not present on all R-Car Gen3 SoCs.

This patches series documents this in the DT bindings, and removes the
non-existing regions from the affected DTS files.  Note that this region
is apparently not used by the RAVB driver.

The first patch is intended for either the net or DT tree.
The last two patches are intended for the renesas tree.

Compile-tested only.

Thanks for your comments!

Geert Uytterhoeven (3):
  dt-bindings: net: renesas-ravb: Make stream buffer optional
  arm64: dts: renesas: r8a77970: Remove non-existing STBE region
  arm64: dts: renesas: r8a77995: Remove non-existing STBE region

 Documentation/devicetree/bindings/net/renesas,ravb.txt | 5 ++++-
 arch/arm64/boot/dts/renesas/r8a77970.dtsi              | 2 +-
 arch/arm64/boot/dts/renesas/r8a77995.dtsi              | 2 +-
 3 files changed, 6 insertions(+), 3 deletions(-)

-- 
2.7.4

Gr{oetje,eeting}s,

						Geert

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional
  2018-02-06 13:05 [PATCH 0/3] arm64: dts: renesas: r8a77970/r8a77995: Remove non-existing STBE region Geert Uytterhoeven
@ 2018-02-06 13:05 ` Geert Uytterhoeven
  2018-02-06 13:17   ` Simon Horman
                     ` (2 more replies)
  2018-02-06 13:05 ` [PATCH 2/3] arm64: dts: renesas: r8a77970: Remove non-existing STBE region Geert Uytterhoeven
       [not found] ` <1517922354-28421-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
  2 siblings, 3 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2018-02-06 13:05 UTC (permalink / raw)
  To: Sergei Shtylyov, Rob Herring, Mark Rutland, Simon Horman,
	Magnus Damm, David S . Miller, Yoshihiro Shimoda
  Cc: netdev, linux-renesas-soc, devicetree, Geert Uytterhoeven

The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and
is not present on all SoCs.

Document this in the DT bindings, including a list of SoCs that do have
it.

Fixes: 785ec87483d1e24a ("ravb: document R8A77970 bindings")
Fixes: f231c4178a655b09 ("dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/net/renesas,ravb.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
index c902261893b913f5..296191c323a64403 100644
--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
@@ -26,7 +26,10 @@ Required properties:
 	SoC-specific version corresponding to the platform first followed by
 	the generic version.
 
-- reg: offset and length of (1) the register block and (2) the stream buffer.
+- reg: Offset and length of (1) the register block and (2) the stream buffer.
+       The region for the register block is mandatory.
+       The region for the stream buffer is optional, as it is only present on
+       R-Car Gen2, RZ/G1, and R-Car H3 and M3-W.
 - interrupts: A list of interrupt-specifiers, one for each entry in
 	      interrupt-names.
 	      If interrupt-names is not present, an interrupt specifier
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/3] arm64: dts: renesas: r8a77970: Remove non-existing STBE region
  2018-02-06 13:05 [PATCH 0/3] arm64: dts: renesas: r8a77970/r8a77995: Remove non-existing STBE region Geert Uytterhoeven
  2018-02-06 13:05 ` [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional Geert Uytterhoeven
@ 2018-02-06 13:05 ` Geert Uytterhoeven
  2018-02-07  9:45   ` Simon Horman
       [not found] ` <1517922354-28421-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
  2 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2018-02-06 13:05 UTC (permalink / raw)
  To: Sergei Shtylyov, Rob Herring, Mark Rutland, Simon Horman,
	Magnus Damm, David S . Miller, Yoshihiro Shimoda
  Cc: netdev, linux-renesas-soc, devicetree, Geert Uytterhoeven

R-Car V3M does not have the Stream Buffer for EtherAVB-IF (STBE).

Note that the RAVB driver does not use this region.

Fixes: bea2ab136eaacec2 ("arm64: dts: renesas: r8a77970: add EtherAVB support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
index d13794ab2f47b6dc..15a003cb56764c44 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -588,7 +588,7 @@
 		avb: ethernet@e6800000 {
 			compatible = "renesas,etheravb-r8a77970",
 				     "renesas,etheravb-rcar-gen3";
-			reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>;
+			reg = <0 0xe6800000 0 0x800>;
 			interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>,
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/3] arm64: dts: renesas: r8a77995: Remove non-existing STBE region
       [not found] ` <1517922354-28421-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
@ 2018-02-06 13:05   ` Geert Uytterhoeven
  2018-02-07  9:45     ` Simon Horman
  0 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2018-02-06 13:05 UTC (permalink / raw)
  To: Sergei Shtylyov, Rob Herring, Mark Rutland, Simon Horman,
	Magnus Damm, David S . Miller, Yoshihiro Shimoda
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven

R-Car D3 does not have the Stream Buffer for EtherAVB-IF (STBE).

Note that the RAVB driver does not use this region.

Fixes: f9ba0c4cfe6169b7 ("arm64: dts: renesas: r8a77995: Add EthernetAVB device node")
Signed-off-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/r8a77995.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
index 23f763beab46c633..12d137900efe133c 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
@@ -476,7 +476,7 @@
 		avb: ethernet@e6800000 {
 			compatible = "renesas,etheravb-r8a77995",
 				     "renesas,etheravb-rcar-gen3";
-			reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>;
+			reg = <0 0xe6800000 0 0x800>;
 			interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>,
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional
  2018-02-06 13:05 ` [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional Geert Uytterhoeven
@ 2018-02-06 13:17   ` Simon Horman
  2018-02-06 14:56   ` Sergei Shtylyov
  2018-02-09 22:55   ` Rob Herring
  2 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2018-02-06 13:17 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Sergei Shtylyov, Rob Herring, Mark Rutland, Magnus Damm,
	David S . Miller, Yoshihiro Shimoda, netdev, linux-renesas-soc,
	devicetree

On Tue, Feb 06, 2018 at 02:05:52PM +0100, Geert Uytterhoeven wrote:
> The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and
> is not present on all SoCs.
> 
> Document this in the DT bindings, including a list of SoCs that do have
> it.
> 
> Fixes: 785ec87483d1e24a ("ravb: document R8A77970 bindings")
> Fixes: f231c4178a655b09 ("dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional
  2018-02-06 13:05 ` [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional Geert Uytterhoeven
  2018-02-06 13:17   ` Simon Horman
@ 2018-02-06 14:56   ` Sergei Shtylyov
  2018-02-06 15:12     ` Geert Uytterhoeven
  2018-02-09 22:55   ` Rob Herring
  2 siblings, 1 reply; 10+ messages in thread
From: Sergei Shtylyov @ 2018-02-06 14:56 UTC (permalink / raw)
  To: Geert Uytterhoeven, Rob Herring, Mark Rutland, Simon Horman,
	Magnus Damm, David S . Miller, Yoshihiro Shimoda
  Cc: netdev, linux-renesas-soc, devicetree

On 02/06/2018 04:05 PM, Geert Uytterhoeven wrote:

> The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and
> is not present on all SoCs.
> 
> Document this in the DT bindings, including a list of SoCs that do have
> it.
> 
> Fixes: 785ec87483d1e24a ("ravb: document R8A77970 bindings")
> Fixes: f231c4178a655b09 ("dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> ---
>  Documentation/devicetree/bindings/net/renesas,ravb.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> index c902261893b913f5..296191c323a64403 100644
> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> @@ -26,7 +26,10 @@ Required properties:
>  	SoC-specific version corresponding to the platform first followed by
>  	the generic version.
>  
> -- reg: offset and length of (1) the register block and (2) the stream buffer.
> +- reg: Offset and length of (1) the register block and (2) the stream buffer.
> +       The region for the register block is mandatory.
> +       The region for the stream buffer is optional, as it is only present on
> +       R-Car Gen2, RZ/G1, and R-Car H3 and M3-W.

   Did you deliberately omit M3-N for now?

MBR, Sergei

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional
  2018-02-06 14:56   ` Sergei Shtylyov
@ 2018-02-06 15:12     ` Geert Uytterhoeven
  0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2018-02-06 15:12 UTC (permalink / raw)
  To: Sergei Shtylyov
  Cc: Geert Uytterhoeven, Rob Herring, Mark Rutland, Simon Horman,
	Magnus Damm, David S . Miller, Yoshihiro Shimoda, netdev,
	Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

Hi Sergei,

On Tue, Feb 6, 2018 at 3:56 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 02/06/2018 04:05 PM, Geert Uytterhoeven wrote:
>> The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and
>> is not present on all SoCs.
>>
>> Document this in the DT bindings, including a list of SoCs that do have
>> it.
>>
>> Fixes: 785ec87483d1e24a ("ravb: document R8A77970 bindings")
>> Fixes: f231c4178a655b09 ("dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Thanks!

>> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
>> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>> @@ -26,7 +26,10 @@ Required properties:
>>       SoC-specific version corresponding to the platform first followed by
>>       the generic version.
>>
>> -- reg: offset and length of (1) the register block and (2) the stream buffer.
>> +- reg: Offset and length of (1) the register block and (2) the stream buffer.
>> +       The region for the register block is mandatory.
>> +       The region for the stream buffer is optional, as it is only present on
>> +       R-Car Gen2, RZ/G1, and R-Car H3 and M3-W.
>
>    Did you deliberately omit M3-N for now?

Of course. It's not yet upstream.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/3] arm64: dts: renesas: r8a77970: Remove non-existing STBE region
  2018-02-06 13:05 ` [PATCH 2/3] arm64: dts: renesas: r8a77970: Remove non-existing STBE region Geert Uytterhoeven
@ 2018-02-07  9:45   ` Simon Horman
  0 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2018-02-07  9:45 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Sergei Shtylyov, Rob Herring, Mark Rutland, Magnus Damm,
	David S . Miller, Yoshihiro Shimoda, netdev, linux-renesas-soc,
	devicetree

On Tue, Feb 06, 2018 at 02:05:53PM +0100, Geert Uytterhoeven wrote:
> R-Car V3M does not have the Stream Buffer for EtherAVB-IF (STBE).
> 
> Note that the RAVB driver does not use this region.
> 
> Fixes: bea2ab136eaacec2 ("arm64: dts: renesas: r8a77970: add EtherAVB support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied for v4.17.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/3] arm64: dts: renesas: r8a77995: Remove non-existing STBE region
  2018-02-06 13:05   ` [PATCH 3/3] arm64: dts: renesas: r8a77995: " Geert Uytterhoeven
@ 2018-02-07  9:45     ` Simon Horman
  0 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2018-02-07  9:45 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Sergei Shtylyov, Rob Herring, Mark Rutland, Magnus Damm,
	David S . Miller, Yoshihiro Shimoda, netdev, linux-renesas-soc,
	devicetree

On Tue, Feb 06, 2018 at 02:05:54PM +0100, Geert Uytterhoeven wrote:
> R-Car D3 does not have the Stream Buffer for EtherAVB-IF (STBE).
> 
> Note that the RAVB driver does not use this region.
> 
> Fixes: f9ba0c4cfe6169b7 ("arm64: dts: renesas: r8a77995: Add EthernetAVB device node")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied for v4.17.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional
  2018-02-06 13:05 ` [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional Geert Uytterhoeven
  2018-02-06 13:17   ` Simon Horman
  2018-02-06 14:56   ` Sergei Shtylyov
@ 2018-02-09 22:55   ` Rob Herring
  2 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2018-02-09 22:55 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Sergei Shtylyov, Mark Rutland, Simon Horman, Magnus Damm,
	David S . Miller, Yoshihiro Shimoda, netdev, linux-renesas-soc,
	devicetree

On Tue, Feb 06, 2018 at 02:05:52PM +0100, Geert Uytterhoeven wrote:
> The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and
> is not present on all SoCs.
> 
> Document this in the DT bindings, including a list of SoCs that do have
> it.
> 
> Fixes: 785ec87483d1e24a ("ravb: document R8A77970 bindings")
> Fixes: f231c4178a655b09 ("dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/net/renesas,ravb.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-02-09 22:55 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-06 13:05 [PATCH 0/3] arm64: dts: renesas: r8a77970/r8a77995: Remove non-existing STBE region Geert Uytterhoeven
2018-02-06 13:05 ` [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional Geert Uytterhoeven
2018-02-06 13:17   ` Simon Horman
2018-02-06 14:56   ` Sergei Shtylyov
2018-02-06 15:12     ` Geert Uytterhoeven
2018-02-09 22:55   ` Rob Herring
2018-02-06 13:05 ` [PATCH 2/3] arm64: dts: renesas: r8a77970: Remove non-existing STBE region Geert Uytterhoeven
2018-02-07  9:45   ` Simon Horman
     [not found] ` <1517922354-28421-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2018-02-06 13:05   ` [PATCH 3/3] arm64: dts: renesas: r8a77995: " Geert Uytterhoeven
2018-02-07  9:45     ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).