From: Thierry Reding <thierry.reding@gmail.com>
To: Preetham Chandru Ramchandra <pchandru@nvidia.com>
Cc: tj@kernel.org, cyndis@kapsi.fi, robh+dt@kernel.org,
mark.rutland@arm.com, devicetree@vger.kernel.org,
preetham260@gmail.com, linux-tegra@vger.kernel.org,
linux-ide@vger.kernel.org, vbyravarasu@nvidia.com,
pkunapuli@nvidia.com
Subject: Re: [PATCH V7 2/7] arm64: tegra: Enable AHCI on Jetson TX1
Date: Mon, 19 Feb 2018 15:31:12 +0100 [thread overview]
Message-ID: <20180219143112.GE11455@ulmo> (raw)
In-Reply-To: <1518456406-21564-3-git-send-email-pchandru@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 2094 bytes --]
On Mon, Feb 12, 2018 at 10:56:41PM +0530, Preetham Chandru Ramchandra wrote:
> From: Preetham Ramchandra <pchandru@nvidia.com>
>
> Add sata node to the Tegra210 device tree, and
> enable the device and assign board-specific
> properties on Jetson TX1.
> Signed-off-by: Preetham Chandru R <pchandru@nvidia.com>
Tags such as Signed-off-by: should be in a separate paragraph, so the
above is missing a blank line before the Signed-off-by:.
> ---
> v7:
> * Change commit message to reflect accordingly
> v4:
> * Fixed missing space after 'AUX'
> ---
> arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 6 ++++++
> arch/arm64/boot/dts/nvidia/tegra210.dtsi | 16 ++++++++++++++++
> 2 files changed, 22 insertions(+)
I prefer these to be two separate patches, one for the SoC .dtsi and
another for the P2597 carrier.
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
> index d67ef4319f3b..2aa2979cd6b5 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
> @@ -1325,6 +1325,12 @@
> status = "okay";
> };
>
> + sata@70020000 {
> + status = "okay";
> + phys = <&{/padctl@7009f000/pads/sata/lanes/sata-0}>;
> + phy-names = "sata-0";
> + };
> +
> padctl@7009f000 {
> status = "okay";
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> index 9c2402108772..bf72db5386a5 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> @@ -798,6 +798,22 @@
> #iommu-cells = <1>;
> };
>
> + sata@70020000 {
> + compatible = "nvidia,tegra210-ahci";
> + reg = <0x0 0x70027000 0x0 0x2000>, /* AHCI */
> + <0x0 0x70020000 0x0 0x7000>, /* SATA */
> + <0x0 0x70001100 0x0 0x1000>; /* SATA AUX */
> + interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&tegra_car TEGRA210_CLK_SATA>,
> + <&tegra_car TEGRA210_CLK_SATA_OOB>;
Nit: these are not properly aligned.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-19 14:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 17:26 [PATCH V7 0/7] Refactor and add AHCI support for tegra210 Preetham Chandru Ramchandra
2018-02-12 17:26 ` [PATCH V7 4/7] ata: ahci_tegra: initialize regulators from soc_data Preetham Chandru Ramchandra
2018-02-19 14:42 ` Thierry Reding
2018-02-12 17:26 ` [PATCH V7 5/7] ata: ahci_tegra: disable devslp for t124 Preetham Chandru Ramchandra
2018-02-19 14:47 ` Thierry Reding
[not found] ` <1518456406-21564-1-git-send-email-pchandru-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2018-02-12 17:26 ` [PATCH V7 1/7] dt-bindings: ahci-tegra: add binding documentation Preetham Chandru Ramchandra
2018-02-19 2:46 ` Rob Herring
2018-02-19 14:14 ` Thierry Reding
2018-02-19 14:24 ` Thierry Reding
2018-02-27 12:03 ` Preetham Chandru
2018-02-27 12:02 ` Preetham Chandru
2018-02-19 14:27 ` Thierry Reding
2018-02-27 12:05 ` Preetham Chandru
2018-02-19 14:28 ` Thierry Reding
2018-02-27 12:05 ` Preetham Chandru
2018-02-12 17:26 ` [PATCH V7 2/7] arm64: tegra: Enable AHCI on Jetson TX1 Preetham Chandru Ramchandra
2018-02-19 14:31 ` Thierry Reding [this message]
2018-02-12 17:26 ` [PATCH V7 3/7] ata: ahci_tegra: Update initialization sequence Preetham Chandru Ramchandra
2018-02-19 14:41 ` Thierry Reding
2018-02-19 14:54 ` Thierry Reding
2018-02-12 17:26 ` [PATCH V7 6/7] ata: ahci_tegra: disable DIPM Preetham Chandru Ramchandra
2018-02-19 14:47 ` Thierry Reding
2018-02-12 17:26 ` [PATCH V7 7/7] ata: ahci_tegra: Add AHCI support for Tegra210 Preetham Chandru Ramchandra
2018-02-19 14:49 ` Thierry Reding
2018-02-14 13:11 ` [PATCH V7 0/7] Refactor and add AHCI support for tegra210 Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219143112.GE11455@ulmo \
--to=thierry.reding@gmail.com \
--cc=cyndis@kapsi.fi \
--cc=devicetree@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pchandru@nvidia.com \
--cc=pkunapuli@nvidia.com \
--cc=preetham260@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tj@kernel.org \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).