From: Thierry Reding <thierry.reding@gmail.com>
To: Preetham Chandru Ramchandra <pchandru@nvidia.com>
Cc: tj@kernel.org, cyndis@kapsi.fi, robh+dt@kernel.org,
mark.rutland@arm.com, devicetree@vger.kernel.org,
preetham260@gmail.com, linux-tegra@vger.kernel.org,
linux-ide@vger.kernel.org, vbyravarasu@nvidia.com,
pkunapuli@nvidia.com
Subject: Re: [PATCH V7 7/7] ata: ahci_tegra: Add AHCI support for Tegra210
Date: Mon, 19 Feb 2018 15:49:45 +0100 [thread overview]
Message-ID: <20180219144945.GJ11455@ulmo> (raw)
In-Reply-To: <1518456406-21564-8-git-send-email-pchandru@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1641 bytes --]
On Mon, Feb 12, 2018 at 10:56:46PM +0530, Preetham Chandru Ramchandra wrote:
> From: Preetham Ramchandra <pchandru@nvidia.com>
>
> Add support for the AHCI-compliant Serial ATA host
> controller on the Tegra210 system-on-chip.
>
> Signed-off-by: Preetham Chandru R <pchandru@nvidia.com>
> ---
> v7:
> * Added commit message
> ---
> drivers/ata/ahci_tegra.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
> index ffad5c61e991..4524755b9b23 100644
> --- a/drivers/ata/ahci_tegra.c
> +++ b/drivers/ata/ahci_tegra.c
> @@ -466,11 +466,19 @@ static const struct tegra_ahci_soc tegra124_ahci_soc_data = {
> },
> };
>
> +static const struct tegra_ahci_soc tegra210_ahci_soc_data = {
> + .quirks = NO_DEVSLP,
> +};
> +
> static const struct of_device_id tegra_ahci_of_match[] = {
> {
> .compatible = "nvidia,tegra124-ahci",
> .data = &tegra124_ahci_soc_data
> },
> + {
> + .compatible = "nvidia,tegra210-ahci",
> + .data = &tegra210_ahci_soc_data
> + },
> {}
> };
> MODULE_DEVICE_TABLE(of, tegra_ahci_of_match);
> @@ -585,5 +593,5 @@ static struct platform_driver tegra_ahci_driver = {
> module_platform_driver(tegra_ahci_driver);
>
> MODULE_AUTHOR("Mikko Perttunen <mperttunen@nvidia.com>");
> -MODULE_DESCRIPTION("Tegra124 AHCI SATA driver");
> +MODULE_DESCRIPTION("Tegra AHCI SATA driver");
> MODULE_LICENSE("GPL v2");
I think you should also update the Kconfig file to clarify that this is
no longer Tegra124-only.
With that:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-19 14:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 17:26 [PATCH V7 0/7] Refactor and add AHCI support for tegra210 Preetham Chandru Ramchandra
2018-02-12 17:26 ` [PATCH V7 4/7] ata: ahci_tegra: initialize regulators from soc_data Preetham Chandru Ramchandra
2018-02-19 14:42 ` Thierry Reding
2018-02-12 17:26 ` [PATCH V7 5/7] ata: ahci_tegra: disable devslp for t124 Preetham Chandru Ramchandra
2018-02-19 14:47 ` Thierry Reding
[not found] ` <1518456406-21564-1-git-send-email-pchandru-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2018-02-12 17:26 ` [PATCH V7 1/7] dt-bindings: ahci-tegra: add binding documentation Preetham Chandru Ramchandra
2018-02-19 2:46 ` Rob Herring
2018-02-19 14:14 ` Thierry Reding
2018-02-19 14:24 ` Thierry Reding
2018-02-27 12:03 ` Preetham Chandru
2018-02-27 12:02 ` Preetham Chandru
2018-02-19 14:27 ` Thierry Reding
2018-02-27 12:05 ` Preetham Chandru
2018-02-19 14:28 ` Thierry Reding
2018-02-27 12:05 ` Preetham Chandru
2018-02-12 17:26 ` [PATCH V7 2/7] arm64: tegra: Enable AHCI on Jetson TX1 Preetham Chandru Ramchandra
2018-02-19 14:31 ` Thierry Reding
2018-02-12 17:26 ` [PATCH V7 3/7] ata: ahci_tegra: Update initialization sequence Preetham Chandru Ramchandra
2018-02-19 14:41 ` Thierry Reding
2018-02-19 14:54 ` Thierry Reding
2018-02-12 17:26 ` [PATCH V7 6/7] ata: ahci_tegra: disable DIPM Preetham Chandru Ramchandra
2018-02-19 14:47 ` Thierry Reding
2018-02-12 17:26 ` [PATCH V7 7/7] ata: ahci_tegra: Add AHCI support for Tegra210 Preetham Chandru Ramchandra
2018-02-19 14:49 ` Thierry Reding [this message]
2018-02-14 13:11 ` [PATCH V7 0/7] Refactor and add AHCI support for tegra210 Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219144945.GJ11455@ulmo \
--to=thierry.reding@gmail.com \
--cc=cyndis@kapsi.fi \
--cc=devicetree@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pchandru@nvidia.com \
--cc=pkunapuli@nvidia.com \
--cc=preetham260@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tj@kernel.org \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).