* [PATCH] dt-bindings: media: rcar_vin: Use status "okay"
@ 2018-03-09 9:34 Geert Uytterhoeven
2018-03-09 9:59 ` Niklas Söderlund
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2018-03-09 9:34 UTC (permalink / raw)
To: Niklas Söderlund, Mauro Carvalho Chehab, Rob Herring, Mark Rutland
Cc: Andy Whitcroft, Joe Perches, linux-media, linux-renesas-soc,
devicetree, Geert Uytterhoeven
According to the Devicetree Specification, "ok" is not a valid status.
Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
For the checkpatch TODO list?
https://www.devicetree.org/
Documentation/devicetree/bindings/media/rcar_vin.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
index 68c5c497b7fa5551..a19517e1c669eb35 100644
--- a/Documentation/devicetree/bindings/media/rcar_vin.txt
+++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
@@ -81,7 +81,7 @@ Board setup example for Gen2 platforms (vin1 composite video input)
-------------------------------------------------------------------
&i2c2 {
- status = "ok";
+ status = "okay";
pinctrl-0 = <&i2c2_pins>;
pinctrl-names = "default";
@@ -104,7 +104,7 @@ Board setup example for Gen2 platforms (vin1 composite video input)
pinctrl-0 = <&vin1_pins>;
pinctrl-names = "default";
- status = "ok";
+ status = "okay";
port {
#address-cells = <1>;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: media: rcar_vin: Use status "okay"
2018-03-09 9:34 [PATCH] dt-bindings: media: rcar_vin: Use status "okay" Geert Uytterhoeven
@ 2018-03-09 9:59 ` Niklas Söderlund
2018-03-15 12:31 ` Sakari Ailus
2018-03-18 12:47 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Niklas Söderlund @ 2018-03-09 9:59 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Mauro Carvalho Chehab, Rob Herring, Mark Rutland, Andy Whitcroft,
Joe Perches, linux-media, linux-renesas-soc, devicetree
Hi Geert,
Thanks for your patch.
On 2018-03-09 10:34:40 +0100, Geert Uytterhoeven wrote:
> According to the Devicetree Specification, "ok" is not a valid status.
>
> Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> For the checkpatch TODO list?
> https://www.devicetree.org/
>
> Documentation/devicetree/bindings/media/rcar_vin.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> index 68c5c497b7fa5551..a19517e1c669eb35 100644
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -81,7 +81,7 @@ Board setup example for Gen2 platforms (vin1 composite video input)
> -------------------------------------------------------------------
>
> &i2c2 {
> - status = "ok";
> + status = "okay";
> pinctrl-0 = <&i2c2_pins>;
> pinctrl-names = "default";
>
> @@ -104,7 +104,7 @@ Board setup example for Gen2 platforms (vin1 composite video input)
> pinctrl-0 = <&vin1_pins>;
> pinctrl-names = "default";
>
> - status = "ok";
> + status = "okay";
>
> port {
> #address-cells = <1>;
> --
> 2.7.4
>
--
Regards,
Niklas S�derlund
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: media: rcar_vin: Use status "okay"
2018-03-09 9:34 [PATCH] dt-bindings: media: rcar_vin: Use status "okay" Geert Uytterhoeven
2018-03-09 9:59 ` Niklas Söderlund
@ 2018-03-15 12:31 ` Sakari Ailus
2018-03-18 12:47 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Sakari Ailus @ 2018-03-15 12:31 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Niklas Söderlund, Mauro Carvalho Chehab, Rob Herring,
Mark Rutland, Andy Whitcroft, Joe Perches, linux-media,
linux-renesas-soc, devicetree
On Fri, Mar 09, 2018 at 10:34:40AM +0100, Geert Uytterhoeven wrote:
> According to the Devicetree Specification, "ok" is not a valid status.
>
> Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
There are a few other matches, too, it'd be nice to fix them as well:
$ git grep 'status.*"ok"' -- Documentation/devicetree/bindings/
Documentation/devicetree/bindings/ata/apm-xgene.txt:- status : Shall be "ok" if enabled or "disabled" if disabled.
Documentation/devicetree/bindings/display/hisilicon/dw-dsi.txt: status = "ok";
Documentation/devicetree/bindings/display/ti/ti,omap-dss.txt: status = "ok";
Documentation/devicetree/bindings/display/ti/ti,omap-dss.txt: status = "ok";
Documentation/devicetree/bindings/media/rcar_vin.txt: status = "ok";
Documentation/devicetree/bindings/media/rcar_vin.txt: status = "ok";
Documentation/devicetree/bindings/net/apm-xgene-enet.txt:- status: Should be "ok" or "disabled" for enabled/disabled. Default is "ok".
Documentation/devicetree/bindings/net/apm-xgene-enet.txt: status = "ok";
Documentation/devicetree/bindings/net/apm-xgene-enet.txt: status = "ok";
Documentation/devicetree/bindings/pci/hisilicon-pcie.txt:- status: Either "ok" or "disabled".
Documentation/devicetree/bindings/pci/xgene-pci.txt:- status: Either "ok" or "disabled".
Documentation/devicetree/bindings/pci/xgene-pci.txt: status = "ok";
Documentation/devicetree/bindings/phy/apm-xgene-phy.txt:- status : Shall be "ok" if enabled or "disabled" if disabled.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: media: rcar_vin: Use status "okay"
2018-03-09 9:34 [PATCH] dt-bindings: media: rcar_vin: Use status "okay" Geert Uytterhoeven
2018-03-09 9:59 ` Niklas Söderlund
2018-03-15 12:31 ` Sakari Ailus
@ 2018-03-18 12:47 ` Rob Herring
2018-03-19 8:35 ` Simon Horman
2 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2018-03-18 12:47 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Niklas Söderlund, Mauro Carvalho Chehab, Mark Rutland,
Andy Whitcroft, Joe Perches, linux-media, linux-renesas-soc,
devicetree
On Fri, Mar 09, 2018 at 10:34:40AM +0100, Geert Uytterhoeven wrote:
> According to the Devicetree Specification, "ok" is not a valid status.
Correct.
> Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> For the checkpatch TODO list?
> https://www.devicetree.org/
>
> Documentation/devicetree/bindings/media/rcar_vin.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> index 68c5c497b7fa5551..a19517e1c669eb35 100644
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -81,7 +81,7 @@ Board setup example for Gen2 platforms (vin1 composite video input)
> -------------------------------------------------------------------
>
> &i2c2 {
> - status = "ok";
> + status = "okay";
However, I prefer that status not be in examples as it applies to any
node and the SoC/board split is not relevant to binding docs. I'd
cleaned all these up except for the cases with SoC/board split.
> pinctrl-0 = <&i2c2_pins>;
> pinctrl-names = "default";
>
> @@ -104,7 +104,7 @@ Board setup example for Gen2 platforms (vin1 composite video input)
> pinctrl-0 = <&vin1_pins>;
> pinctrl-names = "default";
>
> - status = "ok";
> + status = "okay";
>
> port {
> #address-cells = <1>;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: media: rcar_vin: Use status "okay"
2018-03-18 12:47 ` Rob Herring
@ 2018-03-19 8:35 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2018-03-19 8:35 UTC (permalink / raw)
To: Rob Herring
Cc: Geert Uytterhoeven, Niklas Söderlund, Mauro Carvalho Chehab,
Mark Rutland, Andy Whitcroft, Joe Perches, linux-media,
linux-renesas-soc, devicetree
On Sun, Mar 18, 2018 at 07:47:57AM -0500, Rob Herring wrote:
> On Fri, Mar 09, 2018 at 10:34:40AM +0100, Geert Uytterhoeven wrote:
> > According to the Devicetree Specification, "ok" is not a valid status.
>
> Correct.
>
> > Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > For the checkpatch TODO list?
> > https://www.devicetree.org/
> >
> > Documentation/devicetree/bindings/media/rcar_vin.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> > index 68c5c497b7fa5551..a19517e1c669eb35 100644
> > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> > @@ -81,7 +81,7 @@ Board setup example for Gen2 platforms (vin1 composite video input)
> > -------------------------------------------------------------------
> >
> > &i2c2 {
> > - status = "ok";
> > + status = "okay";
>
> However, I prefer that status not be in examples as it applies to any
> node and the SoC/board split is not relevant to binding docs. I'd
> cleaned all these up except for the cases with SoC/board split.
Hi Rob,
I'm a little confused. This example is a board override for
a node (implicitly) defined in the DT of an SoC. Could you clarify
when the status should be omitted?
>
> > pinctrl-0 = <&i2c2_pins>;
> > pinctrl-names = "default";
> >
> > @@ -104,7 +104,7 @@ Board setup example for Gen2 platforms (vin1 composite video input)
> > pinctrl-0 = <&vin1_pins>;
> > pinctrl-names = "default";
> >
> > - status = "ok";
> > + status = "okay";
> >
> > port {
> > #address-cells = <1>;
> > --
> > 2.7.4
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-19 8:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-09 9:34 [PATCH] dt-bindings: media: rcar_vin: Use status "okay" Geert Uytterhoeven
2018-03-09 9:59 ` Niklas Söderlund
2018-03-15 12:31 ` Sakari Ailus
2018-03-18 12:47 ` Rob Herring
2018-03-19 8:35 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).