* [PATCH v2 03/14] dt-bindings: qcom_nandc: make nand-ecc-strength optional
[not found] <1525350041-22995-1-git-send-email-absahu@codeaurora.org>
@ 2018-05-03 12:20 ` Abhishek Sahu
2018-05-07 8:40 ` Boris Brezillon
2018-05-21 14:32 ` Miquel Raynal
0 siblings, 2 replies; 4+ messages in thread
From: Abhishek Sahu @ 2018-05-03 12:20 UTC (permalink / raw)
To: Boris Brezillon
Cc: Mark Rutland, devicetree, Archit Taneja, Richard Weinberger,
linux-arm-msm, linux-kernel, Marek Vasut, Abhishek Sahu,
Rob Herring, linux-mtd, Miquel Raynal, Andy Gross, Brian Norris,
David Woodhouse
Now, nand-ecc-strength is optional. If specified in DT, then
controller will use this ECC strength otherwise ECC strength will
be calculated according to chip requirement and available OOB size.
Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
---
* Changes from v1:
NEW PATCH
Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
index 73d336be..f246aa0 100644
--- a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
+++ b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
@@ -45,11 +45,13 @@ Required properties:
number (e.g., 0, 1, 2, etc.)
- #address-cells: see partition.txt
- #size-cells: see partition.txt
-- nand-ecc-strength: see nand.txt
- nand-ecc-step-size: must be 512. see nand.txt for more details.
Optional properties:
- nand-bus-width: see nand.txt
+- nand-ecc-strength: see nand.txt. If not specified, then ECC strength will
+ be used according to chip requirement and available
+ OOB size.
Each nandcs device node may optionally contain a 'partitions' sub-node, which
further contains sub-nodes describing the flash partition mapping. See
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc.
is a member of Code Aurora Forum, hosted by The Linux Foundation
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 03/14] dt-bindings: qcom_nandc: make nand-ecc-strength optional
2018-05-03 12:20 ` [PATCH v2 03/14] dt-bindings: qcom_nandc: make nand-ecc-strength optional Abhishek Sahu
@ 2018-05-07 8:40 ` Boris Brezillon
2018-05-21 14:32 ` Miquel Raynal
1 sibling, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2018-05-07 8:40 UTC (permalink / raw)
To: Abhishek Sahu
Cc: Mark Rutland, devicetree, Archit Taneja, Richard Weinberger,
linux-arm-msm, linux-kernel, Marek Vasut, Rob Herring, linux-mtd,
Miquel Raynal, Andy Gross, Brian Norris, David Woodhouse
On Thu, 3 May 2018 17:50:30 +0530
Abhishek Sahu <absahu@codeaurora.org> wrote:
> Now, nand-ecc-strength is optional. If specified in DT, then
> controller will use this ECC strength otherwise ECC strength will
> be calculated according to chip requirement and available OOB size.
>
> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
> ---
> * Changes from v1:
>
> NEW PATCH
>
> Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
> index 73d336be..f246aa0 100644
> --- a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
> +++ b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
> @@ -45,11 +45,13 @@ Required properties:
> number (e.g., 0, 1, 2, etc.)
> - #address-cells: see partition.txt
> - #size-cells: see partition.txt
> -- nand-ecc-strength: see nand.txt
> - nand-ecc-step-size: must be 512. see nand.txt for more details.
As mentioned in my other review, no need to specify nand-ecc-step-size
if you don't have a choice. You can remove the property and say that
nand-ecc-strength encodes the ECC strength for 512 bytes chunks.
>
> Optional properties:
> - nand-bus-width: see nand.txt
> +- nand-ecc-strength: see nand.txt. If not specified, then ECC strength will
> + be used according to chip requirement and available
> + OOB size.
>
> Each nandcs device node may optionally contain a 'partitions' sub-node, which
> further contains sub-nodes describing the flash partition mapping. See
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 03/14] dt-bindings: qcom_nandc: make nand-ecc-strength optional
2018-05-03 12:20 ` [PATCH v2 03/14] dt-bindings: qcom_nandc: make nand-ecc-strength optional Abhishek Sahu
2018-05-07 8:40 ` Boris Brezillon
@ 2018-05-21 14:32 ` Miquel Raynal
2018-05-22 14:08 ` Abhishek Sahu
1 sibling, 1 reply; 4+ messages in thread
From: Miquel Raynal @ 2018-05-21 14:32 UTC (permalink / raw)
To: Abhishek Sahu
Cc: Boris Brezillon, David Woodhouse, Brian Norris, Marek Vasut,
Richard Weinberger, linux-arm-msm, linux-kernel, linux-mtd,
Andy Gross, Archit Taneja, Rob Herring, Mark Rutland, devicetree
Hi Abhishek,
On Thu, 3 May 2018 17:50:30 +0530, Abhishek Sahu
<absahu@codeaurora.org> wrote:
> Now, nand-ecc-strength is optional. If specified in DT, then
> controller will use this ECC strength otherwise ECC strength will
> be calculated according to chip requirement and available OOB size.
Same comment as before: don't start the commit log with "now,".
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 03/14] dt-bindings: qcom_nandc: make nand-ecc-strength optional
2018-05-21 14:32 ` Miquel Raynal
@ 2018-05-22 14:08 ` Abhishek Sahu
0 siblings, 0 replies; 4+ messages in thread
From: Abhishek Sahu @ 2018-05-22 14:08 UTC (permalink / raw)
To: Miquel Raynal
Cc: Boris Brezillon, David Woodhouse, Brian Norris, Marek Vasut,
Richard Weinberger, linux-arm-msm, linux-kernel, linux-mtd,
Andy Gross, Archit Taneja, Rob Herring, Mark Rutland, devicetree
On 2018-05-21 20:02, Miquel Raynal wrote:
> Hi Abhishek,
>
> On Thu, 3 May 2018 17:50:30 +0530, Abhishek Sahu
> <absahu@codeaurora.org> wrote:
>
>> Now, nand-ecc-strength is optional. If specified in DT, then
>> controller will use this ECC strength otherwise ECC strength will
>> be calculated according to chip requirement and available OOB size.
>
> Same comment as before: don't start the commit log with "now,".
>
> Thanks,
> Miquèl
Thanks Miquel.
I will change the commit message.
Regards,
Abhishek
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-22 14:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1525350041-22995-1-git-send-email-absahu@codeaurora.org>
2018-05-03 12:20 ` [PATCH v2 03/14] dt-bindings: qcom_nandc: make nand-ecc-strength optional Abhishek Sahu
2018-05-07 8:40 ` Boris Brezillon
2018-05-21 14:32 ` Miquel Raynal
2018-05-22 14:08 ` Abhishek Sahu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).