From: Rob Herring <robh@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: kishon@ti.com, mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Manu Gautam <mgautam@codeaurora.org>,
Varadarajan Narayanan <varada@codeaurora.org>
Subject: Re: [PATCH] phy: qcom-qmp: Fix dts bindings to reflect reality
Date: Fri, 20 Jul 2018 08:10:59 -0600 [thread overview]
Message-ID: <20180720141059.GA3064@rob-hp-laptop> (raw)
In-Reply-To: <20180706233142.166296-1-dianders@chromium.org>
On Fri, Jul 06, 2018 at 04:31:42PM -0700, Douglas Anderson wrote:
> A few patches have landed for the qcom-qmp PHY that affect how you
> would write a device tree node. ...yet the bindings weren't updated.
> Let's remedy the situation and make the bindings refelect reality.
"dt-bindings: phy: ..." for the subject.
>
> Fixes: efb05a50c956 ("phy: qcom-qmp: Add support for QMP V3 USB3 PHY")
> Fixes: ac0d239936bd ("phy: qcom-qmp: Add support for runtime PM")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> .../devicetree/bindings/phy/qcom-qmp-phy.txt | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> index 266a1bb8bb6e..0c7629e88bf3 100644
> --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> @@ -12,7 +12,14 @@ Required properties:
> "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845,
> "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845.
>
> - - reg: offset and length of register set for PHY's common serdes block.
> + - reg:
> + - For "qcom,sdm845-qmp-usb3-phy":
> + - index 0: address and length of register set for PHY's common serdes
> + block.
> + - named register "dp_com" (using reg-names): address and length of the
> + DP_COM control block.
You need to list reg-names and what are the names for the other 2
regions?
> + - For all others:
> + - offset and length of register set for PHY's common serdes block.
>
> - #clock-cells: must be 1
> - Phy pll outputs a bunch of clocks for Tx, Rx and Pipe
> @@ -60,7 +67,10 @@ Required nodes:
>
> Required properties for child node:
> - reg: list of offset and length pairs of register sets for PHY blocks -
> - tx, rx and pcs.
> + - index 0: tx
> + - index 1: rx
> + - index 2: pcs
> + - index 3: pcs_misc (optional)
>
> - #phy-cells: must be 0
>
> --
> 2.18.0.203.gfac676dfb9-goog
>
next prev parent reply other threads:[~2018-07-20 14:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 23:31 [PATCH] phy: qcom-qmp: Fix dts bindings to reflect reality Douglas Anderson
2018-07-20 14:10 ` Rob Herring [this message]
2018-07-20 15:13 ` Doug Anderson
2018-07-20 17:26 ` Rob Herring
2018-07-20 17:54 ` Doug Anderson
2018-07-23 14:04 ` Rob Herring
2018-07-23 17:37 ` Doug Anderson
2018-07-23 23:33 ` Rob Herring
2018-08-07 5:18 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720141059.GA3064@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=varada@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).