From: Doug Anderson <dianders@chromium.org>
To: Rob Herring <robh@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Manu Gautam <mgautam@codeaurora.org>,
Varadarajan Narayanan <varada@codeaurora.org>
Subject: Re: [PATCH] phy: qcom-qmp: Fix dts bindings to reflect reality
Date: Mon, 6 Aug 2018 22:18:03 -0700 [thread overview]
Message-ID: <CAD=FV=We9OQggYh_vpB6AF4uj=Fk1cqVZZhOijfOv0fEh98DZw@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq+MMunmVWqeW9v2RyzsMKP+=kMzeTHNMG4JDHM7Fy0HBg@mail.gmail.com>
Hi,
On Mon, Jul 23, 2018 at 4:33 PM, Rob Herring <robh@kernel.org> wrote:
>> OK, I guess I will try again then and you can tell me when I get it
>> right (unless you tell me I should just change the driver to not use
>> named registers at all). How about:
>>
>> - reg:
>> - For "qcom,sdm845-qmp-usb3-phy":
>> - index 0: address and length of register set for PHY's common serdes
>> block.
>> - index 1: address and length of the DP_COM control block.
>
> Instead of repeating index 0 below, just say "for
> 'qcom,sdm845-qmp-usb3-phy' only" here.
>
>> - For all others:
>> - index 0: address and length of register set for PHY's common serdes
>> block.
>> - reg-names:
>> - For "qcom,sdm845-qmp-usb3-phy":
>> - Should be: "reg-base", "dp_com"
>> - For all others:
>> - The reg-names property shouldn't be defined.
To close the loop, I've just posted
<https://lore.kernel.org/patchwork/patch/972177/> AKA ("dt-bindings:
phy: qcom-qmp: Cleanup the 'reg' documentation as per review").
Hopefully that addresses everything properly but if not I'm happy to
spin it again. Thanks for your patience in helping me understand what
you were looking for.
-Doug
prev parent reply other threads:[~2018-08-07 5:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 23:31 [PATCH] phy: qcom-qmp: Fix dts bindings to reflect reality Douglas Anderson
2018-07-20 14:10 ` Rob Herring
2018-07-20 15:13 ` Doug Anderson
2018-07-20 17:26 ` Rob Herring
2018-07-20 17:54 ` Doug Anderson
2018-07-23 14:04 ` Rob Herring
2018-07-23 17:37 ` Doug Anderson
2018-07-23 23:33 ` Rob Herring
2018-08-07 5:18 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=We9OQggYh_vpB6AF4uj=Fk1cqVZZhOijfOv0fEh98DZw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=robh@kernel.org \
--cc=varada@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).