* [PATCH V2 2/2] arm64: dts: imx8mq: Correct OPP table according to latest datasheet
2019-06-29 10:21 [PATCH V2 1/2] arm64: dts: imx8mm: Correct OPP table according to latest datasheet Anson.Huang
@ 2019-06-29 10:21 ` Anson.Huang
2019-07-01 13:20 ` [PATCH V2 1/2] arm64: dts: imx8mm: " Leonard Crestez
2019-07-18 8:03 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Anson.Huang @ 2019-06-29 10:21 UTC (permalink / raw)
To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
leonard.crestez, viresh.kumar, ping.bai, daniel.baluta, l.stach,
abel.vesa, andrew.smirnov, ccaione, angus, agx, devicetree,
linux-arm-kernel, linux-kernel
Cc: Linux-imx
From: Anson Huang <Anson.Huang@nxp.com>
According to latest datasheet (Rev.1, 10/2018) from below links,
in the consumer datasheet, 1.5GHz is mentioned as highest opp but
depends on speed grading fuse, and in the industrial datasheet,
1.3GHz is mentioned as highest opp but depends on speed grading
fuse. 1.5GHz and 1.3GHz opp use same voltage, so no need for
consumer part to support 1.3GHz opp, with same voltage, CPU should
run at highest frequency in order to go into idle as quick as
possible, this can save power.
That means for consumer part, 1GHz/1.5GHz are supported, for
industrial part, 800MHz/1.3GHz are supported, and then check the
speed grading fuse to limit the highest CPU frequency further.
Correct the market segment bits in opp table to make them work
according to datasheets.
https://www.nxp.com/docs/en/data-sheet/IMX8MDQLQIEC.pdf
https://www.nxp.com/docs/en/data-sheet/IMX8MDQLQCEC.pdf
Fixes: 12629c5c3749 ("arm64: dts: imx8mq: Add cpu speed grading and all OPPs")
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
Changes since V1:
- remove the comment to avoid any confusion.
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 9d99191..477c523 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -169,15 +169,14 @@
opp-1300000000 {
opp-hz = /bits/ 64 <1300000000>;
opp-microvolt = <1000000>;
- opp-supported-hw = <0xc>, <0x7>;
+ opp-supported-hw = <0xc>, <0x4>;
clock-latency-ns = <150000>;
};
opp-1500000000 {
opp-hz = /bits/ 64 <1500000000>;
opp-microvolt = <1000000>;
- /* Consumer only but rely on speed grading */
- opp-supported-hw = <0x8>, <0x7>;
+ opp-supported-hw = <0x8>, <0x3>;
clock-latency-ns = <150000>;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH V2 1/2] arm64: dts: imx8mm: Correct OPP table according to latest datasheet
2019-06-29 10:21 [PATCH V2 1/2] arm64: dts: imx8mm: Correct OPP table according to latest datasheet Anson.Huang
2019-06-29 10:21 ` [PATCH V2 2/2] arm64: dts: imx8mq: " Anson.Huang
@ 2019-07-01 13:20 ` Leonard Crestez
2019-07-18 8:03 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Leonard Crestez @ 2019-07-01 13:20 UTC (permalink / raw)
To: Anson Huang, shawnguo
Cc: mark.rutland, devicetree, Jacky Bai, ccaione, andrew.smirnov,
viresh.kumar, s.hauer, angus, linux-kernel, Daniel Baluta,
Abel Vesa, robh+dt, dl-linux-imx, kernel, festevam, agx,
linux-arm-kernel, l.stach
On 6/29/2019 1:31 PM, Anson.Huang@nxp.com wrote:
> From: Anson Huang <Anson.Huang@nxp.com>
>
> According to latest datasheet (Rev.0.2, 04/2019) from below links,
> 1.8GHz is ONLY available for consumer part, so the market segment
> bits for 1.8GHz opp should ONLY available for consumer part accordingly.
> > Fixes: f403a26c865b (arm64: dts: imx8mm: Add cpu speed grading and
all OPPs)
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
For both:
Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
The vendor tree goes through a lot of testing so switching to the exact
speed grading interpretation from there does make sense.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2 1/2] arm64: dts: imx8mm: Correct OPP table according to latest datasheet
2019-06-29 10:21 [PATCH V2 1/2] arm64: dts: imx8mm: Correct OPP table according to latest datasheet Anson.Huang
2019-06-29 10:21 ` [PATCH V2 2/2] arm64: dts: imx8mq: " Anson.Huang
2019-07-01 13:20 ` [PATCH V2 1/2] arm64: dts: imx8mm: " Leonard Crestez
@ 2019-07-18 8:03 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2019-07-18 8:03 UTC (permalink / raw)
To: Anson.Huang
Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam,
leonard.crestez, viresh.kumar, ping.bai, daniel.baluta, l.stach,
abel.vesa, andrew.smirnov, ccaione, angus, agx, devicetree,
linux-arm-kernel, linux-kernel, Linux-imx
On Sat, Jun 29, 2019 at 06:21:56PM +0800, Anson.Huang@nxp.com wrote:
> From: Anson Huang <Anson.Huang@nxp.com>
>
> According to latest datasheet (Rev.0.2, 04/2019) from below links,
> 1.8GHz is ONLY available for consumer part, so the market segment
> bits for 1.8GHz opp should ONLY available for consumer part accordingly.
>
> https://www.nxp.com/docs/en/data-sheet/IMX8MMIEC.pdf
> https://www.nxp.com/docs/en/data-sheet/IMX8MMCEC.pdf
>
> Fixes: f403a26c865b (arm64: dts: imx8mm: Add cpu speed grading and all OPPs)
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Applied both, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread