From: Vinod Koul <vkoul@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: broonie@kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, mark.rutland@arm.com,
pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
bgoswami@quicinc.com
Subject: Re: [RFC PATCH 3/5] soundwire: add module_sdw_driver helper macro
Date: Mon, 1 Jul 2019 11:53:04 +0530 [thread overview]
Message-ID: <20190701062304.GL2911@vkoul-mobl> (raw)
In-Reply-To: <20190611104043.22181-4-srinivas.kandagatla@linaro.org>
On 11-06-19, 11:40, Srinivas Kandagatla wrote:
> This Helper macro is for SoundWire drivers which do not do anything special in
> module init/exit. This eliminates a lot of boilerplate. Each module may only
> use this macro once, and calling it replaces module_init() and module_exit()
Applied, thanks
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> include/linux/soundwire/sdw_type.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/include/linux/soundwire/sdw_type.h b/include/linux/soundwire/sdw_type.h
> index 9c756b5a0dfe..aaa7f4267c14 100644
> --- a/include/linux/soundwire/sdw_type.h
> +++ b/include/linux/soundwire/sdw_type.h
> @@ -16,4 +16,15 @@ void sdw_unregister_driver(struct sdw_driver *drv);
>
> int sdw_slave_modalias(const struct sdw_slave *slave, char *buf, size_t size);
>
> +/**
> + * module_sdw_driver() - Helper macro for registering a Soundwire driver
> + * @__sdw_driver: soundwire slave driver struct
> + *
> + * Helper macro for Soundwire drivers which do not do anything special in
> + * module init/exit. This eliminates a lot of boilerplate. Each module may only
> + * use this macro once, and calling it replaces module_init() and module_exit()
> + */
> +#define module_sdw_driver(__sdw_driver) \
> + module_driver(__sdw_driver, sdw_register_driver, \
> + sdw_unregister_driver)
> #endif /* __SOUNDWIRE_TYPES_H */
> --
> 2.21.0
--
~Vinod
next prev parent reply other threads:[~2019-07-01 6:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 10:40 [RFC PATCH 0/5] ASoC: codecs: Add WSA881x Smart Speaker amplifier support Srinivas Kandagatla
2019-06-11 10:40 ` [RFC PATCH 1/5] dt-bindings: soundwire: add slave bindings Srinivas Kandagatla
2019-07-01 6:11 ` Vinod Koul
2019-07-02 8:22 ` Srinivas Kandagatla
2019-07-02 9:45 ` Vinod Koul
2019-06-11 10:40 ` [RFC PATCH 2/5] soundwire: core: add device tree support for slave devices Srinivas Kandagatla
2019-07-01 6:17 ` Vinod Koul
2019-07-02 8:22 ` Srinivas Kandagatla
2019-06-11 10:40 ` [RFC PATCH 3/5] soundwire: add module_sdw_driver helper macro Srinivas Kandagatla
2019-07-01 6:23 ` Vinod Koul [this message]
2019-06-11 10:40 ` [RFC PATCH 4/5] dt-bindings: ASoC: Add WSA881x bindings Srinivas Kandagatla
2019-06-11 10:40 ` [RFC PATCH 5/5] ASoC: codecs: add wsa881x amplifier support Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701062304.GL2911@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).