From: Vinod Koul <vkoul@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: broonie@kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, mark.rutland@arm.com,
pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
bgoswami@quicinc.com
Subject: Re: [RFC PATCH 1/5] dt-bindings: soundwire: add slave bindings
Date: Tue, 2 Jul 2019 15:15:10 +0530 [thread overview]
Message-ID: <20190702094510.GO2911@vkoul-mobl> (raw)
In-Reply-To: <ce1e445e-3254-1308-8752-2cb56a7e0cc6@linaro.org>
On 02-07-19, 09:22, Srinivas Kandagatla wrote:
> Thanks Vinod for taking time to review,
>
> On 01/07/2019 07:11, Vinod Koul wrote:
> > On 11-06-19, 11:40, Srinivas Kandagatla wrote:
> > > This patch adds bindings for Soundwire Slave devices which includes how
> > > SoundWire enumeration address is represented in SoundWire slave device
> > > tree nodes.
> > >
> > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > > ---
> > > .../devicetree/bindings/soundwire/bus.txt | 48 +++++++++++++++++++
> > > 1 file changed, 48 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/soundwire/bus.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/soundwire/bus.txt b/Documentation/devicetree/bindings/soundwire/bus.txt
> > > new file mode 100644
> > > index 000000000000..19a672b0d528
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/soundwire/bus.txt
> >
> > The bindings are for slave right and the file is bus.txt?
>
> I tried to follow what I have done for SLIMBus.
> Do you prefer them to be documented in slave.txt?
Would that not be better :) We should have a master.txt for bus things
> > > @@ -0,0 +1,48 @@
> > > +SoundWire bus bindings.
> > > +
> > > +SoundWire is a 2-pin multi-drop interface with data and clock line.
> > > +It facilitates development of low cost, efficient, high performance systems.
> > > +
> > > +SoundWire controller bindings are very much specific to vendor.
> > > +
> > > +Child nodes(SLAVE devices):
> > > +Every SoundWire controller node can contain zero or more child nodes
> > > +representing slave devices on the bus. Every SoundWire slave device is
> > > +uniquely determined by the enumeration address containing 5 fields:
> > > +SoundWire Version, Instance ID, Manufacturer ID, Part ID and Class ID
> > > +for a device. Addition to below required properties, child nodes can
> > > +have device specific bindings.
> > > +
> > > +Required property for SoundWire child node if it is present:
> > > +- compatible: "sdwVER,MFD,PID,CID". The textual representation of
> > > + SoundWire Enumeration address comprising SoundWire
> > > + Version, Manufacturer ID, Part ID and Class ID,
> > > + shall be in lower-case hexadecimal with leading
> > > + zeroes suppressed.
> > > + Version number '0x10' represents SoundWire 1.0
> > > + Version number '0x11' represents SoundWire 1.1
> > > + ex: "sdw10,0217,2010,0"
> >
> > any reason why we want to code version number and not say sdw,1.0,...
> > and so on?
>
> For consistency reasons, as other info in hex.
>
> >
> > > +
> > > +- sdw-instance-id: Should be ('Instance ID') from SoundWire
> > > + Enumeration Address. Instance ID is for the cases
> > > + where multiple Devices of the same type or Class
> > > + are attached to the bus.
> >
> > instance id is part of the 48bit device id, so wont it make sense to add
> > that to compatible as well?
> >
> So we could have multiple instance of same IP, so adding this to compatible
> string does not make sense! As driver has to list all the possible
> compatible strings.
Yes that makes sense.
--
~Vinod
next prev parent reply other threads:[~2019-07-02 9:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 10:40 [RFC PATCH 0/5] ASoC: codecs: Add WSA881x Smart Speaker amplifier support Srinivas Kandagatla
2019-06-11 10:40 ` [RFC PATCH 1/5] dt-bindings: soundwire: add slave bindings Srinivas Kandagatla
2019-07-01 6:11 ` Vinod Koul
2019-07-02 8:22 ` Srinivas Kandagatla
2019-07-02 9:45 ` Vinod Koul [this message]
2019-06-11 10:40 ` [RFC PATCH 2/5] soundwire: core: add device tree support for slave devices Srinivas Kandagatla
2019-07-01 6:17 ` Vinod Koul
2019-07-02 8:22 ` Srinivas Kandagatla
2019-06-11 10:40 ` [RFC PATCH 3/5] soundwire: add module_sdw_driver helper macro Srinivas Kandagatla
2019-07-01 6:23 ` Vinod Koul
2019-06-11 10:40 ` [RFC PATCH 4/5] dt-bindings: ASoC: Add WSA881x bindings Srinivas Kandagatla
2019-06-11 10:40 ` [RFC PATCH 5/5] ASoC: codecs: add wsa881x amplifier support Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702094510.GO2911@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).